Skip to contentSkip to conversation

ARM: dts: aspeed: Add device tree for Liwu2 BMC

PATCH In review Willie Thai 4 participants 8 messages Jan 7, 2021 – Aug 20, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: aspeed: Add device tree for Liwu2 BMC

From: willie <[email protected]>

---
 arch/arm/boot/dts/Makefile                    |   3 +-
 arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts | 605 ++++++++++++++++++++++++++
 2 files changed, 607 insertions(+), 1 deletion(-)
 create mode 100755 arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts
arch/arm/boot/dts/Makefile +2 -1
index 5a14adc..8ccb5d3 100644
@@ -1381,4 +1381,5 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-opp-zaius.dtb \
 	aspeed-bmc-portwell-neptune.dtb \
 	aspeed-bmc-quanta-q71l.dtb \
-	aspeed-bmc-supermicro-x11spi.dtb
+	aspeed-bmc-supermicro-x11spi.dtb \
+	aspeed-bmc-compal-liwu2.dtb
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +605 -0

605 lines not on this page · raw message

Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 2 lines · Willie Thai

From: willie <[email protected]>

Please add a short description of the machine you're adding. Take a look at the git history for other BMC machines to see what I mean.

Quoted 12 lines
---
 arch/arm/boot/dts/Makefile                    |   3 +-
 arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts | 605 ++++++++++++++++++++++++++
 2 files changed, 607 insertions(+), 1 deletion(-)
 create mode 100755 arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts
arch/arm/boot/dts/Makefile +0 -0
index 5a14adc..8ccb5d3 100644

arch/arm/boot/dts/Makefile dtb-$(CONFIG_ARCH_ASPEED) += \ · line 1385

Quoted 6 lines
arch/arm/boot/dts/Makefile +2 -1
@@ -1381,4 +1381,5 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
        aspeed-bmc-opp-zaius.dtb \
        aspeed-bmc-portwell-neptune.dtb \
        aspeed-bmc-quanta-q71l.dtb \
-       aspeed-bmc-supermicro-x11spi.dtb
+       aspeed-bmc-supermicro-x11spi.dtb \
+       aspeed-bmc-compal-liwu2.dtb

This should be sorted alphabetically.

Quoted 25 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +19 -0
new file mode 100755
index 0000000..5882b42
@@ -0,0 +1,605 @@
+// SPDX-License-Identifier: GPL-2.0+
+/dts-v1/;
+
+#include "aspeed-g5.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>
+
+/ {
+       model = "AST2500 liwu2";
+       compatible = "aspeed,ast2500";
+
+       aliases {
+               serial4 = &uart5;
+       };
+
+       chosen {
+               stdout-path = &uart5;
+               bootargs = "console=tty0 console=ttyS4,115200 earlyprintk";
+       };
+

arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts line 29

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +10 -0
+       memory@80000000 {
+               reg = <0x80000000 0x20000000>;
+       };
+
+       reserved-memory {
+               #address-cells = <1>;
+               #size-cells = <1>;
+               ranges;
+
+               gfx_memory: framebuffer {

Are you sure you're using this device? This is the BMC's internal graphics device, not the one that is attached to the host over PCI. If you're only using host graphics then you don't need this node.

Quoted 56 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +56 -0
+                       size = <0x01000000>;
+                       alignment = <0x01000000>;
+                       compatible = "shared-dma-pool";
+                       reusable;
+               };
+       };
+
+       iio-hwmon {
+               compatible = "iio-hwmon";
+               io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>,
+                             <&adc 4>, <&adc 5>, <&adc 6>, <&adc 7>,
+                             <&adc 8>, <&adc 9>, <&adc 10>, <&adc 11>,
+                             <&adc 12>, <&adc 13>, <&adc 14>, <&adc 15>;
+       };
+
+       leds {
+               compatible = "gpio-leds";
+
+               LED_FAN0_FAULT {
+                       label = "LED_FAN0_FAULT";
+                       gpios = <&gpio ASPEED_GPIO(F, 4) GPIO_ACTIVE_LOW>;
+               };
+
+               LED_FAN1_FAULT {
+                       label = "LED_FAN1_FAULT";
+                       gpios = <&gpio ASPEED_GPIO(F, 5) GPIO_ACTIVE_LOW>;
+               };
+
+               LED_FAN2_FAULT {
+                       label = "LED_FAN2_FAULT";
+                       gpios = <&gpio ASPEED_GPIO(H, 2) GPIO_ACTIVE_LOW>;
+               };
+
+               LED_FAN3_FAULT {
+                       label = "LED_FAN3_FAULT";
+                       gpios = <&gpio ASPEED_GPIO(H, 5) GPIO_ACTIVE_LOW>;
+               };
+
+               LED_FAN4_FAULT {
+                       label = "LED_FAN4_FAULT";
+                       gpios = <&gpio ASPEED_GPIO(H, 6) GPIO_ACTIVE_LOW>;
+               };
+
+               LED_FAN5_FAULT {
+                       label = "LED_FAN5_FAULT";
+                       gpios = <&gpio ASPEED_GPIO(H, 7) GPIO_ACTIVE_LOW>;
+               };
+
+               FP_LED_STATUS_AMBER_N {
+                       label = "FP_LED_STATUS_AMBER_N";
+                       gpios = <&gpio ASPEED_GPIO(S, 5) GPIO_ACTIVE_LOW>;
+               };
+
+               REAR_ID_LED_N {
+                       label = "REAR_ID_LED_N";
+                       gpios = <&gpio ASPEED_GPIO(S, 6) GPIO_ACTIVE_LOW>;

arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts line 95

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +10 -0
+               };
+       };
+
+       gpio-keys-polled {
+               compatible = "gpio-keys-polled";
+               poll-interval = <1000>;
+
+               FM_SYS_FAN0_PRSNT_D_N {
+                       label = "FM_SYS_FAN0_PRSNT_D_N";
+                       gpios = <&gpio ASPEED_GPIO(M, 0) GPIO_ACTIVE_LOW>;

The internal GPIO device can generate interrupts, so you don't need to use gpio-keys-polled, you should be able to use gpio-keys. This should be fixed before merging your device tree.

Secondly, you shouldn't need to use gpio-keys at all, as you can use the gpio chardev interface to be notified in userspace when a pin changes level. This is a mistake that many openbmc systems have made, so while I recommend you fix your userspace, it will not block the merging of this patch.

Quoted 107 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +107 -0
+                       linux,code = <ASPEED_GPIO(M, 0)>;
+               };
+
+               FM_SYS_FAN1_PRSNT_D_N {
+                       label = "FM_SYS_FAN1_PRSNT_D_N";
+                       gpios = <&gpio ASPEED_GPIO(M, 1) GPIO_ACTIVE_LOW>;
+                       linux,code = <ASPEED_GPIO(M, 1)>;
+               };
+
+               FM_SYS_FAN2_PRSNT_D_N {
+                       label = "FM_SYS_FAN2_PRSNT_D_N";
+                       gpios = <&gpio ASPEED_GPIO(M, 2) GPIO_ACTIVE_LOW>;
+                       linux,code = <ASPEED_GPIO(M, 2)>;
+               };
+
+               FM_SYS_FAN3_PRSNT_D_N {
+                       label = "FM_SYS_FAN3_PRSNT_D_N";
+                       gpios = <&gpio ASPEED_GPIO(M, 3) GPIO_ACTIVE_LOW>;
+                       linux,code = <ASPEED_GPIO(M, 3)>;
+               };
+
+               FM_SYS_FAN4_PRSNT_D_N {
+                       label = "FM_SYS_FAN4_PRSNT_D_N";
+                       gpios = <&gpio ASPEED_GPIO(M, 4) GPIO_ACTIVE_LOW>;
+                       linux,code = <ASPEED_GPIO(M, 4)>;
+               };
+
+               FM_SYS_FAN5_PRSNT_D_N {
+                       label = "FM_SYS_FAN5_PRSNT_D_N";
+                       gpios = <&gpio ASPEED_GPIO(M, 5) GPIO_ACTIVE_LOW>;
+                       linux,code = <ASPEED_GPIO(M, 5)>;
+               };
+
+               FM_SYS_FAN6_PRSNT_D_N {
+                       label = "FM_SYS_FAN6_PRSNT_D_N";
+                       gpios = <&gpio ASPEED_GPIO(S, 7) GPIO_ACTIVE_LOW>;
+                       linux,code = <ASPEED_GPIO(S, 7)>;
+               };
+
+               FM_SYS_FAN7_PRSNT_D_N {
+                       label = "FM_SYS_FAN7_PRSNT_D_N";
+                       gpios = <&gpio ASPEED_GPIO(AB, 1) GPIO_ACTIVE_LOW>;
+                       linux,code = <ASPEED_GPIO(AB, 1)>;
+               };
+       };
+
+       gpio-keys {
+               compatible = "gpio-keys";
+               // A0-A7
+               BMC_SEL_M2_SATA_PCIE {
+                       label = "BMC_SEL_M2_SATA_PCIE";
+                       gpios = <&gpio ASPEED_GPIO(A, 0) GPIO_ACTIVE_HIGH>;
+                       linux,code = <ASPEED_GPIO(A, 0)>;
+               };
+
+               PD_RMII_BMC_MDC {
+                       label = "PD_RMII_BMC_MDC";
+                       gpios = <&gpio ASPEED_GPIO(A, 6) GPIO_ACTIVE_HIGH>;
+                       linux,code = <ASPEED_GPIO(A, 6)>;
+               };
+
+               PD_RMII_BMC_MDIO {
+                       label = "PD_RMII_BMC_MDIO";
+                       gpios = <&gpio ASPEED_GPIO(A, 7) GPIO_ACTIVE_HIGH>;
+                       linux,code = <ASPEED_GPIO(A, 7)>;
+               };
+               // B0-B7
+               VR_PVCCIN_PVCCSA_CPU1_FAULT_N {
+                       label = "VR_PVCCIN_PVCCSA_CPU1_FAULT_N";
+                       gpios = <&gpio ASPEED_GPIO(B, 0) GPIO_ACTIVE_LOW>;
+                       linux,code = <ASPEED_GPIO(B, 0)>;
+               };
+
+               VR_PVCCIN_PVCCSA_CPU2_FAULT_N {
+                       label = "VR_PVCCIN_PVCCSA_CPU2_FAULT_N";
+                       gpios = <&gpio ASPEED_GPIO(B, 1) GPIO_ACTIVE_LOW>;
+                       linux,code = <ASPEED_GPIO(B, 1)>;
+               };
+
+               VR_PVCCIO_CPU1_FAULT_N {
+                       label = "VR_PVCCIO_CPU1_FAULT_N";
+                       gpios = <&gpio ASPEED_GPIO(B, 2) GPIO_ACTIVE_LOW>;
+                       linux,code = <ASPEED_GPIO(B, 2)>;
+               };
+
+               VR_PVCCIO_CPU2_FAULT_N {
+                       label = "VR_PVCCIO_CPU2_FAULT_N";
+                       gpios = <&gpio ASPEED_GPIO(B, 3) GPIO_ACTIVE_LOW>;
+                       linux,code = <ASPEED_GPIO(B, 3)>;
+               };
+
+               NC_CLK_48M_USB_NMC_R2 {
+                       label = "NC_CLK_48M_USB_NMC_R2";
+                       gpios = <&gpio ASPEED_GPIO(B, 4) GPIO_ACTIVE_HIGH>;
+                       linux,code = <ASPEED_GPIO(B, 4)>;
+               };
+
+               PU_BMC_GPIOB6 {
+                       label = "PU_BMC_GPIOB6";
+                       gpios = <&gpio ASPEED_GPIO(B, 6) GPIO_ACTIVE_HIGH>;
+                       linux,code = <ASPEED_GPIO(B, 6)>;
+               };
+
+               NC_BMC_GPIOB7 {
+                       label = "NC_BMC_GPIOB7";
+                       gpios = <&gpio ASPEED_GPIO(B, 7) GPIO_ACTIVE_HIGH>;
+                       linux,code = <ASPEED_GPIO(B, 7)>;

arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts line 212

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +10 -0
+               };
+               // C0-C7
+               PROJECT_REV_ID0 {
+                       label = "PROJECT_REV_ID0";
+                       gpios = <&gpio ASPEED_GPIO(C, 0) GPIO_ACTIVE_HIGH>;
+                       linux,code = <ASPEED_GPIO(C, 0)>;
+               };
+
+               PROJECT_REV_ID1 {
+                       label = "PROJECT_REV_ID1";

I'm reading this and wondering why you need to expose the ID pins as a input event. Are you aware that you can and should read GPIO state without exposing them as gpio-keys?

Quoted 77 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +77 -0
+                       gpios = <&gpio ASPEED_GPIO(C, 1) GPIO_ACTIVE_HIGH>;
+                       linux,code = <ASPEED_GPIO(C, 1)>;
+               };
+
+               PROJECT_REV_ID2 {
+                       label = "PROJECT_REV_ID2";
+                       gpios = <&gpio ASPEED_GPIO(C, 2) GPIO_ACTIVE_HIGH>;
+                       linux,code = <ASPEED_GPIO(C, 2)>;
+               };
+
+               PCB_REV_ID0 {
+                       label = "PCB_REV_ID0";
+                       gpios = <&gpio ASPEED_GPIO(C, 3) GPIO_ACTIVE_HIGH>;
+                       linux,code = <ASPEED_GPIO(C, 3)>;
+               };
+
+               PCB_REV_ID1 {
+                       label = "PCB_REV_ID1";
+                       gpios = <&gpio ASPEED_GPIO(C, 4) GPIO_ACTIVE_HIGH>;
+                       linux,code = <ASPEED_GPIO(C, 4)>;
+               };
+
+               PCB_REV_ID2 {
+                       label = "PCB_REV_ID2";
+                       gpios = <&gpio ASPEED_GPIO(C, 5) GPIO_ACTIVE_HIGH>;
+                       linux,code = <ASPEED_GPIO(C, 5)>;
+               };
+
+               NC_BMC_GPIOC6 {
+                       label = "NC_BMC_GPIOC6";
+                       gpios = <&gpio ASPEED_GPIO(C, 6) GPIO_ACTIVE_HIGH>;
+                       linux,code = <ASPEED_GPIO(C, 6)>;
+               };
+
+               NC_BMC_GPIOC7 {
+                       label = "NC_BMC_GPIOC7";
+                       gpios = <&gpio ASPEED_GPIO(C, 7) GPIO_ACTIVE_HIGH>;
+                       linux,code = <ASPEED_GPIO(C, 7)>;
+               };
+               // D0-D7
+               FM_FORCE_BMC_UPDATE_N {
+                       label = "FM_FORCE_BMC_UPDATE_N";
+                       gpios = <&gpio ASPEED_GPIO(D, 0) GPIO_ACTIVE_LOW>;
+                       linux,code = <ASPEED_GPIO(D, 0)>;
+               };
+
+               RST_RSTB_BMC_R_N {
+                       label = "RST_RSTB_BMC_R_N";
+                       gpios = <&gpio ASPEED_GPIO(D, 1) GPIO_ACTIVE_LOW>;
+                       linux,code = <ASPEED_GPIO(D, 1)>;
+               };
+
+               NC_BMC_GPIOD2 {
+                       label = "NC_BMC_GPIOD2";
+                       gpios = <&gpio ASPEED_GPIO(D, 2) GPIO_ACTIVE_HIGH>;
+                       linux,code = <ASPEED_GPIO(D, 2)>;
+               };
+
+               NC_BMC_GPIOD3 {
+                       label = "NC_BMC_GPIOD3";
+                       gpios = <&gpio ASPEED_GPIO(D, 3) GPIO_ACTIVE_HIGH>;
+                       linux,code = <ASPEED_GPIO(D, 3)>;
+               };
+
+               NC_BMC_GPIOD4 {
+                       label = "NC_BMC_GPIOD4";
+                       gpios = <&gpio ASPEED_GPIO(D, 4) GPIO_ACTIVE_HIGH>;
+                       linux,code = <ASPEED_GPIO(D, 4)>;
+               };
+
+               NC_BMC_GPIOD5 {
+                       label = "NC_BMC_GPIOD5";
+                       gpios = <&gpio ASPEED_GPIO(D, 5) GPIO_ACTIVE_HIGH>;
+                       linux,code = <ASPEED_GPIO(D, 5)>;
+               };
+       };
+

arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts line 299

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +10 -0
+};
+
+
+&gpio {
+       // A0-A7
+       fm_spd_ddrcpu_lvlshft_en_r {
+               gpio-hog;
+               label = "FM_SPD_DDRCPU_LVLSHFT_EN_R";
+               gpios = <ASPEED_GPIO(A, 1) GPIO_ACTIVE_HIGH>;
+               linux,code = <ASPEED_GPIO(A, 1)>;

I do not think the input code makes any sense for a hog.

Quoted 117 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +117 -0
+               output-high;
+       };
+
+       mb_bmc_hbsp_reset_n {
+               gpio-hog;
+               label = "MB_BMC_HBSP_RESET_N";
+               gpios = <ASPEED_GPIO(A, 2) GPIO_ACTIVE_LOW>;
+               linux,code = <ASPEED_GPIO(A, 2)>;
+               output-high;
+       };
+
+       mb_bmc_hbsp_isp_n {
+               gpio-hog;
+               label = "MB_BMC_HBSP_ISP_N";
+               gpios = <ASPEED_GPIO(A, 3) GPIO_ACTIVE_LOW>;
+               linux,code = <ASPEED_GPIO(A, 3)>;
+               output-high;
+       };
+       // D0-D7
+       jtag_pld_en {
+               gpio-hog;
+               label = "JTAG_PLD_EN";
+               gpios = <ASPEED_GPIO(D, 6) GPIO_ACTIVE_HIGH>;
+               linux,code = <ASPEED_GPIO(D, 6)>;
+               output-low;
+       };
+       FM_BMC_DBP_PRESENT_R_N {
+               gpio-hog;
+               label = "FM_BMC_DBP_PRESENT_R_N";
+               gpios = <ASPEED_GPIO(E, 5) GPIO_ACTIVE_LOW>;
+               linux,code = <ASPEED_GPIO(E, 5)>;
+               output-high;
+       };
+
+       // F0-F7
+       IRQ_BMC_PCH_NMI_R {
+               gpio-hog;
+               label = "IRQ_BMC_PCH_NMI_R";
+               gpios = <ASPEED_GPIO(F, 0) GPIO_ACTIVE_HIGH>;
+               linux,code = <ASPEED_GPIO(F, 0)>;
+               output-low;
+       };
+
+       FM_CPU2_DISABLE_COD_N {
+               gpio-hog;
+               label = "FM_CPU2_DISABLE_COD_N";
+               gpios = <ASPEED_GPIO(F, 1) GPIO_ACTIVE_LOW>;
+               linux,code = <ASPEED_GPIO(F, 1)>;
+               output-high;
+       };
+
+       SPI_SYSBIOS_BMC_SEL {
+               gpio-hog;
+               label = "SPI_SYSBIOS_BMC_SEL";
+               gpios = <ASPEED_GPIO(F, 2) GPIO_ACTIVE_LOW>;
+               linux,code = <ASPEED_GPIO(F, 2)>;
+               output-high;
+       };
+       // Q0-Q7
+       FM_BMC_CPU_PWR_DEBUG_R_N {
+               gpio-hog;
+               label = "FM_BMC_CPU_PWR_DEBUG_R_N";
+               gpios = <ASPEED_GPIO(Q, 7) GPIO_ACTIVE_LOW>;
+               linux,code = <ASPEED_GPIO(Q, 7)>;
+               output-high;
+       };
+};
+
+
+&fmc {
+       status = "okay";
+       flash@0 {
+               status = "okay";
+               m25p,fast-read;
+               label = "bmc";
+               spi-max-frequency = <50000000>;
+#include "openbmc-flash-layout.dtsi"
+       };
+};
+
+&spi1 {
+       status = "okay";
+       flash@0 {
+               status = "okay";
+               m25p,fast-read;
+               label = "pnor";
+               spi-max-frequency = <100000000>;
+       };
+};
+
+&spi2 {
+       status = "okay";
+};
+
+&uart5 {
+       status = "okay";
+};
+
+&mac0 {
+       status = "okay";
+
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_rgmii1_default &pinctrl_mdio1_default>;
+};
+
+&mac1 {
+       status = "okay";
+
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>;
+};
+
+&adc {
+       status = "okay";
+};
+
+&i2c0 {

arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts line 426

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +10 -0
+       status = "okay";
+};
+
+&i2c1 {
+       status = "okay";
+
+       eeprom@54 {
+        compatible = "atmel,24c64";
+        reg = <0x54>;
+        pagesize = <32>;

The whitespace seems off here.

Quoted 101 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +101 -0
+    };
+};
+
+&i2c2 {
+       status = "okay";
+};
+
+&i2c3 {
+       status = "okay";
+
+       tmp75@48 {
+               compatible = "ti,tmp75";
+               reg = <0x48>;
+       };
+
+       tmp75@4b {
+               compatible = "ti,tmp75";
+               reg = <0x4b>;
+       };
+
+       tmp75@4c {
+               compatible = "ti,tmp75";
+               reg = <0x4c>;
+       };
+
+       tmp75@4d {
+               compatible = "ti,tmp75";
+               reg = <0x4d>;
+       };
+
+       vr-controller@5a {
+               compatible = "ti,tps53679";
+               reg = <0x5a>;
+       };
+
+       vr-controller@5d {
+               compatible = "ti,tps53679";
+               reg = <0x5d>;
+       };
+
+       vr-controller@68 {
+               compatible = "ti,tps53679";
+               reg = <0x68>;
+       };
+
+       vr-controller@6a {
+               compatible = "ti,tps53679";
+               reg = <0x6a>;
+       };
+
+       vr-controller@6c {
+               compatible = "ti,tps53679";
+               reg = <0x6c>;
+       };
+
+       vr-controller@6e {
+               compatible = "ti,tps53679";
+               reg = <0x6e>;
+       };
+
+};
+
+&i2c4 {
+       status = "okay";
+
+       eeprom@51 {
+        compatible = "atmel,24c64";
+        reg = <0x51>;
+        pagesize = <32>;
+    };
+};
+
+&i2c5 {
+       status = "okay";
+};
+
+&i2c6 {
+       status = "okay";
+};
+
+&i2c7 {
+       status = "okay";
+
+       power-supply@58 {
+               compatible = "pmbus";
+               reg = <0x58>;
+       };
+
+       power-supply@59 {
+               compatible = "pmbus";
+               reg = <0x59>;
+       };
+};
+
+
+&sdmmc {
+       status = "okay";
+};
+
+&sdhci0 {
+       status = "okay";

arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts line 537

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +10 -0
+
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_sd1_default>;
+};
+
+/*
+ * Enable port A as device (via the virtual hub) and port B as
+ * host by default on the eval board. This can be easily changed
+ * by replacing the override below with &ehci0 { ... } to enable
+ * host on both ports.

This comment is for the eval board, you should remove it.

Quoted 6 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +6 -0
+ */
+&vhub {
+       status = "okay";
+};
+
+&ehci1 {

arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts line 553

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +10 -0
+       status = "okay";
+};
+
+&uhci {
+       status = "okay";
+};
+
+&gfx {
+     status = "okay";
+     memory-region = <&gfx_memory>;

See my comment about the display device above. You probably don't need this node.

Quoted 55 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +52 -1
+};
+
+&pwm_tacho {
+       status = "okay";
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default
+               &pinctrl_pwm2_default &pinctrl_pwm3_default
+               &pinctrl_pwm4_default &pinctrl_pwm5_default
+               &pinctrl_pwm6_default &pinctrl_pwm7_default>;
+
+       fan@0 {
+               reg = <0x00>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x00 0x01>;
+       };
+
+       fan@1 {
+               reg = <0x01>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x02 0x03>;
+       };
+
+       fan@2 {
+               reg = <0x02>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x04 0x05>;
+       };
+
+       fan@3 {
+               reg = <0x03>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x06 0x07>;
+       };
+
+       fan@4 {
+               reg = <0x04>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x08 0x09>;
+       };
+
+       fan@5 {
+               reg = <0x05>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x0a 0x0b>;
+       };
+
+       fan@6 {
+               reg = <0x06>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x0c 0x0d>;
+       };
+
+       fan@7 {
+               reg = <0x07>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x0e 0x0f>;
+       };
+
+};
+
--

2.7.4

#2 lore raw

PATCH 1/1 ARM: dts: aspeed: Add device tree for Liwu2 BMC

The Liwu2 is a server platform with an ASPEED AST2500 based BMC.

---
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts | 320 ++++++++++++++++++++++++++
 2 files changed, 321 insertions(+)
 create mode 100755 arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts
arch/arm/boot/dts/Makefile +1 -0
index 5a14adc..16fc64d 100644
@@ -1354,6 +1354,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-arm-centriq2400-rep.dtb \
 	aspeed-bmc-arm-stardragon4800-rep2.dtb \
 	aspeed-bmc-bytedance-g220a.dtb \
+	aspeed-bmc-compal-liwu2.dts \
 	aspeed-bmc-facebook-cmm.dtb \
 	aspeed-bmc-facebook-minipack.dtb \
 	aspeed-bmc-facebook-tiogapass.dtb \
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +320 -0

320 lines not on this page · raw message

Signature · 1 line
2.7.4
maintainer
#3 lore raw
Quoted 2 lines · Willie Thai

The Liwu2 is a server platform with an ASPEED AST2500 based BMC.

You need to have a signed-off-by in your commit message.

Please make sure you run ./scripts/checkpatch.pl on your patch before sending it.

The patch looks okay; there are some minor issues to fix that I have mentioned below. Apologies for the delay in reviewing it.

Quoted 62 lines
---
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts | 320 ++++++++++++++++++++++++++
 2 files changed, 321 insertions(+)
 create mode 100755 arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts
arch/arm/boot/dts/Makefile +1 -0
index 5a14adc..16fc64d 100644
@@ -1354,6 +1354,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
        aspeed-bmc-arm-centriq2400-rep.dtb \
        aspeed-bmc-arm-stardragon4800-rep2.dtb \
        aspeed-bmc-bytedance-g220a.dtb \
+       aspeed-bmc-compal-liwu2.dts \
        aspeed-bmc-facebook-cmm.dtb \
        aspeed-bmc-facebook-minipack.dtb \
        aspeed-bmc-facebook-tiogapass.dtb \
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +38 -0
new file mode 100755
index 0000000..a93af32
@@ -0,0 +1,320 @@
+// SPDX-License-Identifier: GPL-2.0+
+/dts-v1/;
+
+#include "aspeed-g5.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>
+
+/ {
+       model = "AST2500 liwu2";
+       compatible = "aspeed,ast2500";
+
+       aliases {
+               serial4 = &uart5;
+       };
+
+       chosen {
+               stdout-path = &uart5;
+               bootargs = "console=tty0 console=ttyS4,115200 earlyprintk";
+       };
+
+       memory@80000000 {
+               reg = <0x80000000 0x20000000>;
+       };
+
+       reserved-memory {
+               #address-cells = <1>;
+               #size-cells = <1>;
+               ranges;
+
+               gfx_memory: framebuffer {
+                       size = <0x01000000>;
+                       alignment = <0x01000000>;
+                       compatible = "shared-dma-pool";
+                       reusable;
+               };
+       };
+
+       iio-hwmon {
+               compatible = "iio-hwmon";

arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts line 48

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +10 -0
+               io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>,
+                             <&adc 4>, <&adc 5>, <&adc 6>, <&adc 7>,
+                             <&adc 8>, <&adc 9>, <&adc 10>, <&adc 11>,
+                             <&adc 12>, <&adc 13>, <&adc 14>, <&adc 15>;
+       };
+
+       leds {
+               compatible = "gpio-leds";
+
+               LED_FAN0_FAULT {

Node names have lower case.

Quoted 156 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +156 -0
+                       label = "LED_FAN0_FAULT";
+                       gpios = <&gpio ASPEED_GPIO(F, 4) GPIO_ACTIVE_LOW>;
+               };
+
+               LED_FAN1_FAULT {
+                       label = "LED_FAN1_FAULT";
+                       gpios = <&gpio ASPEED_GPIO(F, 5) GPIO_ACTIVE_LOW>;
+               };
+
+               LED_FAN2_FAULT {
+                       label = "LED_FAN2_FAULT";
+                       gpios = <&gpio ASPEED_GPIO(H, 2) GPIO_ACTIVE_LOW>;
+               };
+
+               LED_FAN3_FAULT {
+                       label = "LED_FAN3_FAULT";
+                       gpios = <&gpio ASPEED_GPIO(H, 5) GPIO_ACTIVE_LOW>;
+               };
+
+               LED_FAN4_FAULT {
+                       label = "LED_FAN4_FAULT";
+                       gpios = <&gpio ASPEED_GPIO(H, 6) GPIO_ACTIVE_LOW>;
+               };
+
+               LED_FAN5_FAULT {
+                       label = "LED_FAN5_FAULT";
+                       gpios = <&gpio ASPEED_GPIO(H, 7) GPIO_ACTIVE_LOW>;
+               };
+
+               FP_LED_STATUS_AMBER_N {
+                       label = "FP_LED_STATUS_AMBER_N";
+                       gpios = <&gpio ASPEED_GPIO(S, 5) GPIO_ACTIVE_LOW>;
+               };
+
+               REAR_ID_LED_N {
+                       label = "REAR_ID_LED_N";
+                       gpios = <&gpio ASPEED_GPIO(S, 6) GPIO_ACTIVE_LOW>;
+               };
+       };
+};
+
+&fmc {
+       status = "okay";
+       flash@0 {
+               status = "okay";
+               m25p,fast-read;
+               label = "bmc";
+               spi-max-frequency = <50000000>;
+#include "openbmc-flash-layout.dtsi"
+       };
+};
+
+&spi1 {
+       status = "okay";
+       flash@0 {
+               status = "okay";
+               m25p,fast-read;
+               label = "pnor";
+               spi-max-frequency = <100000000>;
+       };
+};
+
+&spi2 {
+       status = "okay";
+};
+
+&uart5 {
+       status = "okay";
+};
+
+&mac0 {
+       status = "okay";
+
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_rgmii1_default &pinctrl_mdio1_default>;
+};
+
+&mac1 {
+       status = "okay";
+
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>;
+};
+
+&adc {
+       status = "okay";
+};
+
+&i2c0 {
+       status = "okay";
+};
+
+&i2c1 {
+       status = "okay";
+
+       eeprom@54 {
+               compatible = "atmel,24c64";
+               reg = <0x54>;
+               pagesize = <32>;
+       };
+};
+
+&i2c2 {
+       status = "okay";
+};
+
+&i2c3 {
+       status = "okay";
+
+       tmp75@48 {
+               compatible = "ti,tmp75";
+               reg = <0x48>;
+       };
+
+       tmp75@4b {
+               compatible = "ti,tmp75";
+               reg = <0x4b>;
+       };
+
+       tmp75@4c {
+               compatible = "ti,tmp75";
+               reg = <0x4c>;
+       };
+
+       tmp75@4d {
+               compatible = "ti,tmp75";
+               reg = <0x4d>;
+       };
+
+       vr-controller@5a {
+               compatible = "ti,tps53679";
+               reg = <0x5a>;
+       };
+
+       vr-controller@5d {
+               compatible = "ti,tps53679";
+               reg = <0x5d>;
+       };
+
+       vr-controller@68 {
+               compatible = "ti,tps53679";
+               reg = <0x68>;
+       };
+
+       vr-controller@6a {
+               compatible = "ti,tps53679";
+               reg = <0x6a>;
+       };
+
+       vr-controller@6c {
+               compatible = "ti,tps53679";
+               reg = <0x6c>;
+       };
+
+       vr-controller@6e {
+               compatible = "ti,tps53679";

arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts line 214

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +10 -0
+               reg = <0x6e>;
+       };
+
+};
+
+&i2c4 {
+       status = "okay";
+
+       eeprom@51 {
+        compatible = "atmel,24c64";

The whitespace looks wrong here.

Quoted 109 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +106 -1
+        reg = <0x51>;
+        pagesize = <32>;
+    };
+};
+
+&i2c5 {
+       status = "okay";
+};
+
+&i2c6 {
+       status = "okay";
+};
+
+&i2c7 {
+       status = "okay";
+
+       power-supply@58 {
+               compatible = "pmbus";
+               reg = <0x58>;
+       };
+
+       power-supply@59 {
+               compatible = "pmbus";
+               reg = <0x59>;
+       };
+};
+
+
+&sdmmc {
+       status = "okay";
+};
+
+&sdhci0 {
+       status = "okay";
+
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_sd1_default>;
+};
+
+&vhub {
+       status = "okay";
+};
+
+&ehci1 {
+       status = "okay";
+};
+
+&uhci {
+       status = "okay";
+};
+
+&gfx {
+     status = "okay";
+     memory-region = <&gfx_memory>;
+};
+
+&pwm_tacho {
+       status = "okay";
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default
+               &pinctrl_pwm2_default &pinctrl_pwm3_default
+               &pinctrl_pwm4_default &pinctrl_pwm5_default
+               &pinctrl_pwm6_default &pinctrl_pwm7_default>;
+
+       fan@0 {
+               reg = <0x00>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x00 0x01>;
+       };
+
+       fan@1 {
+               reg = <0x01>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x02 0x03>;
+       };
+
+       fan@2 {
+               reg = <0x02>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x04 0x05>;
+       };
+
+       fan@3 {
+               reg = <0x03>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x06 0x07>;
+       };
+
+       fan@4 {
+               reg = <0x04>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x08 0x09>;
+       };
+
+       fan@5 {
+               reg = <0x05>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x0a 0x0b>;
+       };
+
+       fan@6 {
+               reg = <0x06>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x0c 0x0d>;
+       };
+
+       fan@7 {
+               reg = <0x07>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x0e 0x0f>;
+       };
+
+};
+
--

2.7.4

#4 lore raw

PATCH 1/1 ARM: dts: Aspeed: Add Compal's Liwu2 BMC machine] ARM: dts: aspeed: Add device tree for Compal's Liwu2 BMC

The Liwu2 is a server platform with an ASPEED AST2500 based BMC.

---
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts | 325 ++++++++++++++++++++++++++
 2 files changed, 326 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts
arch/arm/boot/dts/Makefile +1 -0
index 6320124..a67576d 100644
@@ -1354,6 +1354,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-arm-centriq2400-rep.dtb \
 	aspeed-bmc-arm-stardragon4800-rep2.dtb \
 	aspeed-bmc-bytedance-g220a.dtb \
+	aspeed-bmc-compal-liwu2.dtb \
 	aspeed-bmc-facebook-cmm.dtb \
 	aspeed-bmc-facebook-minipack.dtb \
 	aspeed-bmc-facebook-tiogapass.dtb \
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +325 -0

325 lines not on this page · raw message

Signature · 1 line
2.7.4
maintainer
#5 lore raw

Re: [[PATCH linux dev-5.8] ARM: dts: Aspeed: Add Compal's Liwu2 BMC machine] ARM: dts: aspeed: Add device tree for Compal's Liwu2 BMC

Quoted 5 lines · Willie Thai

The Liwu2 is a server platform with an ASPEED AST2500 based BMC.

I do not recall adding reviewed-by tags. Please don't add them unless a reviewer has sent them.

Quoted 1 line
Signed-off-by [email protected]

The format is: Signed-off-by: User Name <[email protected]>

You can use '-s' when running git commit to add it automatically.

Quoted 24 lines
---
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts | 325 ++++++++++++++++++++++++++
 2 files changed, 326 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts
arch/arm/boot/dts/Makefile +1 -0
index 6320124..a67576d 100644
@@ -1354,6 +1354,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
        aspeed-bmc-arm-centriq2400-rep.dtb \
        aspeed-bmc-arm-stardragon4800-rep2.dtb \
        aspeed-bmc-bytedance-g220a.dtb \
+       aspeed-bmc-compal-liwu2.dtb \
        aspeed-bmc-facebook-cmm.dtb \
        aspeed-bmc-facebook-minipack.dtb \
        aspeed-bmc-facebook-tiogapass.dtb \
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +0 -0
new file mode 100644
index 0000000..68faf3d

arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts line 9

Quoted 9 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +9 -0
@@ -0,0 +1,325 @@
+// SPDX-License-Identifier: GPL-2.0+
+/dts-v1/;
+
+#include "aspeed-g5.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>
+
+/ {
+       model = "AST2500 liwu2";
+       compatible = "aspeed,ast2500";

Add a compatible string for your machine, eg.

compatible = "compal,liwu2-bmc", "aspeed,ast2500";'

Quoted 239 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +239 -0
+
+       aliases {
+               serial4 = &uart5;
+       };
+
+       chosen {
+               stdout-path = &uart5;
+               bootargs = "console=tty0 console=ttyS4,115200 earlyprintk";
+       };
+
+       memory@80000000 {
+               reg = <0x80000000 0x20000000>;
+       };
+
+       reserved-memory {
+               #address-cells = <1>;
+               #size-cells = <1>;
+               ranges;
+
+               gfx_memory: framebuffer {
+                       size = <0x01000000>;
+                       alignment = <0x01000000>;
+                       compatible = "shared-dma-pool";
+                       reusable;
+               };
+       };
+
+       iio-hwmon {
+               compatible = "iio-hwmon";
+               io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>,
+                               <&adc 4>, <&adc 5>, <&adc 6>, <&adc 7>,
+                               <&adc 8>, <&adc 9>, <&adc 10>, <&adc 11>,
+                               <&adc 12>, <&adc 13>, <&adc 14>, <&adc 15>;
+       };
+
+       leds {
+               compatible = "gpio-leds";
+
+               led_fan0_fault {
+                       label = "LED_FAN0_FAULT";
+                       gpios = <&gpio ASPEED_GPIO(F, 4) GPIO_ACTIVE_LOW>;
+               };
+
+               led_fan1_fault {
+                       label = "LED_FAN1_FAULT";
+                       gpios = <&gpio ASPEED_GPIO(F, 5) GPIO_ACTIVE_LOW>;
+               };
+
+               led_fan2_fault {
+                       label = "LED_FAN2_FAULT";
+                       gpios = <&gpio ASPEED_GPIO(H, 2) GPIO_ACTIVE_LOW>;
+               };
+
+               led_fan3_fault {
+                       label = "LED_FAN3_FAULT";
+                       gpios = <&gpio ASPEED_GPIO(H, 5) GPIO_ACTIVE_LOW>;
+               };
+
+               led_fan4_fault {
+                       label = "LED_FAN4_FAULT";
+                       gpios = <&gpio ASPEED_GPIO(H, 6) GPIO_ACTIVE_LOW>;
+               };
+
+               led_fan5_fault {
+                       label = "LED_FAN5_FAULT";
+                       gpios = <&gpio ASPEED_GPIO(H, 7) GPIO_ACTIVE_LOW>;
+               };
+
+               fp_led_status_amber_n {
+                       label = "FP_LED_STATUS_AMBER_N";
+                       gpios = <&gpio ASPEED_GPIO(S, 5) GPIO_ACTIVE_LOW>;
+               };
+
+               rear_id_led_n {
+                       label = "REAR_ID_LED_N";
+                       gpios = <&gpio ASPEED_GPIO(S, 6) GPIO_ACTIVE_LOW>;
+               };
+       };
+};
+
+&fmc {
+       status = "okay";
+       flash@0 {
+               status = "okay";
+               m25p,fast-read;
+               label = "bmc";
+               spi-max-frequency = <50000000>;
+#include "openbmc-flash-layout.dtsi"
+       };
+};
+
+&spi1 {
+       status = "okay";
+       flash@0 {
+               status = "okay";
+               m25p,fast-read;
+               label = "pnor";
+               spi-max-frequency = <100000000>;
+       };
+};
+
+&spi2 {
+       status = "okay";
+};
+
+&uart5 {
+       status = "okay";
+};
+
+&mac0 {
+       status = "okay";
+
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_rgmii1_default &pinctrl_mdio1_default>;
+};
+
+&mac1 {
+       status = "okay";
+
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>;
+};
+
+&adc {
+       status = "okay";
+};
+
+&i2c0 {
+       status = "okay";
+};
+
+&i2c1 {
+       status = "okay";
+
+       eeprom@54 {
+               compatible = "atmel,24c64";
+               reg = <0x54>;
+               pagesize = <32>;
+       };
+};
+
+&i2c2 {
+       status = "okay";
+};
+
+&i2c3 {
+       status = "okay";
+
+       tmp75@48 {
+               compatible = "ti,tmp75";
+               reg = <0x48>;
+       };
+
+       tmp75@4b {
+               compatible = "ti,tmp75";
+               reg = <0x4b>;
+       };
+
+       tmp75@4c {
+               compatible = "ti,tmp75";
+               reg = <0x4c>;
+       };
+
+       tmp75@4d {
+               compatible = "ti,tmp75";
+               reg = <0x4d>;
+       };
+
+       vr-controller@5a {
+               compatible = "ti,tps53679";
+               reg = <0x5a>;
+       };
+
+       vr-controller@5d {
+               compatible = "ti,tps53679";
+               reg = <0x5d>;
+       };
+
+       vr-controller@68 {
+               compatible = "ti,tps53679";
+               reg = <0x68>;
+       };
+
+       vr-controller@6a {
+               compatible = "ti,tps53679";
+               reg = <0x6a>;
+       };
+
+       vr-controller@6c {
+               compatible = "ti,tps53679";
+               reg = <0x6c>;
+       };
+
+       vr-controller@6e {
+               compatible = "ti,tps53679";
+               reg = <0x6e>;
+       };
+
+};
+
+&i2c4 {
+       status = "okay";
+
+       eeprom@51 {
+               compatible = "atmel,24c64";
+               reg = <0x51>;
+               pagesize = <32>;
+       };
+};
+
+&i2c5 {
+       status = "okay";
+};
+
+&i2c6 {
+       status = "okay";
+};
+
+&i2c7 {
+       status = "okay";
+
+       power-supply@58 {
+               compatible = "pmbus";
+               reg = <0x58>;
+       };
+
+       power-supply@59 {
+               compatible = "pmbus";
+               reg = <0x59>;
+       };
+};
+
+
+&sdmmc {
+       status = "okay";
+};
+
+&sdhci0 {
+       status = "okay";

arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts line 258

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +10 -0
+
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_sd1_default>;
+};
+
+/*
+ * Enable port A as device (via the virtual hub) and port B as
+ * host by default on the eval board. This can be easily changed
+ * by replacing the override below with &ehci0 { ... } to enable
+ * host on both ports.

This looks like it's cut and pasted from the EVB. Please update or remove the comment as it applies to your machine.

Quoted 70 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +67 -1
+ */
+&vhub {
+       status = "okay";
+};
+
+&ehci1 {
+       status = "okay";
+};
+
+&uhci {
+       status = "okay";
+};
+
+&gfx {
+       status = "okay";
+       memory-region = <&gfx_memory>;
+};
+
+&pwm_tacho {
+       status = "okay";
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default
+               &pinctrl_pwm2_default &pinctrl_pwm3_default
+               &pinctrl_pwm4_default &pinctrl_pwm5_default
+               &pinctrl_pwm6_default &pinctrl_pwm7_default>;
+
+       fan@0 {
+               reg = <0x00>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x00 0x01>;
+       };
+
+       fan@1 {
+               reg = <0x01>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x02 0x03>;
+       };
+
+       fan@2 {
+               reg = <0x02>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x04 0x05>;
+       };
+
+       fan@3 {
+               reg = <0x03>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x06 0x07>;
+       };
+
+       fan@4 {
+               reg = <0x04>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x08 0x09>;
+       };
+
+       fan@5 {
+               reg = <0x05>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x0a 0x0b>;
+       };
+
+       fan@6 {
+               reg = <0x06>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x0c 0x0d>;
+       };
+
+       fan@7 {
+               reg = <0x07>;
+               aspeed,fan-tach-ch = /bits/ 8 <0x0e 0x0f>;
+       };
+
+};
--

2.7.4

#6 lore raw

Re: [[PATCH linux dev-5.8] ARM: dts: Aspeed: Add Compal's Liwu2 BMC machine] ARM: dts: aspeed: Add device tree for Compal's Liwu2 BMC

In reply to Willie Thai
Quoted 3 lines · Willie Thai

The Liwu2 is a server platform with an ASPEED AST2500 based BMC.

I don't recall providing my r-b tag.

I have comments below.

Quoted 119 lines
---
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts | 325 ++++++++++++++++++++++++++
 2 files changed, 326 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts
arch/arm/boot/dts/Makefile +1 -0
index 6320124..a67576d 100644
@@ -1354,6 +1354,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-arm-centriq2400-rep.dtb \
 	aspeed-bmc-arm-stardragon4800-rep2.dtb \
 	aspeed-bmc-bytedance-g220a.dtb \
+	aspeed-bmc-compal-liwu2.dtb \
 	aspeed-bmc-facebook-cmm.dtb \
 	aspeed-bmc-facebook-minipack.dtb \
 	aspeed-bmc-facebook-tiogapass.dtb \
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +92 -0
new file mode 100644
index 0000000..68faf3d
@@ -0,0 +1,325 @@
+// SPDX-License-Identifier: GPL-2.0+
+/dts-v1/;
+
+#include "aspeed-g5.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>
+
+/ {
+	model = "AST2500 liwu2";
+	compatible = "aspeed,ast2500";
+
+	aliases {
+		serial4 = &uart5;
+	};
+
+	chosen {
+		stdout-path = &uart5;
+		bootargs = "console=tty0 console=ttyS4,115200 earlyprintk";
+	};
+
+	memory@80000000 {
+		reg = <0x80000000 0x20000000>;
+	};
+
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		gfx_memory: framebuffer {
+			size = <0x01000000>;
+			alignment = <0x01000000>;
+			compatible = "shared-dma-pool";
+			reusable;
+		};
+	};
+
+	iio-hwmon {
+		compatible = "iio-hwmon";
+		io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>,
+				<&adc 4>, <&adc 5>, <&adc 6>, <&adc 7>,
+				<&adc 8>, <&adc 9>, <&adc 10>, <&adc 11>,
+				<&adc 12>, <&adc 13>, <&adc 14>, <&adc 15>;
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		led_fan0_fault {
+			label = "LED_FAN0_FAULT";
+			gpios = <&gpio ASPEED_GPIO(F, 4) GPIO_ACTIVE_LOW>;
+		};
+
+		led_fan1_fault {
+			label = "LED_FAN1_FAULT";
+			gpios = <&gpio ASPEED_GPIO(F, 5) GPIO_ACTIVE_LOW>;
+		};
+
+		led_fan2_fault {
+			label = "LED_FAN2_FAULT";
+			gpios = <&gpio ASPEED_GPIO(H, 2) GPIO_ACTIVE_LOW>;
+		};
+
+		led_fan3_fault {
+			label = "LED_FAN3_FAULT";
+			gpios = <&gpio ASPEED_GPIO(H, 5) GPIO_ACTIVE_LOW>;
+		};
+
+		led_fan4_fault {
+			label = "LED_FAN4_FAULT";
+			gpios = <&gpio ASPEED_GPIO(H, 6) GPIO_ACTIVE_LOW>;
+		};
+
+		led_fan5_fault {
+			label = "LED_FAN5_FAULT";
+			gpios = <&gpio ASPEED_GPIO(H, 7) GPIO_ACTIVE_LOW>;
+		};
+
+		fp_led_status_amber_n {
+			label = "FP_LED_STATUS_AMBER_N";
+			gpios = <&gpio ASPEED_GPIO(S, 5) GPIO_ACTIVE_LOW>;
+		};
+
+		rear_id_led_n {
+			label = "REAR_ID_LED_N";
+			gpios = <&gpio ASPEED_GPIO(S, 6) GPIO_ACTIVE_LOW>;
+		};
+	};
+};
+
+&fmc {
+	status = "okay";
+	flash@0 {

arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts line 102

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +10 -0
+		status = "okay";
+		m25p,fast-read;
+		label = "bmc";
+		spi-max-frequency = <50000000>;
+#include "openbmc-flash-layout.dtsi"
+	};
+};
+
+&spi1 {
+	status = "okay";

Should have at least:

pinctrl-names = "default";
pinctrl-0 = <&pinctrl_spi1_default>;

And then if you need additional chip selects, you should add them too.

arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts line 112

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +10 -0
+	flash@0 {
+		status = "okay";
+		m25p,fast-read;
+		label = "pnor";
+		spi-max-frequency = <100000000>;
+	};
+};
+
+&spi2 {
+	status = "okay";

Is this necessary given no flash device is defined?

If it is, you also need pinctrl properties.

Quoted 12 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +12 -0
+};
+
+&uart5 {
+	status = "okay";
+};
+
+&mac0 {
+	status = "okay";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rgmii1_default &pinctrl_mdio1_default>;
+};

arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts line 134

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +10 -0
+
+&mac1 {
+	status = "okay";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>;
+};
+
+&adc {
+	status = "okay";

Given you're using the ADC lines in the iio-hwmon bridge, you need to request the ADC pins from pinmux here. ADC is the default mux configuration for the pins, so this will happen to work as is, but pinmux will not prevent something else from requesting the pins out from underneath the ADC.

Andrew

#7 lore raw

RE: [External Mail] Re:_[[PATCH_linux_dev-5.8]_ARM:_dts:_Aspeed:_Add_Compal's_Liwu2_BMC_machine]__ARM:_dts:_aspeed:_Add_device_tree_for_Compal's_Liwu2_BMC

Thanks Andrew and Joel,

Our Liwu2 project has stopped, so I will not try committing it any more.

Thank you very much !
-----Original Message-----
From: Andrew Jeffery [mailto:[email protected]]
Sent: Thursday, April 1, 2021 8:32 AM
To: Willie Thai; Joel Stanley; [email protected]
Cc: Thai. Willie (TPE)
Subject: [External Mail] Re:_[[PATCH_linux_dev-5.8]_ARM:_dts:_Aspeed:_Add_Compal's_Liwu2_BMC_machine]__ARM:_dts:_aspeed:_Add_device_tree_for_Compal's_Liwu2_BMC

Quoted 3 lines · Willie Thai

The Liwu2 is a server platform with an ASPEED AST2500 based BMC.

I don't recall providing my r-b tag.

I have comments below.

Quoted 5 lines
---
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts | 325

++++++++++++++++++++++++++

Quoted 114 lines
 2 files changed, 326 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts
arch/arm/boot/dts/Makefile +1 -0
index 6320124..a67576d 100644
@@ -1354,6 +1354,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-arm-centriq2400-rep.dtb \
 	aspeed-bmc-arm-stardragon4800-rep2.dtb \
 	aspeed-bmc-bytedance-g220a.dtb \
+	aspeed-bmc-compal-liwu2.dtb \
 	aspeed-bmc-facebook-cmm.dtb \
 	aspeed-bmc-facebook-minipack.dtb \
 	aspeed-bmc-facebook-tiogapass.dtb \
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +92 -0
new file mode 100644
index 0000000..68faf3d
@@ -0,0 +1,325 @@
+// SPDX-License-Identifier: GPL-2.0+
+/dts-v1/;
+
+#include "aspeed-g5.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>
+
+/ {
+	model = "AST2500 liwu2";
+	compatible = "aspeed,ast2500";
+
+	aliases {
+		serial4 = &uart5;
+	};
+
+	chosen {
+		stdout-path = &uart5;
+		bootargs = "console=tty0 console=ttyS4,115200 earlyprintk";
+	};
+
+	memory@80000000 {
+		reg = <0x80000000 0x20000000>;
+	};
+
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		gfx_memory: framebuffer {
+			size = <0x01000000>;
+			alignment = <0x01000000>;
+			compatible = "shared-dma-pool";
+			reusable;
+		};
+	};
+
+	iio-hwmon {
+		compatible = "iio-hwmon";
+		io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>,
+				<&adc 4>, <&adc 5>, <&adc 6>, <&adc 7>,
+				<&adc 8>, <&adc 9>, <&adc 10>, <&adc 11>,
+				<&adc 12>, <&adc 13>, <&adc 14>, <&adc 15>;
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		led_fan0_fault {
+			label = "LED_FAN0_FAULT";
+			gpios = <&gpio ASPEED_GPIO(F, 4) GPIO_ACTIVE_LOW>;
+		};
+
+		led_fan1_fault {
+			label = "LED_FAN1_FAULT";
+			gpios = <&gpio ASPEED_GPIO(F, 5) GPIO_ACTIVE_LOW>;
+		};
+
+		led_fan2_fault {
+			label = "LED_FAN2_FAULT";
+			gpios = <&gpio ASPEED_GPIO(H, 2) GPIO_ACTIVE_LOW>;
+		};
+
+		led_fan3_fault {
+			label = "LED_FAN3_FAULT";
+			gpios = <&gpio ASPEED_GPIO(H, 5) GPIO_ACTIVE_LOW>;
+		};
+
+		led_fan4_fault {
+			label = "LED_FAN4_FAULT";
+			gpios = <&gpio ASPEED_GPIO(H, 6) GPIO_ACTIVE_LOW>;
+		};
+
+		led_fan5_fault {
+			label = "LED_FAN5_FAULT";
+			gpios = <&gpio ASPEED_GPIO(H, 7) GPIO_ACTIVE_LOW>;
+		};
+
+		fp_led_status_amber_n {
+			label = "FP_LED_STATUS_AMBER_N";
+			gpios = <&gpio ASPEED_GPIO(S, 5) GPIO_ACTIVE_LOW>;
+		};
+
+		rear_id_led_n {
+			label = "REAR_ID_LED_N";
+			gpios = <&gpio ASPEED_GPIO(S, 6) GPIO_ACTIVE_LOW>;
+		};
+	};
+};
+
+&fmc {
+	status = "okay";
+	flash@0 {

arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts line 102

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +10 -0
+		status = "okay";
+		m25p,fast-read;
+		label = "bmc";
+		spi-max-frequency = <50000000>;
+#include "openbmc-flash-layout.dtsi"
+	};
+};
+
+&spi1 {
+	status = "okay";

Should have at least:

pinctrl-names = "default";
pinctrl-0 = <&pinctrl_spi1_default>;

And then if you need additional chip selects, you should add them too.

arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts line 112

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +10 -0
+	flash@0 {
+		status = "okay";
+		m25p,fast-read;
+		label = "pnor";
+		spi-max-frequency = <100000000>;
+	};
+};
+
+&spi2 {
+	status = "okay";

Is this necessary given no flash device is defined?

If it is, you also need pinctrl properties.

Quoted 12 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +12 -0
+};
+
+&uart5 {
+	status = "okay";
+};
+
+&mac0 {
+	status = "okay";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rgmii1_default &pinctrl_mdio1_default>;
+};

arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts line 134

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts new file +10 -0
+
+&mac1 {
+	status = "okay";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>;
+};
+
+&adc {
+	status = "okay";

Given you're using the ADC lines in the iio-hwmon bridge, you need to request the ADC pins from pinmux here. ADC is the default mux configuration for the pins, so this will happen to work as is, but pinmux will not prevent something else from requesting the pins out from underneath the ADC.

Andrew