Skip to contentSkip to conversation

blk-mq-debugfs: Add decode for BLK_MQ_F_TAG_HCTX_SHARED

PATCH Applied John Garry 3 participants 3 messages Jan 8, 2021 – Jan 11, 2021 Block layer

lore
Share & tools
lore

John Garry

author
#0 lore raw

PATCH 1/1 blk-mq-debugfs: Add decode for BLK_MQ_F_TAG_HCTX_SHARED

Showing the hctx flags for when BLK_MQ_F_TAG_HCTX_SHARED is set gives something like:

root@debian:/home/john# more /sys/kernel/debug/block/sda/hctx0/flags
alloc_policy=FIFO SHOULD_MERGE|TAG_QUEUE_SHARED|3

Add the decoding for that flag.

Fixes 32bc15afed04b ("blk-mq: Facilitate a shared sbitmap per tagset")
block/blk-mq-debugfs.c +1 -0
index 3094542e12ae..ea4ab98e6b25 100644
@@ -245,6 +245,7 @@ static const char *const hctx_flag_name[] = {
 	HCTX_FLAG_NAME(BLOCKING),
 	HCTX_FLAG_NAME(NO_SCHED),
 	HCTX_FLAG_NAME(STACKING),
+	HCTX_FLAG_NAME(TAG_HCTX_SHARED),
 };
 #undef HCTX_FLAG_NAME
 
Signature · 1 line
2.26.2
maintainer Applied
#1 lore raw
Quoted 5 lines · John Garry

Showing the hctx flags for when BLK_MQ_F_TAG_HCTX_SHARED is set gives something like:

root@debian:/home/john# more /sys/kernel/debug/block/sda/hctx0/flags
alloc_policy=FIFO SHOULD_MERGE|TAG_QUEUE_SHARED|3

Applied, thanks.

Signature · 1 line
Jens Axboe
Reviewed-by on v1 1/1
#2 lore raw
In reply to John Garry
Quoted 17 lines · John Garry

Showing the hctx flags for when BLK_MQ_F_TAG_HCTX_SHARED is set gives something like:

root@debian:/home/john# more /sys/kernel/debug/block/sda/hctx0/flags
alloc_policy=FIFO SHOULD_MERGE|TAG_QUEUE_SHARED|3

Add the decoding for that flag.

Fixes 32bc15afed04b ("blk-mq: Facilitate a shared sbitmap per tagset")
block/blk-mq-debugfs.c +0 -0
index 3094542e12ae..ea4ab98e6b25 100644

block/blk-mq-debugfs.c static const char *const hctx_flag_name[] = { · line 251

Quoted 7 lines
block/blk-mq-debugfs.c +1 -0
@@ -245,6 +245,7 @@ static const char *const hctx_flag_name[] = {
  	HCTX_FLAG_NAME(BLOCKING),
  	HCTX_FLAG_NAME(NO_SCHED),
  	HCTX_FLAG_NAME(STACKING),
+	HCTX_FLAG_NAME(TAG_HCTX_SHARED),
  };
  #undef HCTX_FLAG_NAME
 

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke                Kernel Storage Architect
[email protected]                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer