Skip to contentSkip to conversation

net: ipa: modem: add missing SET_NETDEV_DEV() for proper sysfs links

PATCH Applied Stephan Gerhold 4 participants 4 messages Jan 6, 2021 – Jan 11, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: ipa: modem: add missing SET_NETDEV_DEV() for proper sysfs links

At the moment it is quite hard to identify the network interface provided by IPA in userspace components: The network interface is created as virtual device, without any link to the IPA device. The interface name ("rmnet_ipa%d") is the only indication that the network interface belongs to IPA, but this is not very reliable.

Add SET_NETDEV_DEV() to associate the network interface with the IPA parent device. This allows userspace services like ModemManager to properly identify that this network interface is provided by IPA and belongs to the modem.

Cc Alex Elder <[email protected]>
Fixes a646d6ec9098 ("soc: qcom: ipa: modem and microcontroller")
---
 drivers/net/ipa/ipa_modem.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ipa/ipa_modem.c +1 -0
index e34fe2d77324..9b08eb823984 100644
@@ -216,6 +216,7 @@ int ipa_modem_start(struct ipa *ipa)
 	ipa->name_map[IPA_ENDPOINT_AP_MODEM_TX]->netdev = netdev;
 	ipa->name_map[IPA_ENDPOINT_AP_MODEM_RX]->netdev = netdev;
 
+	SET_NETDEV_DEV(netdev, &ipa->pdev->dev);
 	priv = netdev_priv(netdev);
 	priv->ipa = ipa;
 
Signature · 1 line
2.30.0
maintainer
#1 lore raw
Quoted 6 lines · On Wed, 6 Jan 2021 11:07:55 +0100 Stephan Gerhold wrote:

At the moment it is quite hard to identify the network interface provided by IPA in userspace components: The network interface is created as virtual device, without any link to the IPA device. The interface name ("rmnet_ipa%d") is the only indication that the network interface belongs to IPA, but this is not very reliable.

Quoted 8 lines

Add SET_NETDEV_DEV() to associate the network interface with the IPA parent device. This allows userspace services like ModemManager to properly identify that this network interface is provided by IPA and belongs to the modem.

Cc Alex Elder <[email protected]>
Fixes a646d6ec9098 ("soc: qcom: ipa: modem and microcontroller")

Alex, can we get an ack?

#2 lore raw
Quoted 12 lines · Jakub Kicinski
Quoted 11 lines · On Wed, 6 Jan 2021 11:07:55 +0100 Stephan Gerhold wrote:

At the moment it is quite hard to identify the network interface provided by IPA in userspace components: The network interface is created as virtual device, without any link to the IPA device. The interface name ("rmnet_ipa%d") is the only indication that the network interface belongs to IPA, but this is not very reliable.

Add SET_NETDEV_DEV() to associate the network interface with the IPA parent device. This allows userspace services like ModemManager to properly identify that this network interface is provided by IPA and belongs to the modem.

Quoted 5 lines
Quoted 3 lines
Cc Alex Elder <[email protected]>
Fixes a646d6ec9098 ("soc: qcom: ipa: modem and microcontroller")

Alex, can we get an ack?

Too late, but this looks good. Thank you for applying it. I don't always spot messages not "To:" me. I still need to improve my mail filtering. Sorry about that.

-Alex

#3 lore raw
In reply to Stephan Gerhold
This patch was applied to netdev/net.git (refs/heads/master):

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

Quoted 6 lines · On Wed, 6 Jan 2021 11:07:55 +0100 you wrote:

At the moment it is quite hard to identify the network interface provided by IPA in userspace components: The network interface is created as virtual device, without any link to the IPA device. The interface name ("rmnet_ipa%d") is the only indication that the network interface belongs to IPA, but this is not very reliable.

Quoted 6 lines

Add SET_NETDEV_DEV() to associate the network interface with the IPA parent device. This allows userspace services like ModemManager to properly identify that this network interface is provided by IPA and belongs to the modem.

[...]

Here is the summary with links:
- [net] net: ipa: modem: add missing SET_NETDEV_DEV() for proper sysfs links

    https://git.kernel.org/netdev/net/c/afba9dc1f3a5

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html