Skip to contentSkip to conversation

build rte_reciprocal.c on windows and export rte_reciprocal_value_u64

PATCH In review Tyler Retzlaff 2 participants 2 messages Jan 11, 2021 2 messages not in the archive Arm/Amlogic Meson SoC support

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20 [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

PATCH 1/1 build rte_reciprocal.c on windows and export rte_reciprocal_value_u64

From: Tyler Retzlaff <[email protected]>

---
 lib/librte_eal/common/meson.build  | 1 +
 lib/librte_eal/rte_eal_exports.def | 1 +
 2 files changed, 2 insertions(+)
lib/librte_eal/common/meson.build +1 -0
index 39abf7a0a..9c6f18eb8 100644
@@ -34,6 +34,7 @@ if is_windows
 		'rte_malloc.c',
 		'eal_common_timer.c',
 		'rte_service.c',
+		'rte_reciprocal.c',
 	)
 	subdir_done()
 endif
lib/librte_eal/rte_eal_exports.def +1 -0
index 4597eb8cd..ba1443dc2 100644
@@ -326,3 +326,4 @@ EXPORTS
 	rte_mem_map
 	rte_mem_page_size
 	rte_mem_unmap
+	rte_reciprocal_value_u64
Signature · 1 line
2.29.0.vfs.0.0
#3 lore raw

Subject line is too long and doesn't follow the guidelines:

https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-subject-line

It could be: "eal/windows: build rte_reciprocal functions" or better.

lib/librte_eal/rte_eal_exports.def EXPORTS · line 329

Quoted 9 lines
lib/librte_eal/rte_eal_exports.def +1 -0
index 4597eb8cd..ba1443dc2 100644
@@ -326,3 +326,4 @@ EXPORTS
 	rte_mem_map
 	rte_mem_page_size
 	rte_mem_unmap
+	rte_reciprocal_value_u64

+ rte_reciprocal_value

Please keep the order in .def same as in .map.