pinctrl: sprd: Simplify bool comparison
Subsystems (3)
PATCH v2 1/1 pinctrl: sprd: Simplify bool comparison
Fix the following coccicheck warning:
./drivers/pinctrl/sprd/pinctrl-sprd.c:690:8-23: WARNING: Comparison to bool
Reported-by Abaci Robot <[email protected]>
Signed-off-by Yang Li <[email protected]>
---
Changes in v2:
- make "pinctrl: sprd:" as subject prefix
drivers/pinctrl/sprd/pinctrl-sprd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/sprd/pinctrl-sprd.c +1 -1
@@ -687,7 +687,7 @@ static int sprd_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin_id, shift =INPUT_SCHMITT_SHIFT ;break ;case PIN_CONFIG_BIAS_PULL_UP : -if (is_sleep_config == true) { +if (is_sleep_config) { val |=SLEEP_PULL_UP ; mask =SLEEP_PULL_UP_MASK ; shift =SLEEP_PULL_UP_SHIFT ;
Signature · 1 line
1.8.3.1
Quoted 7 lines · Yang Li
Fix the following coccicheck warning:
./drivers/pinctrl/sprd/pinctrl-sprd.c:690:8-23: WARNING: Comparison to boolReported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>
You should keep other guy's reviewed-by or acked-by tag for the following version if no other big changes. So again
Reviewed-by Baolin Wang <[email protected]>
Quoted 23 lines
---
Changes in v2:
- make "pinctrl: sprd:" as subject prefixdrivers/pinctrl/sprd/pinctrl-sprd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pinctrl/sprd/pinctrl-sprd.c +1
-2@@ -687,7 +687,7 @@ static int sprd_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin_id, shift =INPUT_SCHMITT_SHIFT ;break ;case PIN_CONFIG_BIAS_PULL_UP : -if (is_sleep_config == true) { +if (is_sleep_config) { val |=SLEEP_PULL_UP ; mask =SLEEP_PULL_UP_MASK ; shift =SLEEP_PULL_UP_SHIFT ; --1.8.3.1
Signature · 1 line
Baolin Wang