Skip to contentSkip to conversation

net/bridge: Fix inconsistent format argument types

PATCH In review Jiapeng Zhong 2 participants 2 messages Jan 13, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/bridge: Fix inconsistent format argument types

Fix the following warnings:

net/bridge/br_sysfs_if.c(162): warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'. net/bridge/br_sysfs_if.c(155): warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'. net/bridge/br_sysfs_if.c(148): warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'.

---
 net/bridge/br_sysfs_if.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
net/bridge/br_sysfs_if.c +3 -3
index 7a59cdd..16a7d41 100644
@@ -145,21 +145,21 @@ static ssize_t show_port_state(struct net_bridge_port *p, char *buf)
 static ssize_t show_message_age_timer(struct net_bridge_port *p,
 					    char *buf)
 {
-	return sprintf(buf, "%ld\n", br_timer_value(&p->message_age_timer));
+	return sprintf(buf, "%lu\n", br_timer_value(&p->message_age_timer));
 }
 static BRPORT_ATTR(message_age_timer, 0444, show_message_age_timer, NULL);
 
 static ssize_t show_forward_delay_timer(struct net_bridge_port *p,
 					    char *buf)
 {
-	return sprintf(buf, "%ld\n", br_timer_value(&p->forward_delay_timer));
+	return sprintf(buf, "%lu\n", br_timer_value(&p->forward_delay_timer));
 }
 static BRPORT_ATTR(forward_delay_timer, 0444, show_forward_delay_timer, NULL);
 
 static ssize_t show_hold_timer(struct net_bridge_port *p,
 					    char *buf)
 {
-	return sprintf(buf, "%ld\n", br_timer_value(&p->hold_timer));
+	return sprintf(buf, "%lu\n", br_timer_value(&p->hold_timer));
 }
 static BRPORT_ATTR(hold_timer, 0444, show_hold_timer, NULL);
 
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 9 lines · Jiapeng Zhong

Fix the following warnings:

net/bridge/br_sysfs_if.c(162): warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'. net/bridge/br_sysfs_if.c(155): warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'. net/bridge/br_sysfs_if.c(148): warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'.

Quoted 6 lines
---
 net/bridge/br_sysfs_if.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

As I replied to your other patch with the same subject please squash them together and send them targeted at net-next.

Thanks.

Quoted 30 lines
net/bridge/br_sysfs_if.c +3 -3
index 7a59cdd..16a7d41 100644
@@ -145,21 +145,21 @@ static ssize_t show_port_state(struct net_bridge_port *p, char *buf)
 static ssize_t show_message_age_timer(struct net_bridge_port *p,
 					    char *buf)
 {
-	return sprintf(buf, "%ld\n", br_timer_value(&p->message_age_timer));
+	return sprintf(buf, "%lu\n", br_timer_value(&p->message_age_timer));
 }
 static BRPORT_ATTR(message_age_timer, 0444, show_message_age_timer, NULL);
 
 static ssize_t show_forward_delay_timer(struct net_bridge_port *p,
 					    char *buf)
 {
-	return sprintf(buf, "%ld\n", br_timer_value(&p->forward_delay_timer));
+	return sprintf(buf, "%lu\n", br_timer_value(&p->forward_delay_timer));
 }
 static BRPORT_ATTR(forward_delay_timer, 0444, show_forward_delay_timer, NULL);
 
 static ssize_t show_hold_timer(struct net_bridge_port *p,
 					    char *buf)
 {
-	return sprintf(buf, "%ld\n", br_timer_value(&p->hold_timer));
+	return sprintf(buf, "%lu\n", br_timer_value(&p->hold_timer));
 }
 static BRPORT_ATTR(hold_timer, 0444, show_hold_timer, NULL);