Skip to contentSkip to conversation

trace-cmd: Fix lib audit warning message

PATCH In review Sameeruddin shaik 2 participants 2 messages Jan 14, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 trace-cmd: Fix lib audit warning message

statically updated the warning message which we will get, when compiling trace-cmd without the libaudit library.

Following are the the messages which will pop out when compiling

Before:
-------
trace-profile.c:23:3: warning: #warning "lib audit not found, using raw syscalls " "(install libaudit-devel and try again)"

After:
-------
trace-profile.c:23:3: warning: #warning "lib audit not found, using raw syscalls " "(install libaudit-devel(for fedora) or libaudit-dev(for debian/ubuntu) and try again)"

---
 tracecmd/trace-profile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tracecmd/trace-profile.c +1 -1
index cfae2a2..9b5c385 100644
@@ -21,7 +21,7 @@
 
 #ifdef WARN_NO_AUDIT
 # warning "lib audit not found, using raw syscalls "	\
-	"(install libaudit-devel and try again)"
+	"(install libaudit-devel(for fedora) or libaudit-dev(for debian/ubuntu) and try again)"
 #endif
 
 #define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWP"
Signature · 1 line
2.7.4
#1 lore raw

On Thu, 14 Jan 2021 12:14:48 +0530
Sameeruddin shaik <[email protected]> wrote:

Thanks Sameer!

Just FYI, this isn't that important for this patch, but just to inform you about basic procedures (we follow the Linux kernel method). When sending a second version of the patch, add a "v2" to the subject. That is, "[PATCH v2] trace-cmd: Fix lib audit warning message". Then below the Signed-off-by (after the "---") add a section of "Changes since v1:" that gives a brief list of changes that were made in the new version. But again, not a big deal for this one, but something to be aware of for future patches :)

Anyway, I did a preliminary test, and it looks like you this applies without issue. I'll add it tomorrow. Thanks!

-- Steve

Quoted 31 lines

statically updated the warning message which we will get, when compiling trace-cmd without the libaudit library.

Following are the the messages which will pop out when compiling

Before:
-------
trace-profile.c:23:3: warning: #warning "lib audit not found, using raw syscalls " "(install libaudit-devel and try again)"

After:
-------
trace-profile.c:23:3: warning: #warning "lib audit not found, using raw syscalls " "(install libaudit-devel(for fedora) or libaudit-dev(for debian/ubuntu) and try again)"

---
 tracecmd/trace-profile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tracecmd/trace-profile.c +1 -1
index cfae2a2..9b5c385 100644
@@ -21,7 +21,7 @@
 
 #ifdef WARN_NO_AUDIT
 # warning "lib audit not found, using raw syscalls "	\
-	"(install libaudit-devel and try again)"
+	"(install libaudit-devel(for fedora) or libaudit-dev(for debian/ubuntu) and try again)"
 #endif
 
 #define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWP"