Skip to contentSkip to conversation

lib: stackdepot: Add support to configure STACK_HASH_SIZE

PATCH Superseded [email protected] 4 participants 11 messages Jan 18, 2021 – Jan 22, 2021

Subsystems (2)

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/2 lib: stackdepot: Add support to configure STACK_HASH_SIZE

From: Yogesh Lal <[email protected]>

Use CONFIG_STACK_HASH_ORDER to configure STACK_HASH_SIZE.

Aim is to have configurable value for STACK_HASH_SIZE, so depend on use case one can configure it.

One example is of Page Owner, default value of STACK_HASH_SIZE lead stack depot to consume 8MB of static memory. Making it configurable and use lower value helps to enable features like CONFIG_PAGE_OWNER without any significant overhead.

---
 lib/Kconfig      | 9 +++++++++
 lib/stackdepot.c | 3 +--
 2 files changed, 10 insertions(+), 2 deletions(-)
lib/Kconfig +9 -0
index b46a9fd..96ee125 100644
@@ -651,6 +651,15 @@ config STACKDEPOT
 	bool
 	select STACKTRACE
 
+config STACK_HASH_ORDER
+	int "stack depot hash size (12 => 4KB, 20 => 1024KB)"
+	range 12 20
+	default 20
+	depends on STACKDEPOT
+	help
+	 Select the hash size as a power of 2 for the stackdepot hash table.
+	 Choose a lower value to reduce the memory impact.
+
 config SBITMAP
 	bool
 
lib/stackdepot.c +1 -2
index 2caffc6..dff8521 100644
@@ -142,8 +142,7 @@ static struct stack_record *depot_alloc_stack(unsigned long *entries, int size,
 	return stack;
 }
 
-#define STACK_HASH_ORDER 20
-#define STACK_HASH_SIZE (1L << STACK_HASH_ORDER)
+#define STACK_HASH_SIZE (1L << CONFIG_STACK_HASH_ORDER)
 #define STACK_HASH_MASK (STACK_HASH_SIZE - 1)
 #define STACK_HASH_SEED 0x9747b28c
 
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
2.7.4
#1 lore raw

PATCH v5 2/2 lib: stackdepot: Add support to disable stack depot

From: Vijayanand Jitta <[email protected]>

Add a kernel parameter stack_depot_disable to disable stack depot. So that stack hash table doesn't consume any memory when stack depot is disabled.

---
 include/linux/stackdepot.h |  1 +
 init/main.c                |  2 ++
 lib/stackdepot.c           | 33 +++++++++++++++++++++++++++++----
 3 files changed, 32 insertions(+), 4 deletions(-)
include/linux/stackdepot.h +1 -0
index 24d49c7..eafd9aa 100644
@@ -21,4 +21,5 @@ unsigned int stack_depot_fetch(depot_stack_handle_t handle,
 
 unsigned int filter_irq_stacks(unsigned long *entries, unsigned int nr_entries);
 
+int stack_depot_init(void);
 #endif
init/main.c +2 -0
index 32b2a8a..8fcf9bb 100644
@@ -98,6 +98,7 @@
 #include <linux/mem_encrypt.h>
 #include <linux/kcsan.h>
 #include <linux/init_syscalls.h>
+#include <linux/stackdepot.h>
 
 #include <asm/io.h>
 #include <asm/bugs.h>
@@ -827,6 +828,7 @@ static void __init mm_init(void)
 	page_ext_init_flatmem();
 	init_debug_pagealloc();
 	report_meminit();
+	stack_depot_init();
 	mem_init();
 	kmem_cache_init();
 	kmemleak_init();
lib/stackdepot.c +29 -4
index dff8521..d20e6fd 100644
@@ -31,6 +31,8 @@
 #include <linux/stackdepot.h>
 #include <linux/string.h>
 #include <linux/types.h>
+#include <linux/vmalloc.h>
+#include <linux/memblock.h>
 
 #define DEPOT_STACK_BITS (sizeof(depot_stack_handle_t) * 8)
 
@@ -146,9 +148,32 @@ static struct stack_record *depot_alloc_stack(unsigned long *entries, int size,
 #define STACK_HASH_MASK (STACK_HASH_SIZE - 1)
 #define STACK_HASH_SEED 0x9747b28c
 
-static struct stack_record *stack_table[STACK_HASH_SIZE] = {
-	[0 ...	STACK_HASH_SIZE - 1] = NULL
-};
+static bool stack_depot_disable;
+static struct stack_record **stack_table;
+
+static int __init is_stack_depot_disabled(char *str)
+{
+	kstrtobool(str, &stack_depot_disable);
+	if (stack_depot_disable) {
+		pr_info("Stack Depot is disabled\n");
+		stack_table = NULL;
+	}
+	return 0;
+}
+early_param("stack_depot_disable", is_stack_depot_disabled);
+
+int __init stack_depot_init(void)
+{
+	if (!stack_depot_disable) {
+		size_t size = (STACK_HASH_SIZE * sizeof(struct stack_record *));
+		int i;
+
+		stack_table = memblock_alloc(size, size);
+		for (i = 0; i < STACK_HASH_SIZE;  i++)
+			stack_table[i] = NULL;
+	}
+	return 0;
+}
 
 /* Calculate hash for a stack */
 static inline u32 hash_stack(unsigned long *entries, unsigned int size)
@@ -242,7 +267,7 @@ depot_stack_handle_t stack_depot_save(unsigned long *entries,
 	unsigned long flags;
 	u32 hash;
 
-	if (unlikely(nr_entries == 0))
+	if (unlikely(nr_entries == 0) || stack_depot_disable)
 		goto fast_exit;
 
 	hash = hash_stack(entries, nr_entries);
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
2.7.4
#2 lore raw

Re: [PATCH v5 2/2] lib: stackdepot: Add support to disable stack depot

Quoted 5 lines · On Mon, Jan 18, 2021 at 03:26:42PM +0530, [email protected] wrote:

From: Vijayanand Jitta <[email protected]>

Add a kernel parameter stack_depot_disable to disable stack depot. So that stack hash table doesn't consume any memory when stack depot is disabled.

The usecase is CONFIG_PAGE_OWNER without page_owner=on. Without this patch, stackdepot will consume the memory for the hashtable. By default, it's 8M which is never trivial.

With this option, in CONFIG_PAGE_OWNER configured system, page_owner=off, stack_depot_disable in kernel command line, we could save the wasted memory for the hashtable.

Quoted 3 lines

Please also update kernel-parameters.txt.

Quoted 41 lines
---
 include/linux/stackdepot.h |  1 +
 init/main.c                |  2 ++
 lib/stackdepot.c           | 33 +++++++++++++++++++++++++++++----
 3 files changed, 32 insertions(+), 4 deletions(-)
include/linux/stackdepot.h +1 -0
index 24d49c7..eafd9aa 100644
@@ -21,4 +21,5 @@ unsigned int stack_depot_fetch(depot_stack_handle_t handle,
 
 unsigned int filter_irq_stacks(unsigned long *entries, unsigned int nr_entries);
 
+int stack_depot_init(void);
 #endif
init/main.c +2 -0
index 32b2a8a..8fcf9bb 100644
@@ -98,6 +98,7 @@
 #include <linux/mem_encrypt.h>
 #include <linux/kcsan.h>
 #include <linux/init_syscalls.h>
+#include <linux/stackdepot.h>
 
 #include <asm/io.h>
 #include <asm/bugs.h>
@@ -827,6 +828,7 @@ static void __init mm_init(void)
 	page_ext_init_flatmem();
 	init_debug_pagealloc();
 	report_meminit();
+	stack_depot_init();
 	mem_init();
 	kmem_cache_init();
 	kmemleak_init();
lib/stackdepot.c +0 -0
index dff8521..d20e6fd 100644

lib/stackdepot.c line 34

Quoted 4 lines
lib/stackdepot.c +1 -0
@@ -31,6 +31,8 @@
 #include <linux/stackdepot.h>
 #include <linux/string.h>
 #include <linux/types.h>
+#include <linux/vmalloc.h>

Why do we need vmalloc?

Otherwise, looks good to me.
Thank you!

#3 lore raw

Re: [PATCH v5 2/2] lib: stackdepot: Add support to disable stack depot

Quoted 7 lines · Minchan Kim
Quoted 5 lines · On Mon, Jan 18, 2021 at 03:26:42PM +0530, [email protected] wrote:

From: Vijayanand Jitta <[email protected]>

Add a kernel parameter stack_depot_disable to disable stack depot. So that stack hash table doesn't consume any memory when stack depot is disabled.

Quoted 8 lines

The usecase is CONFIG_PAGE_OWNER without page_owner=on. Without this patch, stackdepot will consume the memory for the hashtable. By default, it's 8M which is never trivial.

With this option, in CONFIG_PAGE_OWNER configured system, page_owner=off, stack_depot_disable in kernel command line, we could save the wasted memory for the hashtable.

Sure, will update the commit text with above details.

Quoted 6 lines
Quoted 3 lines

Please also update kernel-parameters.txt.

Sure.

Quoted 39 lines
Quoted 39 lines
---
 include/linux/stackdepot.h |  1 +
 init/main.c                |  2 ++
 lib/stackdepot.c           | 33 +++++++++++++++++++++++++++++----
 3 files changed, 32 insertions(+), 4 deletions(-)
include/linux/stackdepot.h +1 -0
index 24d49c7..eafd9aa 100644
@@ -21,4 +21,5 @@ unsigned int stack_depot_fetch(depot_stack_handle_t handle,
 
 unsigned int filter_irq_stacks(unsigned long *entries, unsigned int nr_entries);
 
+int stack_depot_init(void);
 #endif
init/main.c +2 -0
index 32b2a8a..8fcf9bb 100644
@@ -98,6 +98,7 @@
 #include <linux/mem_encrypt.h>
 #include <linux/kcsan.h>
 #include <linux/init_syscalls.h>
+#include <linux/stackdepot.h>
 
 #include <asm/io.h>
 #include <asm/bugs.h>
@@ -827,6 +828,7 @@ static void __init mm_init(void)
 	page_ext_init_flatmem();
 	init_debug_pagealloc();
 	report_meminit();
+	stack_depot_init();
 	mem_init();
 	kmem_cache_init();
 	kmemleak_init();
lib/stackdepot.c +0 -1
index dff8521..d20e6fd 100644
--- a/lib/stackdepot.c
Quoted 9 lines

lib/stackdepot.c line 34

Quoted 6 lines

+++ b/lib/stackdepot.c

lib/stackdepot.c +1 -0
@@ -31,6 +31,8 @@
 #include <linux/stackdepot.h>
 #include <linux/string.h>
 #include <linux/types.h>
+#include <linux/vmalloc.h>

Why do we need vmalloc?

Its not needed, will remove it.

Quoted 3 lines

Otherwise, looks good to me.
Thank you!

Thanks for the review.

Thanks,
Vijay

Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of Code Aurora Forum, hosted by The Linux Foundation
#4 lore raw
In reply to [email protected]
Quoted 7 lines · On 1/18/21 1:56 AM, [email protected] wrote:

From: Yogesh Lal <[email protected]>

Use CONFIG_STACK_HASH_ORDER to configure STACK_HASH_SIZE.

Aim is to have configurable value for STACK_HASH_SIZE, so depend on use case one can configure it.

Quoted 8 lines

One example is of Page Owner, default value of STACK_HASH_SIZE lead stack depot to consume 8MB of static memory. Making it configurable and use lower value helps to enable features like CONFIG_PAGE_OWNER without any significant overhead.

Hi,

Did you see
https://lore.kernel.org/lkml/[email protected]/

It seems that arch/arc/ does not have:
arc-elf-ld: lib/stackdepot.o: in function `filter_irq_stacks':
(.text+0x6): undefined reference to `__irqentry_text_start'

Quoted 7 lines
Quoted 7 lines

arc-elf-ld: (.text+0x6): undefined reference to `__irqentry_text_start'
arc-elf-ld: (.text+0x26): undefined reference to `__irqentry_text_end'
arc-elf-ld: (.text+0x26): undefined reference to `__irqentry_text_end'
arc-elf-ld: (.text+0x34): undefined reference to `__softirqentry_text_start'
arc-elf-ld: (.text+0x34): undefined reference to `__softirqentry_text_start'
arc-elf-ld: (.text+0x3c): undefined reference to `__softirqentry_text_end'
arc-elf-ld: (.text+0x3c): undefined reference to `__softirqentry_text_end'

Signature · 8 lines
~Randy
You can't do anything without having to do something else first.
-- Belefant's Law

_______________________________________________
linux-snps-arc mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
#5 lore raw
Quoted 17 lines · Randy Dunlap
Quoted 7 lines · On 1/18/21 1:56 AM, [email protected] wrote:

From: Yogesh Lal <[email protected]>

Use CONFIG_STACK_HASH_ORDER to configure STACK_HASH_SIZE.

Aim is to have configurable value for STACK_HASH_SIZE, so depend on use case one can configure it.

Quoted 8 lines

One example is of Page Owner, default value of STACK_HASH_SIZE lead stack depot to consume 8MB of static memory. Making it configurable and use lower value helps to enable features like CONFIG_PAGE_OWNER without any significant overhead.

Quoted 19 lines

Hi,

Did you see
https://lore.kernel.org/lkml/[email protected]/

It seems that arch/arc/ does not have:
arc-elf-ld: lib/stackdepot.o: in function `filter_irq_stacks':

   (.text+0x6): undefined reference to `__irqentry_text_start'
Quoted 7 lines
Quoted 7 lines

arc-elf-ld: (.text+0x6): undefined reference to `__irqentry_text_start'
arc-elf-ld: (.text+0x26): undefined reference to `__irqentry_text_end'
arc-elf-ld: (.text+0x26): undefined reference to `__irqentry_text_end'
arc-elf-ld: (.text+0x34): undefined reference to `__softirqentry_text_start'
arc-elf-ld: (.text+0x34): undefined reference to `__softirqentry_text_start'
arc-elf-ld: (.text+0x3c): undefined reference to `__softirqentry_text_end'
arc-elf-ld: (.text+0x3c): undefined reference to `__softirqentry_text_end'

The above issue seems to be because of a different patch. This one
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=505a0ef15f96c6c43ec719c9fc1833d98957bb39

I didn't really get why you referred that here.

Thanks,
Vijay

Signature · 7 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of Code Aurora Forum, hosted by The Linux Foundation

_______________________________________________
linux-snps-arc mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
#6 lore raw
Quoted 40 lines · Vijayanand Jitta
Quoted 17 lines · Randy Dunlap
Quoted 7 lines · On 1/18/21 1:56 AM, [email protected] wrote:

From: Yogesh Lal <[email protected]>

Use CONFIG_STACK_HASH_ORDER to configure STACK_HASH_SIZE.

Aim is to have configurable value for STACK_HASH_SIZE, so depend on use case one can configure it.

Quoted 8 lines

One example is of Page Owner, default value of STACK_HASH_SIZE lead stack depot to consume 8MB of static memory. Making it configurable and use lower value helps to enable features like CONFIG_PAGE_OWNER without any significant overhead.

Quoted 19 lines

Hi,

Did you see
https://lore.kernel.org/lkml/[email protected]/

It seems that arch/arc/ does not have:
arc-elf-ld: lib/stackdepot.o: in function `filter_irq_stacks':

   (.text+0x6): undefined reference to `__irqentry_text_start'
Quoted 7 lines
Quoted 7 lines

arc-elf-ld: (.text+0x6): undefined reference to `__irqentry_text_start'
arc-elf-ld: (.text+0x26): undefined reference to `__irqentry_text_end'
arc-elf-ld: (.text+0x26): undefined reference to `__irqentry_text_end'
arc-elf-ld: (.text+0x34): undefined reference to `__softirqentry_text_start'
arc-elf-ld: (.text+0x34): undefined reference to `__softirqentry_text_start'
arc-elf-ld: (.text+0x3c): undefined reference to `__softirqentry_text_end'
arc-elf-ld: (.text+0x3c): undefined reference to `__softirqentry_text_end'

Quoted 5 lines

The above issue seems to be because of a different patch. This one
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=505a0ef15f96c6c43ec719c9fc1833d98957bb39

I didn't really get why you referred that here.

Yes, I noticed that later. Sorry about that.

Maybe Alexander P. can look into it...

thanks.

Signature · 8 lines
~Randy
You can't do anything without having to do something else first.
-- Belefant's Law

_______________________________________________
linux-snps-arc mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
#7 lore raw
In reply to Randy Dunlap
Quoted 18 lines · Randy Dunlap
Quoted 7 lines · On 1/18/21 1:56 AM, [email protected] wrote:

From: Yogesh Lal <[email protected]>

Use CONFIG_STACK_HASH_ORDER to configure STACK_HASH_SIZE.

Aim is to have configurable value for STACK_HASH_SIZE, so depend on use case one can configure it.

Quoted 8 lines

One example is of Page Owner, default value of STACK_HASH_SIZE lead stack depot to consume 8MB of static memory. Making it configurable and use lower value helps to enable features like CONFIG_PAGE_OWNER without any significant overhead.

Quoted 16 lines

Hi,

Did you see
https://lore.kernel.org/lkml/[email protected]/

It seems that arch/arc/ does not have:
arc-elf-ld: lib/stackdepot.o: in function `filter_irq_stacks':

   (.text+0x6): undefined reference to `__irqentry_text_start'
Quoted 7 lines
Quoted 7 lines

arc-elf-ld: (.text+0x6): undefined reference to `__irqentry_text_start'
arc-elf-ld: (.text+0x26): undefined reference to `__irqentry_text_end'
arc-elf-ld: (.text+0x26): undefined reference to `__irqentry_text_end'
arc-elf-ld: (.text+0x34): undefined reference to `__softirqentry_text_start'
arc-elf-ld: (.text+0x34): undefined reference to `__softirqentry_text_start'
arc-elf-ld: (.text+0x3c): undefined reference to `__softirqentry_text_end'
arc-elf-ld: (.text+0x3c): undefined reference to `__softirqentry_text_end'

Hi Randy,

Could you try out the following patch?

Thanks,
Alex

arch/arc/kernel/vmlinux.lds.S +2 -0
index 33ce59d91461..94d3f9620d0b 100644
@@ -83,6 +83,8 @@ SECTIONS
 
        .text : {
                _text = .;
+               IRQENTRY_TEXT
+               SOFTIRQENTRY_TEXT
                TEXT_TEXT
                SCHED_TEXT
                CPUIDLE_TEXT

_______________________________________________
linux-snps-arc mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Reviewed-by on v5 1/2
#8 lore raw
In reply to [email protected]
Quoted 11 lines · On Mon, Jan 18, 2021 at 03:26:41PM +0530, [email protected] wrote:

From: Yogesh Lal <[email protected]>

Use CONFIG_STACK_HASH_ORDER to configure STACK_HASH_SIZE.

Aim is to have configurable value for STACK_HASH_SIZE, so depend on use case one can configure it.

One example is of Page Owner, default value of STACK_HASH_SIZE lead stack depot to consume 8MB of static memory. Making it configurable and use lower value helps to enable features like CONFIG_PAGE_OWNER without any significant overhead.

The description could be improved to prevent confusing. CONFIG_PAGE_OWNER works only if page_owner=on via kernel parameter on CONFIG_PAGE_OWNER configured system.
Thus, unless admin enable it via command line option, the stackdepot will just waste 8M memory without any customer.

Quoted 4 lines
#9 lore raw
Quoted 13 lines · Minchan Kim
Quoted 11 lines · On Mon, Jan 18, 2021 at 03:26:41PM +0530, [email protected] wrote:

From: Yogesh Lal <[email protected]>

Use CONFIG_STACK_HASH_ORDER to configure STACK_HASH_SIZE.

Aim is to have configurable value for STACK_HASH_SIZE, so depend on use case one can configure it.

One example is of Page Owner, default value of STACK_HASH_SIZE lead stack depot to consume 8MB of static memory. Making it configurable and use lower value helps to enable features like CONFIG_PAGE_OWNER without any significant overhead.

Quoted 6 lines

The description could be improved to prevent confusing. CONFIG_PAGE_OWNER works only if page_owner=on via kernel parameter on CONFIG_PAGE_OWNER configured system.
Thus, unless admin enable it via command line option, the stackdepot will just waste 8M memory without any customer.

Sure, will update the commit text as suggested.

Thanks,
Vijay

Quoted 6 lines
Quoted 4 lines
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of Code Aurora Forum, hosted by The Linux Foundation
Reviewed-by on v5 1/2
#10 lore raw
In reply to [email protected]
Quoted 8 lines · On Mon, Jan 18, 2021 at 10:57 AM <[email protected]> wrote:

From: Yogesh Lal <[email protected]>

Use CONFIG_STACK_HASH_ORDER to configure STACK_HASH_SIZE.

Aim is to have configurable value for STACK_HASH_SIZE, so depend on use case one can configure it.

Quoted 8 lines

One example is of Page Owner, default value of STACK_HASH_SIZE lead stack depot to consume 8MB of static memory. Making it configurable and use lower value helps to enable features like CONFIG_PAGE_OWNER without any significant overhead.

Quoted 43 lines
---
 lib/Kconfig      | 9 +++++++++
 lib/stackdepot.c | 3 +--
 2 files changed, 10 insertions(+), 2 deletions(-)
lib/Kconfig +9 -0
index b46a9fd..96ee125 100644
@@ -651,6 +651,15 @@ config STACKDEPOT
        bool
        select STACKTRACE
 
+config STACK_HASH_ORDER
+       int "stack depot hash size (12 => 4KB, 20 => 1024KB)"
+       range 12 20
+       default 20
+       depends on STACKDEPOT
+       help
+        Select the hash size as a power of 2 for the stackdepot hash table.
+        Choose a lower value to reduce the memory impact.
+
 config SBITMAP
        bool
 
lib/stackdepot.c +1 -3
index 2caffc6..dff8521 100644
@@ -142,8 +142,7 @@ static struct stack_record *depot_alloc_stack(unsigned long *entries, int size,
        return stack;
 }
 
-#define STACK_HASH_ORDER 20
-#define STACK_HASH_SIZE (1L << STACK_HASH_ORDER)
+#define STACK_HASH_SIZE (1L << CONFIG_STACK_HASH_ORDER)
 #define STACK_HASH_MASK (STACK_HASH_SIZE - 1)
 #define STACK_HASH_SEED 0x9747b28c
 
--

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation 2.7.4

Signature · 10 lines
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Straße, 33
80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg