net: mscc: ocelot: allow offloading of bridge on top of LAG
Subsystems (3)
PATCH 1/1 net: mscc: ocelot: allow offloading of bridge on top of LAG
From: Vladimir Oltean <[email protected]>
The blamed commit was too aggressive, and it made ocelot_netdevice_event react only to network interface events emitted for the ocelot switch ports.
In fact, only the PRECHANGEUPPER should have had that check.
When we ignore all events that are not for us, we miss the fact that the upper of the LAG changes, and the bonding interface gets enslaved to a bridge. This is an operation we could offload under certain conditions.
--- drivers/net/ethernet/mscc/ocelot_net.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/ethernet/mscc/ocelot_net.c +1 -3
@@ -1042,10 +1042,8 @@ static int ocelot_netdevice_event(struct notifier_block *unused,struct net_device *dev =netdev_notifier_info_to_dev (ptr);int ret =0 ; -if (!ocelot_netdevice_dev_check (dev)) -return 0 ; -if (event ==NETDEV_PRECHANGEUPPER && +ocelot_netdevice_dev_check (dev) &&netif_is_lag_master (info->upper_dev)) {struct netdev_lag_upper_info *lag_upper_info = info->upper_info;struct netlink_ext_ack *extack;
Signature · 1 line
2.25.1
This patch was applied to netdev/net.git (refs/heads/master):
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
Quoted 9 lines · On Mon, 18 Jan 2021 15:52:10 +0200 you wrote:
From: Vladimir Oltean <[email protected]>
The blamed commit was too aggressive, and it made
ocelot_netdevice_eventreact only to network interface events emitted for the ocelot switch ports.In fact, only the PRECHANGEUPPER should have had that check.
[...]
Here is the summary with links:
- [net] net: mscc: ocelot: allow offloading of bridge on top of LAG
https://git.kernel.org/netdev/net/c/79267ae22615
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html