Skip to contentSkip to conversation

arcnet: fix macro name when DEBUG is defined

PATCH Applied [email protected] 3 participants 3 messages Jan 17, 2021 – Jan 19, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arcnet: fix macro name when DEBUG is defined

From: Tom Rix <[email protected]>

When DEBUG is defined this error occurs

drivers/net/arcnet/com20020_cs.c:70:15: error: ‘com20020_REG_W_ADDR_HI’
undeclared (first use in this function);
did you mean ‘COM20020_REG_W_ADDR_HI’?

       ioaddr, com20020_REG_W_ADDR_HI);
               ^~~~~~~~~~~~~~~~~~~~~~

From reviewing the context, the suggestion is what is meant.

Fixes 0fec65130b9f ("arcnet: com20020: Use arcnet_<I/O> routines")
---
 drivers/net/arcnet/com20020_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/arcnet/com20020_cs.c +1 -1
index cf607ffcf358..81223f6bebcc 100644
@@ -67,7 +67,7 @@ static void regdump(struct net_device *dev)
 	/* set up the address register */
 	count = 0;
 	arcnet_outb((count >> 8) | RDDATAflag | AUTOINCflag,
-		    ioaddr, com20020_REG_W_ADDR_HI);
+		    ioaddr, COM20020_REG_W_ADDR_HI);
 	arcnet_outb(count & 0xff, ioaddr, COM20020_REG_W_ADDR_LO);
 
 	for (count = 0; count < 256 + 32; count++) {
Signature · 1 line
2.27.0
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · On Sun, 2021-01-17 at 10:15 -0800, [email protected] wrote:

From: Tom Rix <[email protected]>

When DEBUG is defined this error occurs

drivers/net/arcnet/com20020_cs.c:70:15: error: ‘com20020_REG_W_ADDR_HI’ undeclared (first use in this function);
  did you mean ‘COM20020_REG_W_ADDR_HI’?
       ioaddr, com20020_REG_W_ADDR_HI); ^~~~~~~~~~~~~~~~~~~~~~

Quoted 3 lines

From reviewing the context, the suggestion is what is meant.

Fixes 0fec65130b9f ("arcnet: com20020: Use arcnet_<I/O> routines")

Nice find thanks, especially seeing as how this hasn't been tested or compiled in 5+ years...

	commit 0fec65130b9f11a73d74f47025491f97f82ba070
	Author: Joe Perches <[email protected]>
	Date:   Tue May 5 10:06:06 2015 -0700
Quoted 19 lines

---
 drivers/net/arcnet/com20020_cs.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/arcnet/com20020_cs.c +1 -1
index cf607ffcf358..81223f6bebcc 100644
@@ -67,7 +67,7 @@ static void regdump(struct net_device *dev)
  	/* set up the address register */
  	count = 0;
  	arcnet_outb((count >> 8) | RDDATAflag | AUTOINCflag,
-		    ioaddr, com20020_REG_W_ADDR_HI);
+		    ioaddr, COM20020_REG_W_ADDR_HI);
  	arcnet_outb(count & 0xff, ioaddr, COM20020_REG_W_ADDR_LO);

  for (count = 0; count < 256 + 32; count++) {

#2 lore raw
In reply to [email protected]
This patch was applied to netdev/net-next.git (refs/heads/master):

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

Quoted 11 lines · On Sun, 17 Jan 2021 10:15:19 -0800 you wrote:

From: Tom Rix <[email protected]>

When DEBUG is defined this error occurs

drivers/net/arcnet/com20020_cs.c:70:15: error: ‘com20020_REG_W_ADDR_HI’
undeclared (first use in this function);
did you mean ‘COM20020_REG_W_ADDR_HI’?

       ioaddr, com20020_REG_W_ADDR_HI);
               ^~~~~~~~~~~~~~~~~~~~~~

[...]

Here is the summary with links:
- arcnet: fix macro name when DEBUG is defined

    https://git.kernel.org/netdev/net-next/c/7cfabe4f85a5

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html