igc: Assign boolean values to a bool variable
Subsystems (3)
PATCH 1/1 igc: Assign boolean values to a bool variable
Fix the following coccicheck warnings:
./drivers/net/ethernet/intel/igc/igc_main.c:4961:2-14: WARNING:
Assignment of 0/1 to bool variable.
./drivers/net/ethernet/intel/igc/igc_main.c:4955:2-14: WARNING:
Assignment of 0/1 to bool variable.
./drivers/net/ethernet/intel/igc/igc_main.c:4933:1-13: WARNING:
Assignment of 0/1 to bool variable.
./drivers/net/ethernet/intel/igc/igc_main.c:4592:1-24: WARNING:
Assignment of 0/1 to bool variable.
./drivers/net/ethernet/intel/igc/igc_main.c:4438:2-25: WARNING:
Assignment of 0/1 to bool variable.
./drivers/net/ethernet/intel/igc/igc_main.c:4396:2-25: WARNING:
Assignment of 0/1 to bool variable.
./drivers/net/ethernet/intel/igc/igc_main.c:4018:2-25: WARNING:
Assignment of 0/1 to bool variable.
--- drivers/net/ethernet/intel/igc/igc_main.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/net/ethernet/intel/igc/igc_main.c +8 -8
@@ -3597,7 +3597,7 @@ void igc_up(struct igc_adapter *adapter)netif_tx_start_all_queues (adapter->netdev);/* start the watchdog. */ - hw->mac.get_link_status =1 ; + hw->mac.get_link_status = true;schedule_work (&adapter->watchdog_task); }
@@ -4016,7 +4016,7 @@ static irqreturn_t igc_msix_other(int irq, void *data) }if (icr &IGC_ICR_LSC ) { - hw->mac.get_link_status =1 ; + hw->mac.get_link_status = true;/* guard against interrupt when we're going down */ if (!test_bit (__IGC_DOWN, &adapter->state))mod_timer (&adapter->watchdog_timer, jiffies +1 );
@@ -4394,7 +4394,7 @@ static irqreturn_t igc_intr_msi(int irq, void *data) }if (icr & (IGC_ICR_RXSEQ |IGC_ICR_LSC )) { - hw->mac.get_link_status =1 ; + hw->mac.get_link_status = true;if (!test_bit (__IGC_DOWN, &adapter->state))mod_timer (&adapter->watchdog_timer, jiffies +1 ); }
@@ -4436,7 +4436,7 @@ static irqreturn_t igc_intr(int irq, void *data) }if (icr & (IGC_ICR_RXSEQ |IGC_ICR_LSC )) { - hw->mac.get_link_status =1 ; + hw->mac.get_link_status = true;/* guard against interrupt when we're going down */ if (!test_bit (__IGC_DOWN, &adapter->state))mod_timer (&adapter->watchdog_timer, jiffies +1 );
@@ -4590,7 +4590,7 @@ static int __igc_open(struct net_device *netdev, bool resuming)netif_tx_start_all_queues (netdev);/* start the watchdog. */ - hw->mac.get_link_status =1 ; + hw->mac.get_link_status = true;schedule_work (&adapter->watchdog_task);return IGC_SUCCESS ;
@@ -4931,7 +4931,7 @@ int igc_set_spd_dplx(struct igc_adapter *adapter, u32 spd, u8 dplx) {struct igc_mac_info *mac = &adapter->hw.mac; - mac->autoneg =0 ; + mac->autoneg = false;/* Make sure dplx is at most 1 bit and lsb of speed is not set * for the switch() below to work
@@ -4953,13 +4953,13 @@ int igc_set_spd_dplx(struct igc_adapter *adapter, u32 spd, u8 dplx) mac->forced_speed_duplex =ADVERTISE_100_FULL ;break ;case SPEED_1000 +DUPLEX_FULL : - mac->autoneg =1 ; + mac->autoneg = true; adapter->hw.phy.autoneg_advertised =ADVERTISE_1000_FULL ;break ;case SPEED_1000 +DUPLEX_HALF :/* not supported */ goto err_inval;case SPEED_2500 +DUPLEX_FULL : - mac->autoneg =1 ; + mac->autoneg = true; adapter->hw.phy.autoneg_advertised =ADVERTISE_2500_FULL ;break ;case SPEED_2500 +DUPLEX_HALF :/* not supported */
Signature · 1 line
1.8.3.1