Skip to contentSkip to conversation

rtlwifi: Assign boolean values to a bool variable

PATCH In review Jiapeng Zhong 2 participants 2 messages Jan 20, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtlwifi: Assign boolean values to a bool variable

Fix the following coccicheck warnings:

./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:
892:1-10: WARNING: Assignment of 0/1 to bool variable.

---
 drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c +1 -1
index be4c0e6..c198222 100644
@@ -873,7 +873,7 @@ static void halbtc_display_wifi_status(struct btc_coexist *btcoexist,
 	dc_mode = true;	/*TODO*/
 	under_ips = rtlpriv->psc.inactive_pwrstate == ERFOFF ? 1 : 0;
 	under_lps = rtlpriv->psc.dot11_psmode == EACTIVE ? 0 : 1;
-	low_power = 0; /*TODO*/
+	low_power = false; /*TODO*/
 	seq_printf(m, "\n %-35s = %s%s%s%s",
 		   "Power Status",
 		   (dc_mode ? "DC mode" : "AC mode"),
Signature · 1 line
1.8.3.1
#1 lore raw

drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c static void halbtc_display_wifi_status(struct btc_coexist *btcoexist, · line 876

Quoted 10 lines · Jiapeng Zhong
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c +1 -1
index be4c0e6..c198222 100644
@@ -873,7 +873,7 @@ static void halbtc_display_wifi_status(struct btc_coexist *btcoexist,
 	dc_mode = true;	/*TODO*/
 	under_ips = rtlpriv->psc.inactive_pwrstate == ERFOFF ? 1 : 0;
 	under_lps = rtlpriv->psc.dot11_psmode == EACTIVE ? 0 : 1;
-	low_power = 0; /*TODO*/
+	low_power = false; /*TODO*/

you could drop that assignment as it is already initialized to false at the top.

drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c static void halbtc_display_wifi_status(struct btc_coexist *btcoexist, · line 879

Quoted 3 lines
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c +0 -0
 	seq_printf(m, "\n %-35s = %s%s%s%s",
 		   "Power Status",
 		   (dc_mode ? "DC mode" : "AC mode"),

Sebastian