mmc: Assign boolean values to a bool variable
PATCH 1/1 mmc: Assign boolean values to a bool variable
Fix the following coccicheck warnings:
./drivers/mmc/host/atmel-mci.c:2436:2-34: WARNING: Assignment of 0/1 to bool variable.
./drivers/mmc/host/atmel-mci.c:2425:2-20: WARNING: Assignment of 0/1 to bool variable.
--- drivers/mmc/host/atmel-mci.c | 46 ++++++++++++++++++++++---------------------- 1 file changed, 23 insertions(+), 23 deletions(-)
drivers/mmc/host/atmel-mci.c +23 -23
@@ -2401,45 +2401,45 @@ static void atmci_get_cap(struct atmel_mci *host)dev_info (&host->pdev->dev,"version: 0x%x\n" , version); - host->caps.has_dma_conf_reg =0 ; - host->caps.has_pdc =1 ; - host->caps.has_cfg_reg =0 ; - host->caps.has_cstor_reg =0 ; - host->caps.has_highspeed =0 ; - host->caps.has_rwproof =0 ; - host->caps.has_odd_clk_div =0 ; - host->caps.has_bad_data_ordering =1 ; - host->caps.need_reset_after_xfer =1 ; - host->caps.need_blksz_mul_4 =1 ; - host->caps.need_notbusy_for_read_ops =0 ; + host->caps.has_dma_conf_reg = false; + host->caps.has_pdc = true; + host->caps.has_cfg_reg = false; + host->caps.has_cstor_reg = false; + host->caps.has_highspeed = false; + host->caps.has_rwproof = false; + host->caps.has_odd_clk_div = false; + host->caps.has_bad_data_ordering = true; + host->caps.need_reset_after_xfer = true; + host->caps.need_blksz_mul_4 = true; + host->caps.need_notbusy_for_read_ops = false;/* keep only major version number */ switch (version &0xf00 ) {case 0x600 :case 0x500 : - host->caps.has_odd_clk_div =1 ; + host->caps.has_odd_clk_div = true; fallthrough;case 0x400 :case 0x300 : - host->caps.has_dma_conf_reg =1 ; - host->caps.has_pdc =0 ; - host->caps.has_cfg_reg =1 ; - host->caps.has_cstor_reg =1 ; - host->caps.has_highspeed =1 ; + host->caps.has_dma_conf_reg = true; + host->caps.has_pdc = false; + host->caps.has_cfg_reg = true; + host->caps.has_cstor_reg = true; + host->caps.has_highspeed = true; fallthrough;case 0x200 : - host->caps.has_rwproof =1 ; - host->caps.need_blksz_mul_4 =0 ; - host->caps.need_notbusy_for_read_ops =1 ; + host->caps.has_rwproof = true; + host->caps.need_blksz_mul_4 = false; + host->caps.need_notbusy_for_read_ops = true; fallthrough;case 0x100 : - host->caps.has_bad_data_ordering =0 ; - host->caps.need_reset_after_xfer =0 ; + host->caps.has_bad_data_ordering = false; + host->caps.need_reset_after_xfer = false; fallthrough;case 0x0 :break ;default : - host->caps.has_pdc =0 ; + host->caps.has_pdc = false;dev_warn (&host->pdev->dev,"Unmanaged mci version, set minimum capabilities\n" );break ;
Signature · 1 line
1.8.3.1
Quoted 10 lines · Jiapeng Zhong
Fix the following coccicheck warnings:
./drivers/mmc/host/atmel-mci.c:2436:2-34: WARNING: Assignment of 0/1 to bool variable.
./drivers/mmc/host/atmel-mci.c:2425:2-20: WARNING: Assignment of 0/1 to bool variable.
Reported-by Abaci Robot <[email protected]>Signed-off-by Jiapeng Zhong <[email protected]>
Thanks
Quoted 78 lines
--- drivers/mmc/host/atmel-mci.c | 46 ++++++++++++++++++++++---------------------- 1 file changed, 23 insertions(+), 23 deletions(-)drivers/mmc/host/atmel-mci.c +23
-24@@ -2401,45 +2401,45 @@ static void atmci_get_cap(struct atmel_mci *host)dev_info (&host->pdev->dev,"version: 0x%x\n" , version); - host->caps.has_dma_conf_reg =0 ; - host->caps.has_pdc =1 ; - host->caps.has_cfg_reg =0 ; - host->caps.has_cstor_reg =0 ; - host->caps.has_highspeed =0 ; - host->caps.has_rwproof =0 ; - host->caps.has_odd_clk_div =0 ; - host->caps.has_bad_data_ordering =1 ; - host->caps.need_reset_after_xfer =1 ; - host->caps.need_blksz_mul_4 =1 ; - host->caps.need_notbusy_for_read_ops =0 ; + host->caps.has_dma_conf_reg = false; + host->caps.has_pdc = true; + host->caps.has_cfg_reg = false; + host->caps.has_cstor_reg = false; + host->caps.has_highspeed = false; + host->caps.has_rwproof = false; + host->caps.has_odd_clk_div = false; + host->caps.has_bad_data_ordering = true; + host->caps.need_reset_after_xfer = true; + host->caps.need_blksz_mul_4 = true; + host->caps.need_notbusy_for_read_ops = false;/* keep only major version number */ switch (version &0xf00 ) {case 0x600 :case 0x500 : - host->caps.has_odd_clk_div =1 ; + host->caps.has_odd_clk_div = true; fallthrough;case 0x400 :case 0x300 : - host->caps.has_dma_conf_reg =1 ; - host->caps.has_pdc =0 ; - host->caps.has_cfg_reg =1 ; - host->caps.has_cstor_reg =1 ; - host->caps.has_highspeed =1 ; + host->caps.has_dma_conf_reg = true; + host->caps.has_pdc = false; + host->caps.has_cfg_reg = true; + host->caps.has_cstor_reg = true; + host->caps.has_highspeed = true; fallthrough;case 0x200 : - host->caps.has_rwproof =1 ; - host->caps.need_blksz_mul_4 =0 ; - host->caps.need_notbusy_for_read_ops =1 ; + host->caps.has_rwproof = true; + host->caps.need_blksz_mul_4 = false; + host->caps.need_notbusy_for_read_ops = true; fallthrough;case 0x100 : - host->caps.has_bad_data_ordering =0 ; - host->caps.need_reset_after_xfer =0 ; + host->caps.has_bad_data_ordering = false; + host->caps.need_reset_after_xfer = false; fallthrough;case 0x0 :break ;default : - host->caps.has_pdc =0 ; + host->caps.has_pdc = false;dev_warn (&host->pdev->dev,"Unmanaged mci version, set minimum capabilities\n" );break ; --
Quoted 2 lines
1.8.3.1
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 11 lines · Jiapeng Zhong
Fix the following coccicheck warnings:
./drivers/mmc/host/atmel-mci.c:2436:2-34: WARNING: Assignment of 0/1 to bool variable.
./drivers/mmc/host/atmel-mci.c:2425:2-20: WARNING: Assignment of 0/1 to bool variable.
Reported-by Abaci Robot <[email protected]>Signed-off-by Jiapeng Zhong <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
Quoted 78 lines
--- drivers/mmc/host/atmel-mci.c | 46 ++++++++++++++++++++++---------------------- 1 file changed, 23 insertions(+), 23 deletions(-)drivers/mmc/host/atmel-mci.c +23
-24@@ -2401,45 +2401,45 @@ static void atmci_get_cap(struct atmel_mci *host)dev_info (&host->pdev->dev,"version: 0x%x\n" , version); - host->caps.has_dma_conf_reg =0 ; - host->caps.has_pdc =1 ; - host->caps.has_cfg_reg =0 ; - host->caps.has_cstor_reg =0 ; - host->caps.has_highspeed =0 ; - host->caps.has_rwproof =0 ; - host->caps.has_odd_clk_div =0 ; - host->caps.has_bad_data_ordering =1 ; - host->caps.need_reset_after_xfer =1 ; - host->caps.need_blksz_mul_4 =1 ; - host->caps.need_notbusy_for_read_ops =0 ; + host->caps.has_dma_conf_reg = false; + host->caps.has_pdc = true; + host->caps.has_cfg_reg = false; + host->caps.has_cstor_reg = false; + host->caps.has_highspeed = false; + host->caps.has_rwproof = false; + host->caps.has_odd_clk_div = false; + host->caps.has_bad_data_ordering = true; + host->caps.need_reset_after_xfer = true; + host->caps.need_blksz_mul_4 = true; + host->caps.need_notbusy_for_read_ops = false;/* keep only major version number */ switch (version &0xf00 ) {case 0x600 :case 0x500 : - host->caps.has_odd_clk_div =1 ; + host->caps.has_odd_clk_div = true; fallthrough;case 0x400 :case 0x300 : - host->caps.has_dma_conf_reg =1 ; - host->caps.has_pdc =0 ; - host->caps.has_cfg_reg =1 ; - host->caps.has_cstor_reg =1 ; - host->caps.has_highspeed =1 ; + host->caps.has_dma_conf_reg = true; + host->caps.has_pdc = false; + host->caps.has_cfg_reg = true; + host->caps.has_cstor_reg = true; + host->caps.has_highspeed = true; fallthrough;case 0x200 : - host->caps.has_rwproof =1 ; - host->caps.need_blksz_mul_4 =0 ; - host->caps.need_notbusy_for_read_ops =1 ; + host->caps.has_rwproof = true; + host->caps.need_blksz_mul_4 = false; + host->caps.need_notbusy_for_read_ops = true; fallthrough;case 0x100 : - host->caps.has_bad_data_ordering =0 ; - host->caps.need_reset_after_xfer =0 ; + host->caps.has_bad_data_ordering = false; + host->caps.need_reset_after_xfer = false; fallthrough;case 0x0 :break ;default : - host->caps.has_pdc =0 ; + host->caps.has_pdc = false;dev_warn (&host->pdev->dev,"Unmanaged mci version, set minimum capabilities\n" );break ; --
Quoted 2 lines
1.8.3.1
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel