watchdog/hpwdt: Assign boolean values to a bool variable
PATCH 1/1 watchdog/hpwdt: Assign boolean values to a bool variable
Fix the following coccicheck warnings:
./drivers/watchdog/hpwdt.c:345:2-12: WARNING: Assignment of
0/1 to bool variable.
./drivers/watchdog/hpwdt.c:126:2-12: WARNING: Assignment of 0/1 to bool variable.
--- drivers/watchdog/hpwdt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/watchdog/hpwdt.c +3 -3
@@ -123,7 +123,7 @@ static int hpwdt_settimeout(struct watchdog_device *wdd, unsigned int val)if (val <= wdd->pretimeout) {dev_dbg (wdd->parent,"pretimeout < timeout. Setting to zero\n" ); wdd->pretimeout =0 ; - pretimeout =0 ; + pretimeout = false;if (watchdog_active (wdd))hpwdt_start (wdd); }
@@ -336,13 +336,13 @@ static int hpwdt_init_one(struct pci_dev *dev,watchdog_init_timeout (&hpwdt_dev, soft_margin,NULL );if (is_kdump_kernel ()) { - pretimeout =0 ; + pretimeout = false; kdumptimeout =0 ; }if (pretimeout && hpwdt_dev.timeout <=PRETIMEOUT_SEC ) {dev_warn (&dev->dev,"timeout <= pretimeout. Setting pretimeout to zero\n" ); - pretimeout =0 ; + pretimeout = false; } hpwdt_dev.pretimeout = pretimeout ?PRETIMEOUT_SEC :0 ; kdumptimeout =min (kdumptimeout,HPWDT_MAX_TIMER );
Signature · 1 line
1.8.3.1
Quoted 5 lines · Jiapeng Zhong
Fix the following coccicheck warnings:
./drivers/watchdog/hpwdt.c:345:2-12: WARNING: Assignment of
0/1 to bool variable.
Quoted 8 lines
./drivers/watchdog/hpwdt.c:126:2-12: WARNING: Assignment of 0/1 to bool variable.
Reported-by Abaci Robot <[email protected]>Signed-off-by Jiapeng Zhong <[email protected]>--- drivers/watchdog/hpwdt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 32 lines
drivers/watchdog/hpwdt.c +3
-3@@ -123,7 +123,7 @@ static int hpwdt_settimeout(struct watchdog_device *wdd, unsigned int val)if (val <= wdd->pretimeout) {dev_dbg (wdd->parent,"pretimeout < timeout. Setting to zero\n" ); wdd->pretimeout =0 ; - pretimeout =0 ; + pretimeout = false;if (watchdog_active (wdd))hpwdt_start (wdd); }@@ -336,13 +336,13 @@ static int hpwdt_init_one(struct pci_dev *dev,watchdog_init_timeout (&hpwdt_dev, soft_margin,NULL );if (is_kdump_kernel ()) { - pretimeout =0 ; + pretimeout = false; kdumptimeout =0 ; }if (pretimeout && hpwdt_dev.timeout <=PRETIMEOUT_SEC ) {dev_warn (&dev->dev,"timeout <= pretimeout. Setting pretimeout to zero\n" ); - pretimeout =0 ; + pretimeout = false; } hpwdt_dev.pretimeout = pretimeout ?PRETIMEOUT_SEC :0 ; kdumptimeout =min (kdumptimeout,HPWDT_MAX_TIMER );Signature · 1 line
1.8.3.1
Signature · 3 lines
----------------------------------------------------------------------------- Jerry Hoemann Software Engineer Hewlett Packard Enterprise -----------------------------------------------------------------------------
Quoted 10 lines · Jiapeng Zhong
Fix the following coccicheck warnings:
./drivers/watchdog/hpwdt.c:345:2-12: WARNING: Assignment of
0/1 to bool variable../drivers/watchdog/hpwdt.c:126:2-12: WARNING: Assignment of 0/1 to bool variable.
Reported-by Abaci Robot <[email protected]>Signed-off-by Jiapeng Zhong <[email protected]>
Quoted 36 lines
--- drivers/watchdog/hpwdt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/watchdog/hpwdt.c +3
-3@@ -123,7 +123,7 @@ static int hpwdt_settimeout(struct watchdog_device *wdd, unsigned int val)if (val <= wdd->pretimeout) {dev_dbg (wdd->parent,"pretimeout < timeout. Setting to zero\n" ); wdd->pretimeout =0 ; - pretimeout =0 ; + pretimeout = false;if (watchdog_active (wdd))hpwdt_start (wdd); }@@ -336,13 +336,13 @@ static int hpwdt_init_one(struct pci_dev *dev,watchdog_init_timeout (&hpwdt_dev, soft_margin,NULL );if (is_kdump_kernel ()) { - pretimeout =0 ; + pretimeout = false; kdumptimeout =0 ; }if (pretimeout && hpwdt_dev.timeout <=PRETIMEOUT_SEC ) {dev_warn (&dev->dev,"timeout <= pretimeout. Setting pretimeout to zero\n" ); - pretimeout =0 ; + pretimeout = false; } hpwdt_dev.pretimeout = pretimeout ?PRETIMEOUT_SEC :0 ; kdumptimeout =min (kdumptimeout,HPWDT_MAX_TIMER );Signature · 1 line
1.8.3.1
Quoted 5 lines · Jiapeng Zhong
Fix the following coccicheck warnings:
./drivers/watchdog/hpwdt.c:345:2-12: WARNING: Assignment of
0/1 to bool variable.
Quoted 7 lines
./drivers/watchdog/hpwdt.c:126:2-12: WARNING: Assignment of 0/1 to bool variable.
Reported-by Abaci Robot <[email protected]>Signed-off-by Jiapeng Zhong <[email protected]>Reviewed-by Jerry Hoemann <[email protected]>Reviewed-by Guenter Roeck <[email protected]>
Quoted 33 lines
--- drivers/watchdog/hpwdt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/watchdog/hpwdt.c +3
-3@@ -123,7 +123,7 @@ static int hpwdt_settimeout(struct watchdog_device *wdd, unsigned int val)if (val <= wdd->pretimeout) {dev_dbg (wdd->parent,"pretimeout < timeout. Setting to zero\n" ); wdd->pretimeout =0 ; - pretimeout =0 ; + pretimeout = false;if (watchdog_active (wdd))hpwdt_start (wdd); }@@ -336,13 +336,13 @@ static int hpwdt_init_one(struct pci_dev *dev,watchdog_init_timeout (&hpwdt_dev, soft_margin,NULL );if (is_kdump_kernel ()) { - pretimeout =0 ; + pretimeout = false; kdumptimeout =0 ; }if (pretimeout && hpwdt_dev.timeout <=PRETIMEOUT_SEC ) {dev_warn (&dev->dev,"timeout <= pretimeout. Setting pretimeout to zero\n" ); - pretimeout =0 ; + pretimeout = false; } hpwdt_dev.pretimeout = pretimeout ?PRETIMEOUT_SEC :0 ; kdumptimeout =min (kdumptimeout,HPWDT_MAX_TIMER );