Skip to contentSkip to conversation

VMCI: Stop log spew when qp allocation isn't possible

PATCH In review Jorgen Hansen 2 participants 2 messages Jan 20, 2021 – Feb 2, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/3 VMCI: Stop log spew when qp allocation isn't possible

VMCI queue pair allocation is disabled, if a VM is in FT mode. In these cases, VMware Tools may still once in a while attempt to create a vSocket stream connection, resulting in multiple warnings in the kernel logs. Therefore downgrade the error log to a debug log.

---
 drivers/misc/vmw_vmci/vmci_queue_pair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/vmw_vmci/vmci_queue_pair.c +1 -1
index c490658..a3691c1 100644
@@ -1207,7 +1207,7 @@ static int qp_alloc_guest_work(struct vmci_handle *handle,
 	} else {
 		result = qp_alloc_hypercall(queue_pair_entry);
 		if (result < VMCI_SUCCESS) {
-			pr_warn("qp_alloc_hypercall result = %d\n", result);
+			pr_devel("qp_alloc_hypercall result = %d\n", result);
 			goto error;
 		}
 	}
Signature · 6 lines
2.6.2

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
#1 lore raw
Quoted 17 lines · Jorgen Hansen

VMCI queue pair allocation is disabled, if a VM is in FT mode. In these cases, VMware Tools may still once in a while attempt to create a vSocket stream connection, resulting in multiple warnings in the kernel logs. Therefore downgrade the error log to a debug log.

---
 drivers/misc/vmw_vmci/vmci_queue_pair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/vmw_vmci/vmci_queue_pair.c +0 -0
index c490658..a3691c1 100644

drivers/misc/vmw_vmci/vmci_queue_pair.c static int qp_alloc_guest_work(struct vmci_handle *handle, · line 1210

Quoted 5 lines
drivers/misc/vmw_vmci/vmci_queue_pair.c +1 -1
@@ -1207,7 +1207,7 @@ static int qp_alloc_guest_work(struct vmci_handle *handle,
 	} else {
 		result = qp_alloc_hypercall(queue_pair_entry);
 		if (result < VMCI_SUCCESS) {
-			pr_warn("qp_alloc_hypercall result = %d\n", result);
+			pr_devel("qp_alloc_hypercall result = %d\n", result);

Hi Jorgen, recently, our customer reported that their dmesg was also swamped by the following message along with the message above.

"Could not attach to queue pair with -20"

This message was printed by vmci_transport_queue_pair_alloc(). Could we also eliminate it?

Thanks,
Firo

Quoted 10 lines
drivers/misc/vmw_vmci/vmci_queue_pair.c +0 -0
 			goto error;
 		}
 	}
Signature · 6 lines
2.6.2

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization