Skip to contentSkip to conversation

arm64: dts: qcom: sdm845-db845c: Fix reset-pin of ov8856 node

PATCH Applied Robert Foss 2 participants 2 messages Dec 21, 2020 – Jan 21, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm64: dts: qcom: sdm845-db845c: Fix reset-pin of ov8856 node

Switch reset pin of ov8856 node from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW, this issue prevented the ov8856 from probing properly as it did not respon to I2C messages.

Fixes d4919a44564b ("arm64: dts: qcom: sdm845-db845c: Add ov8856 & ov7251

camera nodes")

---

Changes since v1:
- Bjorn: Use define instead of numeral

 arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/sdm845-db845c.dts +2 -2
index 7cc236575ee2..f749672c5fdc 100644
@@ -1112,11 +1112,11 @@ camera@10 {
 		reg = <0x10>;
 
 		// CAM0_RST_N
-		reset-gpios = <&tlmm 9 0>;
+		reset-gpios = <&tlmm 9 GPIO_ACTIVE_LOW>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&cam0_default>;
 		gpios = <&tlmm 13 0>,
-			<&tlmm 9 0>;
+			<&tlmm 9 GPIO_ACTIVE_LOW>;
 
 		clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
 		clock-names = "xvclk";
Signature · 1 line
2.27.0
#1 lore raw
This patch was applied to qcom/linux.git (refs/heads/for-next):

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

Quoted 8 lines · On Mon, 21 Dec 2020 11:09:55 +0100 you wrote:

Switch reset pin of ov8856 node from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW, this issue prevented the ov8856 from probing properly as it did not respon to I2C messages.

Fixes d4919a44564b ("arm64: dts: qcom: sdm845-db845c: Add ov8856 & ov7251

camera nodes")

[...]

Here is the summary with links:
- [v2] arm64: dts: qcom: sdm845-db845c: Fix reset-pin of ov8856 node

    https://git.kernel.org/qcom/c/d4863ef399a2

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html