media: atomisp: remove redundant NULL check
Subsystems (4)
PATCH 1/1 media: atomisp: remove redundant NULL check
Fix below warnings reported by coccicheck:
./drivers/staging/media/atomisp/pci/sh_css_params.c:1575:2-8: WARNING:
NULL check before some freeing functions is not needed. ./drivers/staging/media/atomisp/pci/sh_css_params.c:3006:2-8: WARNING:
NULL check before some freeing functions is not needed.
Reported-by Abaci Robot <[email protected]>
Signed-off-by Yang Li <[email protected]>
--- drivers/staging/media/atomisp/pci/sh_css_params.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/media/atomisp/pci/sh_css_params.c +2 -4
@@ -1575,8 +1575,7 @@ struct ia_css_isp_3a_statistics_map *return me; err: -if (me) -kvfree (me); +kvfree (me);return NULL ; }
@@ -3006,8 +3005,7 @@ static void free_map(struct sh_css_ddr_address_map *map) }kvfree (params); -if (per_frame_params) -kvfree (per_frame_params); +kvfree (per_frame_params); stream->isp_params_configs =NULL ; stream->per_frame_isp_params_configs =NULL ;
Signature · 1 line
1.8.3.1
Thanks for the patch.
Feel free to add my r-b:
Reviewed-by Robert Foss <[email protected]>
Quoted 40 lines · Yang Li
Fix below warnings reported by coccicheck:
./drivers/staging/media/atomisp/pci/sh_css_params.c:1575:2-8: WARNING:
NULL check before some freeing functions is not needed. ./drivers/staging/media/atomisp/pci/sh_css_params.c:3006:2-8: WARNING:
NULL check before some freeing functions is not needed.Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>--- drivers/staging/media/atomisp/pci/sh_css_params.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/staging/media/atomisp/pci/sh_css_params.c +2
-5@@ -1575,8 +1575,7 @@ struct ia_css_isp_3a_statistics_map *return me; err: -if (me) -kvfree (me); +kvfree (me);return NULL ; }@@ -3006,8 +3005,7 @@ static void free_map(struct sh_css_ddr_address_map *map) }kvfree (params); -if (per_frame_params) -kvfree (per_frame_params); +kvfree (per_frame_params); stream->isp_params_configs =NULL ; stream->per_frame_isp_params_configs =NULL ; --1.8.3.1