media: atomisp: remove redundant NULL check
Subsystems (4)
PATCH 1/3 media: atomisp: remove redundant NULL check
Fix below warnings reported by coccicheck:
./drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c:159:4-10:
WARNING: NULL check before some freeing functions is not needed.
--- drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c +1 -2
@@ -155,8 +155,7 @@for (mem =0 ; mem <IA_CSS_NUM_MEMORIES ; mem++) {for (pclass =0 ; pclass <IA_CSS_NUM_PARAM_CLASSES ; pclass++) { -if (mem_params->params[pclass][mem].address) -kvfree (mem_params->params[pclass][mem].address); +kvfree (mem_params->params[pclass][mem].address);if (css_params->params[pclass][mem].address)hmm_free (css_params->params[pclass][mem].address); mem_params->params[pclass][mem].address =NULL ;
Signature · 1 line
1.8.3.1
PATCH 2/3 media: atomisp: remove redundant NULL check
Fix below warnings reported by coccicheck:
./drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c:390:2-8:
WARNING: NULL check before some freeing functions is not needed.
--- .../media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c +1 -2
@@ -386,8 +386,7 @@ struct ia_css_isp_dvs_statistics_map *return me; err: -if (me) -kvfree (me); +kvfree (me);return NULL ; }
Signature · 1 line
1.8.3.1
PATCH 3/3 media: atomisp: remove redundant NULL check
In reply to Yang LiFix below warnings reported by coccicheck:
./drivers/staging/media/atomisp/pci/atomisp_cmd.c:4269:2-8: WARNING:
NULL check before some freeing functions is not needed. ./drivers/staging/media/atomisp/pci/atomisp_cmd.c:4626:2-8: WARNING:
NULL check before some freeing functions is not needed.
--- drivers/staging/media/atomisp/pci/atomisp_cmd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/media/atomisp/pci/atomisp_cmd.c +2 -4
@@ -4265,8 +4265,7 @@ int atomisp_set_parameters(struct video_device *vdev, apply_parameter_failed:if (css_param)atomisp_free_css_parameters (css_param); -if (param) -kvfree (param); +kvfree (param);return ret; }
@@ -4626,8 +4625,7 @@ int atomisp_fixed_pattern(struct atomisp_sub_device *asd, int flag, err:if (ret && res)ia_css_frame_free (res); -if (tmp_buf) -vfree (tmp_buf); +vfree (tmp_buf);if (ret ==0 ) *result = res;return ret;
Signature · 1 line
1.8.3.1