Skip to contentSkip to conversation

qemu: CVE-2018-18438 Security Advisory

PATCH In review Wang Mingyu 3 participants 6 messages Jan 22, 2021 – Feb 9, 2021 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qemu: CVE-2018-18438 Security Advisory

References
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-18438

---
 meta/recipes-devtools/qemu/qemu.inc           |   1 +
 .../qemu/qemu/CVE-2018-18438.patch            | 697 ++++++++++++++++++
 2 files changed, 698 insertions(+)
 create mode 100644 meta/recipes-devtools/qemu/qemu/CVE-2018-18438.patch
meta/recipes-devtools/qemu/qemu.inc +1 -0
index c894b81b10..d7f3613c3f 100644
@@ -30,6 +30,7 @@ SRC_URI = "https://download.qemu.org/${BPN}-${PV}.tar.xz \
            file://mmap.patch \
            file://mmap2.patch \
            file://0001-tests-meson.build-use-relative-path-to-refer-to-file.patch \
+	   file://CVE-2018-18438.patch \
            "
 UPSTREAM_CHECK_REGEX = "qemu-(?P<pver>\d+(\.\d+)+)\.tar"
 
meta/recipes-devtools/qemu/qemu/CVE-2018-18438.patch new file +697 -0

697 lines not on this page · raw message

Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 socat: upgrade 1.7.3.4 ->1.7.4.1

README updated:
version updated
add descrition of platform specifics - Debian

---
 .../socat/{socat_1.7.3.4.bb => socat_1.7.4.1.bb}            | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
 rename meta/recipes-connectivity/socat/{socat_1.7.3.4.bb => socat_1.7.4.1.bb} (90%)
meta/recipes-connectivity/socat/socat_1.7.4.1.bb renamed from meta/recipes-connectivity/socat/socat_1.7.3.4.bb +3 -3
similarity index 90%
rename from meta/recipes-connectivity/socat/socat_1.7.3.4.bb
rename to meta/recipes-connectivity/socat/socat_1.7.4.1.bb
index f3f569d262..5a13af91bc 100644
@@ -7,13 +7,13 @@ SECTION = "console/network"
 
 LICENSE = "GPL-2.0-with-OpenSSL-exception"
 LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
-                    file://README;beginline=257;endline=287;md5=338c05eadd013872abb1d6e198e10a3f"
+                    file://README;beginline=257;endline=287;md5=82520b052f322ac2b5b3dfdc7c7eea86"
 
 SRC_URI = "http://www.dest-unreach.org/socat/download/socat-${PV}.tar.bz2 \
 "
 
-SRC_URI[md5sum] = "3cca4f8cd9d2d1caabd9cc099451bac9"
-SRC_URI[sha256sum] = "972374ca86f65498e23e3259c2ee1b8f9dbeb04d12c2a78c0c9b5d1cb97dfdfc"
+SRC_URI[md5sum] = "36cad050ecf4981ab044c3fbd75c643f"
+SRC_URI[sha256sum] = "3faca25614e89123dff5045680549ecef519d02e331aaf3c4f5a8f6837c675e9"
 
 inherit autotools
 
Signature · 1 line
2.25.1
#2 lore raw
In reply to Wang Mingyu
Quoted 35 lines · Wang Mingyu

References
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-18438

---
 meta/recipes-devtools/qemu/qemu.inc | 1 +
 .../qemu/qemu/CVE-2018-18438.patch | 697 ++++++++++++++++++

 2 files changed, 698 insertions(+)

 create mode 100644 meta/recipes-devtools/qemu/qemu/CVE-2018-18438.patch

meta/recipes-devtools/qemu/qemu.inc +1 -0
index c894b81b10..d7f3613c3f 100644
@@ -30,6 +30,7 @@ SRC_URI = "https://download.qemu.org/${BPN}-${PV}.tar.xz \
             file://mmap.patch \
             file://mmap2.patch \
             file://0001-tests-meson.build-use-relative-path-to-refer-to-file.patch \
+	   file://CVE-2018-18438.patch \

            "
 UPSTREAM_CHECK_REGEX = "qemu-(?P<pver>\d+(\.\d+)+)\.tar"

meta/recipes-devtools/qemu/qemu/CVE-2018-18438.patch new file +0 -0
new file mode 100644
index 0000000000..b6ce8fa57d

meta/recipes-devtools/qemu/qemu/CVE-2018-18438.patch line 9

Quoted 9 lines
meta/recipes-devtools/qemu/qemu/CVE-2018-18438.patch new file +9 -0
@@ -0,0 +1,697 @@
+From:	Philippe Mathieu-Daudé
+Subject:	[Qemu-devel] [PATCH v2 07/11] chardev: Let IOReadHandler use unsigned type
+Date:	Fri, 12 Oct 2018 02:22:13 +0200
+
+The number of bytes can not be negative nor zero.
+
+Fixed 2 format string:
+- hw/char/spapr_vty.c
+- hw/usb/ccid-card-passthru.c

No Upstream-Status.

Its also unclear what the status of these patches is upstream, they're submitted, there was discussion but they weren't merged. I'm also wondering whether there are more of the 11 patches in the series needed to address the issue? Or perhaps the issue was ultimately addressed by other patches?

Cheers,

Richard

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 20 lines · Richard Purdie via lists.openembedded.org
Quoted 7 lines · Wang Mingyu
meta/recipes-devtools/qemu/qemu/CVE-2018-18438.patch new file +0 -0
new file mode 100644
index 0000000000..b6ce8fa57d

meta/recipes-devtools/qemu/qemu/CVE-2018-18438.patch line 9

Quoted 9 lines
meta/recipes-devtools/qemu/qemu/CVE-2018-18438.patch new file +9 -0
@@ -0,0 +1,697 @@
+From:	Philippe Mathieu-Daudé
+Subject:	[Qemu-devel] [PATCH v2 07/11] chardev: Let IOReadHandler use unsigned type
+Date:	Fri, 12 Oct 2018 02:22:13 +0200
+
+The number of bytes can not be negative nor zero.
+
+Fixed 2 format string:
+- hw/char/spapr_vty.c
+- hw/usb/ccid-card-passthru.c

No Upstream-Status.

Quoted 5 lines

Its also unclear what the status of these patches is upstream, they're submitted, there was discussion but they weren't merged. I'm also wondering whether there are more of the 11 patches in the series needed to address the issue? Or perhaps the issue was ultimately addressed by other patches?

I went digging and was pointed to

https://bugzilla.redhat.com/show_bug.cgi?id=1609015

i.e. qemu upstream and Redhat believe this is not an issue

Steve: What do we do here? Whitelist? Do we report upstream somehow?

Cheers,

Richard

#5 lore raw

Hi Richard,

Quoted 3 lines

I went digging and was pointed to

https://bugzilla.redhat.com/show_bug.cgi?id=1609015

In the discussion, "patches were applied upstream to prevent future changes introducing such flames" was explained. It seems that CVE doesn't think this is a problem, but the upstream still applied this patch.
In this case, is it need to submit CVE patch? Or submit it as a normal patch?

Best regards,
Wangmy

Quoted 52 lines

-----Original Message-----
From: Richard Purdie <[email protected]>
Sent: Friday, January 22, 2021 10:06 PM
To: Wang, Mingyu/王 鸣瑜 <[email protected]>; [email protected]
Cc: Steve Sakoman <[email protected]>; Ross Burton <[email protected]>
Subject: Re: [OE-core] [PATCH] qemu: CVE-2018-18438 Security Advisory

Quoted 11 lines · Richard Purdie via lists.openembedded.org

meta/recipes-devtools/qemu/qemu/CVE-2018-18438.patch line 2

Quoted 10 lines · Wang Mingyu
meta/recipes-devtools/qemu/qemu/CVE-2018-18438.patch new file +2 -0
new file mode 100644
index 0000000000..b6ce8fa57d
@@ -0,0 +1,697 @@
+From:	Philippe Mathieu-Daudé
+Subject:	[Qemu-devel] [PATCH v2 07/11] chardev: Let IOReadHandler

use unsigned type

Quoted 10 lines

meta/recipes-devtools/qemu/qemu/CVE-2018-18438.patch line 9

Quoted 7 lines
meta/recipes-devtools/qemu/qemu/CVE-2018-18438.patch new file +7 -0
+Date:	Fri, 12 Oct 2018 02:22:13 +0200
+
+The number of bytes can not be negative nor zero.
+
+Fixed 2 format string:
+- hw/char/spapr_vty.c
+- hw/usb/ccid-card-passthru.c

No Upstream-Status.

Quoted 5 lines

Its also unclear what the status of these patches is upstream, they're submitted, there was discussion but they weren't merged. I'm also wondering whether there are more of the 11 patches in the series needed to address the issue? Or perhaps the issue was ultimately addressed by other patches?

I went digging and was pointed to

https://bugzilla.redhat.com/show_bug.cgi?id=1609015

i.e. qemu upstream and Redhat believe this is not an issue

Steve: What do we do here? Whitelist? Do we report upstream somehow?

Cheers,

Richard

#6 lore raw
In reply to Richard Purdie
Quoted 29 lines · Richard Purdie
Quoted 20 lines · Richard Purdie via lists.openembedded.org
Quoted 7 lines · Wang Mingyu
meta/recipes-devtools/qemu/qemu/CVE-2018-18438.patch new file +0 -0
new file mode 100644
index 0000000000..b6ce8fa57d

meta/recipes-devtools/qemu/qemu/CVE-2018-18438.patch line 9

Quoted 9 lines
meta/recipes-devtools/qemu/qemu/CVE-2018-18438.patch new file +9 -0
@@ -0,0 +1,697 @@
+From:      Philippe Mathieu-Daudé
+Subject:   [Qemu-devel] [PATCH v2 07/11] chardev: Let IOReadHandler use unsigned type
+Date:      Fri, 12 Oct 2018 02:22:13 +0200
+
+The number of bytes can not be negative nor zero.
+
+Fixed 2 format string:
+- hw/char/spapr_vty.c
+- hw/usb/ccid-card-passthru.c

No Upstream-Status.

Quoted 5 lines

Its also unclear what the status of these patches is upstream, they're submitted, there was discussion but they weren't merged. I'm also wondering whether there are more of the 11 patches in the series needed to address the issue? Or perhaps the issue was ultimately addressed by other patches?

Quoted 7 lines

I went digging and was pointed to

https://bugzilla.redhat.com/show_bug.cgi?id=1609015

i.e. qemu upstream and Redhat believe this is not an issue

Steve: What do we do here? Whitelist? Do we report upstream somehow?

I'll email the database maintainers and see how they want to handle this. If they won't do anything then we should perhaps whitelist - I don't think we should apply patches that weren't merged upstream.

Steve