Skip to contentSkip to conversation

workqueue: Use %s instead of function name

PATCH Applied Stephen Zhang 2 participants 2 messages Jan 23, 2021 – Jan 27, 2021 Workqueue

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 workqueue: Use %s instead of function name

It is better to replace the function name with %s, in case the function name changes.

---
 kernel/workqueue.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/workqueue.c +2 -2
index 9880b6c..8b1b616 100644
@@ -2964,8 +2964,8 @@ void drain_workqueue(struct workqueue_struct *wq)
 
 		if (++flush_cnt == 10 ||
 		    (flush_cnt % 100 == 0 && flush_cnt <= 1000))
-			pr_warn("workqueue %s: drain_workqueue() isn't complete after %u tries\n",
-				wq->name, flush_cnt);
+			pr_warn("workqueue %s: %s() isn't complete after %u tries\n",
+				wq->name, __func__, flush_cnt);
 
 		mutex_unlock(&wq->mutex);
 		goto reflush;
Signature · 1 line
1.8.3.1
maintainer Applied
#1 lore raw
Quoted 4 lines · Stephen Zhang

It is better to replace the function name with %s, in case the function name changes.

Applied to wq/for-5.12.

Thanks.

Signature · 1 line
tejun