blkcg: delete redundant get/put operations for queue
Subsystems (2)
PATCH RESEND 1/1 blkcg: delete redundant get/put operations for queue
From: Chunguang Xu <[email protected]>
When calling blkcg_schedule_throttle(), for the same queue, redundant get/put operations can be removed.
Signed-off-by Chunguang Xu <[email protected]>
Acked-by Tejun Heo <[email protected]>
--- block/blk-cgroup.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)
block/blk-cgroup.c +8 -5
@@ -1757,12 +1757,15 @@ void blkcg_schedule_throttle(struct request_queue *q, bool use_memdelay)if (unlikely (current->flags &PF_KTHREAD ))return ; -if (!blk_get_queue (q)) -return ; +if (current->throttle_queue != q) { +if (!blk_get_queue (q)) +return ; + +if (current->throttle_queue) +blk_put_queue (current->throttle_queue); + current->throttle_queue = q; + } -if (current->throttle_queue) -blk_put_queue (current->throttle_queue); - current->throttle_queue = q;if (use_memdelay) current->use_memdelay = use_memdelay;set_notify_resume (current);
Signature · 1 line
1.8.3.1
Quoted 4 lines · Chunguang Xu
From: Chunguang Xu <[email protected]>
When calling
blkcg_schedule_throttle(), for the same queue, redundant get/put operations can be removed.
Applied, thanks.
Signature · 1 line
Jens Axboe