Skip to contentSkip to conversation

scsi: qla2xxx: Simplify the calculation of variables

PATCH Applied Jiapeng Zhong 3 participants 3 messages Jan 26, 2021 – Jan 29, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: qla2xxx: Simplify the calculation of variables

Fix the following coccicheck warnings:

./drivers/scsi/qla2xxx/qla_nvme.c:288:24-26: WARNING !A || A && B is equivalent to !A || B.

---
 drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_nvme.c +1 -1
index eab559b..38196b2 100644
@@ -285,7 +285,7 @@ static int qla_nvme_ls_req(struct nvme_fc_local_port *lport,
 	srb_t           *sp;
 
 
-	if (!fcport || (fcport && fcport->deleted))
+	if (!fcport || fcport->deleted)
 		return rval;
 
 	vha = fcport->vha;
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 31 lines · Jiapeng Zhong

Fix the following coccicheck warnings:

./drivers/scsi/qla2xxx/qla_nvme.c:288:24-26: WARNING !A || A && B is equivalent to !A || B.

---
drivers/scsi/qla2xxx/qla_nvme.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_nvme.c +1 -1
index eab559b..38196b2 100644
@@ -285,7 +285,7 @@ static int qla_nvme_ls_req(struct nvme_fc_local_port *lport,
 	srb_t           *sp;
 
 
-	if (!fcport || (fcport && fcport->deleted))
+	if (!fcport || fcport->deleted)
 		return rval;
 
 	vha = fcport->vha;
Signature · 1 line
1.8.3.1

--
Himanshu Madhani Oracle Linux Engineering

#2 lore raw
In reply to Jiapeng Zhong

Jiapeng,

Quoted 4 lines

Fix the following coccicheck warnings:

./drivers/scsi/qla2xxx/qla_nvme.c:288:24-26: WARNING !A || A && B is equivalent to !A || B.

Applied to 5.12/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering