Skip to contentSkip to conversation

s390: Simplify the calculation of variables

PATCH New Jiapeng Zhong 1 participant 1 message Jan 26, 2021 s390

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390: Simplify the calculation of variables

Fix the following coccicheck warnings:

./arch/s390/include/asm/scsw.h:528:48-50: WARNING !A || A && B is equivalent to !A || B.

---
 arch/s390/include/asm/scsw.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/s390/include/asm/scsw.h +1 -2
index c00f7b0..a7c3ccf 100644
@@ -525,8 +525,7 @@ static inline int scsw_cmd_is_valid_pno(union scsw *scsw)
 	return (scsw->cmd.fctl != 0) &&
 	       (scsw->cmd.stctl & SCSW_STCTL_STATUS_PEND) &&
 	       (!(scsw->cmd.stctl & SCSW_STCTL_INTER_STATUS) ||
-		 ((scsw->cmd.stctl & SCSW_STCTL_INTER_STATUS) &&
-		  (scsw->cmd.actl & SCSW_ACTL_SUSPENDED)));
+		  (scsw->cmd.actl & SCSW_ACTL_SUSPENDED));
 }
 
 /**
Signature · 1 line
1.8.3.1