Skip to contentSkip to conversation

util-linux: enable AUTORECONF

PATCH New Rahul Bedarkar 3 participants 4 messages Feb 10, 2017 – Feb 11, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 util-linux: enable AUTORECONF

Commit 55a9737895cb ("util-linux: link scriptreplay with libm (for isnan)") added two patches that touch configure.ac and Makemodule.am. But forgot to enable AUTORECONF.

When AUTORECONF is disabled and configure.ac is patched, it looks like make will detect change in timestamps and trigger reconfig. But it later fails because of missing dependencies. To fix this, explicitly enable AUTORECONF.

Fixes:
http://autobuild.buildroot.net/results/544/544e8da290d40424ea3d1bffad7e0b8a566de495

Fixes 55a9737895cb ("util-linux: link scriptreplay with libm (for isnan)")
Cc Carlos Santos <[email protected]>
---
 package/util-linux/util-linux.mk | 3 +++
 1 file changed, 3 insertions(+)
package/util-linux/util-linux.mk +3 -0
index 84c4f0e..441c252 100644
@@ -8,6 +8,9 @@ UTIL_LINUX_VERSION_MAJOR = 2.29
 UTIL_LINUX_VERSION = $(UTIL_LINUX_VERSION_MAJOR).1
 UTIL_LINUX_SOURCE = util-linux-$(UTIL_LINUX_VERSION).tar.xz
 UTIL_LINUX_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/util-linux/v$(UTIL_LINUX_VERSION_MAJOR)
+# For 0001-build-sys-use-lm-for-scriptreplay-if-necessary.patch and
+# 0002-build-sys-improve-detection-of-the-isnan-function-in.patch
+UTIL_LINUX_AUTORECONF = YES
 
 # README.licensing claims that some files are GPLv2-only, but this is not true.
 # Some files are GPLv3+ but only in tests.
Signature · 1 line
2.6.2
#1 lore raw

PATCH 1/1 util-linux: enable AUTORECONF

Quoted 38 lines

From: "Rahul Bedarkar" <[email protected]>
To: buildroot at buildroot.org
Cc: "Rahul Bedarkar" <[email protected]>, "Carlos Santos" <[email protected]>
Sent: Friday, February 10, 2017 12:01:40 PM
Subject: [PATCH] util-linux: enable AUTORECONF

Commit 55a9737895cb ("util-linux: link scriptreplay with libm (for isnan)") added two patches that touch configure.ac and Makemodule.am. But forgot to enable AUTORECONF.

When AUTORECONF is disabled and configure.ac is patched, it looks like make will detect change in timestamps and trigger reconfig. But it later fails because of missing dependencies. To fix this, explicitly enable AUTORECONF.

Fixes:
http://autobuild.buildroot.net/results/544/544e8da290d40424ea3d1bffad7e0b8a566de495

Fixes 55a9737895cb ("util-linux: link scriptreplay with libm (for isnan)")
Cc Carlos Santos <[email protected]>

---
package/util-linux/util-linux.mk | 3 +++

1 file changed, 3 insertions(+)
package/util-linux/util-linux.mk +0 -0
index 84c4f0e..441c252 100644
@@ -8,6 +8,9 @@ UTIL_LINUX_VERSION_MAJOR = 2.29

UTIL_LINUX_VERSION = $(UTIL_LINUX_VERSION_MAJOR).1 UTIL_LINUX_SOURCE = util-linux-$(UTIL_LINUX_VERSION).tar.xz UTIL_LINUX_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/util-linux/v$(UTIL_LINUX_VERSION_MAJOR)

package/util-linux/util-linux.mk +3 -0
+# For 0001-build-sys-use-lm-for-scriptreplay-if-necessary.patch and
+# 0002-build-sys-improve-detection-of-the-isnan-function-in.patch
+UTIL_LINUX_AUTORECONF = YES
Quoted 4 lines

# README.licensing claims that some files are GPLv2-only, but this is not true. # Some files are GPLv3+ but only in tests.
--
2.6.2

I'd prefer to avoid autoreconf but looks like it is required, so,

I was unable to reproduce 544e8da290d40424ea3d1bffad7e0b8a566de495 on my machine (Fedora release 24). It can be related to the build environment.

In principle autoreconf is harmless but it adds around 10 seconds of build time and 10 seconds more for host tools (host-{libtool,autoconf,automake}).

Carlos Santos (Casantos) - DATACOM, P&D
?Something must be done. This is something. Therefore we must do it.? (from the BBC series ?Yes, Prime Minister?, ?Power to the people?)

#2 lore raw

PATCH 1/1 util-linux: enable AUTORECONF

Quoted 24 lines

From: "Carlos Santos" <[email protected]>
To: "Rahul Bedarkar" <[email protected]>
Cc: buildroot at buildroot.org
Sent: Friday, February 10, 2017 1:16:08 PM
Subject: Re: [Buildroot] [PATCH] util-linux: enable AUTORECONF

Quoted 18 lines

From: "Rahul Bedarkar" <[email protected]>
To: buildroot at buildroot.org
Cc: "Rahul Bedarkar" <[email protected]>, "Carlos Santos" <[email protected]>
Sent: Friday, February 10, 2017 12:01:40 PM
Subject: [PATCH] util-linux: enable AUTORECONF

Commit 55a9737895cb ("util-linux: link scriptreplay with libm (for isnan)") added two patches that touch configure.ac and Makemodule.am. But forgot to enable AUTORECONF.

When AUTORECONF is disabled and configure.ac is patched, it looks like make will detect change in timestamps and trigger reconfig. But it later fails because of missing dependencies. To fix this, explicitly enable AUTORECONF.

Fixes:
http://autobuild.buildroot.net/results/544/544e8da290d40424ea3d1bffad7e0b8a566de495

[...]

Quoted 7 lines

I'd prefer to avoid autoreconf but looks like it is required, so,

I was unable to reproduce 544e8da290d40424ea3d1bffad7e0b8a566de495 on my machine (Fedora release 24). It can be related to the build environment.

Mystery solved: automake is installed on my machine, so /usr/bin/aclocal-1.15 is used when host-automake is not built.

Carlos Santos (Casantos) - DATACOM, P&D
?Something must be done. This is something. Therefore we must do it.? (from the BBC series ?Yes, Prime Minister?, ?Power to the people?)

#3 lore raw

PATCH 1/1 util-linux: enable AUTORECONF

In reply to Rahul Bedarkar

Hello,

Quoted 12 lines · Rahul Bedarkar

Commit 55a9737895cb ("util-linux: link scriptreplay with libm (for isnan)") added two patches that touch configure.ac and Makemodule.am. But forgot to enable AUTORECONF.

When AUTORECONF is disabled and configure.ac is patched, it looks like make will detect change in timestamps and trigger reconfig. But it later fails because of missing dependencies. To fix this, explicitly enable AUTORECONF.

Fixes:
http://autobuild.buildroot.net/results/544/544e8da290d40424ea3d1bffad7e0b8a566de495

Quoted 6 lines
Fixes 55a9737895cb ("util-linux: link scriptreplay with libm (for isnan)")
Cc Carlos Santos <[email protected]>
---
 package/util-linux/util-linux.mk | 3 +++
 1 file changed, 3 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com