Skip to contentSkip to conversation

vfs: getname() / putname() used by VMware drivers

DISCUSSION Thomas Jarosch 4 participants 7 messages Sep 12, 2014 – Sep 18, 2014 VFS

lore
Share & tools
lore
#0 lore raw

Hi Jeff,

I just compiled the VMware kernel modules 9.4.6-1770165 on kernel 3.14.18 (upgrading from 3.4.101).

The functions getname() and putname() are both used by the "vmblock" and "vmsync" module.

Any chance to revert 8e377d15078a501c4da98471f56396343c407d92
---------------------------------------
vfs: unexport getname and putname symbols

I see no callers in module code.
---------------------------------------

since there are callers to those functions?

Otherwise the VMware code needs to be changed downstream. For now I've reverted the commit in question locally.

Cheers,
Thomas

#1 lore raw
Quoted 11 lines · Thomas Jarosch

Hi Jeff,

I just compiled the VMware kernel modules 9.4.6-1770165 on kernel 3.14.18 (upgrading from 3.4.101).

The functions getname() and putname() are both used by the "vmblock" and "vmsync" module.

Any chance to revert 8e377d15078a501c4da98471f56396343c407d92
---------------------------------------
vfs: unexport getname and putname symbols

No. that was intentional an no module should use them.

#2 lore raw
In reply to Thomas Jarosch
Quoted 15 lines · On Fri, 12 Sep 2014 15:57:39 +0200 Thomas Jarosch…

Hi Jeff,

I just compiled the VMware kernel modules 9.4.6-1770165 on kernel 3.14.18 (upgrading from 3.4.101).

The functions getname() and putname() are both used by the "vmblock" and "vmsync" module.

Any chance to revert 8e377d15078a501c4da98471f56396343c407d92
---------------------------------------
vfs: unexport getname and putname symbols

I see no callers in module code.
---------------------------------------

Quoted 8 lines

since there are callers to those functions?

Otherwise the VMware code needs to be changed downstream. For now I've reverted the commit in question locally.

Cheers,
Thomas

(I've left Red Hat so the redhat.com address no longer works)

As Christoph says...no, there's no way that we'll revert that.

Those functions have hooks into the audit layer and 3rd party modules almost universally got their usage wrong.

Signature · 1 line
Jeff Layton <[email protected]>
#3 lore raw

Hi Jeff,

Quoted 21 lines · On Friday, 12. September 2014 22:12:08 Jeff Layton wrote:
Quoted 13 lines

I just compiled the VMware kernel modules 9.4.6-1770165 on kernel 3.14.18 (upgrading from 3.4.101).

The functions getname() and putname() are both used by the "vmblock" and "vmsync" module.

Any chance to revert 8e377d15078a501c4da98471f56396343c407d92
---------------------------------------
vfs: unexport getname and putname symbols

I see no callers in module code.
---------------------------------------

Quoted 7 lines

since there are callers to those functions?

Otherwise the VMware code needs to be changed downstream. For now I've reverted the commit in question locally.

Cheers,
Thomas

Quoted 6 lines

(I've left Red Hat so the redhat.com address no longer works)

As Christoph says...no, there's no way that we'll revert that.

Those functions have hooks into the audit layer and 3rd party modules almost universally got their usage wrong.

thanks for the explanation, especially about the audit layer part.

Let's see if Dmitry still works for VMware as the @vmware.com address bounces. Adding CC: to Dyno and Dmitry (another address).

Cheers,
Thomas

#4 lore raw
Quoted 24 lines · Thomas Jarosch

Hi Jeff,

Quoted 21 lines · On Friday, 12. September 2014 22:12:08 Jeff Layton wrote:
Quoted 20 lines

I just compiled the VMware kernel modules 9.4.6-1770165 on kernel 3.14.18 (upgrading from 3.4.101).

The functions getname() and putname() are both used by the "vmblock" and "vmsync" module.

Any chance to revert 8e377d15078a501c4da98471f56396343c407d92
---------------------------------------
vfs: unexport getname and putname symbols

I see no callers in module code.
---------------------------------------

since there are callers to those functions?

Otherwise the VMware code needs to be changed downstream. For now I've reverted the commit in question locally.

Cheers,
Thomas

Quoted 9 lines
Quoted 6 lines

(I've left Red Hat so the redhat.com address no longer works)

As Christoph says...no, there's no way that we'll revert that.

Those functions have hooks into the audit layer and 3rd party modules almost universally got their usage wrong.

thanks for the explanation, especially about the audit layer part.

You do not need neither vmsync nor vmblock on kernels past 3.0 so just hack around vmware-coonfig-tools.pl (or whatever the install script is called) and do not compile them.

Hi Thomas,
Thanks.

Signature · 1 line
Dmitry
#5 lore raw

Hi Dmitry,

Quoted 10 lines · On Monday, 15. September 2014 08:28:33 Dmitry Torokhov wrote:
Quoted 6 lines
Quoted 4 lines

As Christoph says...no, there's no way that we'll revert that.

Those functions have hooks into the audit layer and 3rd party modules almost universally got their usage wrong.

thanks for the explanation, especially about the audit layer part.

You do not need neither vmsync nor vmblock on kernels past 3.0 so just hack around vmware-coonfig-tools.pl (or whatever the install script is called) and do not compile them.

thanks for the hint, that makes things a lot easier.

Probably a lot of people on the web could stop to publish compiling-but-more-or-less-working patches to port those modules to recent kernels ;)

Thanks again,
Thomas

#6 lore raw
Quoted 14 lines · Thomas Jarosch

Hi Dmitry,

Quoted 10 lines · On Monday, 15. September 2014 08:28:33 Dmitry Torokhov wrote:
Quoted 6 lines
Quoted 4 lines

As Christoph says...no, there's no way that we'll revert that.

Those functions have hooks into the audit layer and 3rd party modules almost universally got their usage wrong.

thanks for the explanation, especially about the audit layer part.

You do not need neither vmsync nor vmblock on kernels past 3.0 so just hack around vmware-coonfig-tools.pl (or whatever the install script is called) and do not compile them.

Quoted 5 lines

thanks for the hint, that makes things a lot easier.

Probably a lot of people on the web could stop to publish compiling-but-more-or-less-working patches to port those modules to recent kernels ;)

Yeah. Well, it is hard for VMware to go back and adjust already released tools packages ;). I believe this issue is fixed in newer versions and in open-vm-tools.

BTW, more and more distributions package open-vm-tools and I believe most of the needed kernel drivers are now in mainline so things should be getting better.

Thanks.

Signature · 1 line
Dmitry