Skip to contentSkip to conversation

mmc: mmc_spi: Print verbose debug output when crc16 check fails

PATCH Superseded Bin Meng 2 participants 4 messages Feb 2, 2021 – Feb 16, 2021 MMC, SD and SDIO

lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH v3 1/1 mmc: mmc_spi: Print verbose debug output when crc16 check fails

Add some verbose debug output when crc16 check fails.

---

Changes in v3:
- use expected/got instead of expect/get

Changes in v2:
- do the crc_ok assignment at the the same line where it's defined

 drivers/mmc/mmc_spi.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/mmc/mmc_spi.c +4 -2
index 46800bb..23b9073 100644
@@ -181,8 +181,10 @@ static int mmc_spi_readdata(struct udevice *dev,
 			if (ret)
 				return ret;
 #ifdef CONFIG_MMC_SPI_CRC_ON
-			if (be16_to_cpu(crc16_ccitt(0, buf, bsize)) != crc) {
-				debug("%s: data crc error\n", __func__);
+			u16 crc_ok = be16_to_cpu(crc16_ccitt(0, buf, bsize));
+			if (crc_ok != crc) {
+				debug("%s: data crc error, expected %04x got %04x\n",
+				      __func__, crc_ok, crc);
 				r1 = R1_SPI_COM_CRC;
 				break;
 			}
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH v3 1/1 mmc: mmc_spi: Print verbose debug output when crc16 check fails

Quoted 8 lines · Bin Meng

Add some verbose debug output when crc16 check fails.

---

Quoted 9 lines

Changes in v3:
- use expected/got instead of expect/get

Changes in v2:
- do the crc_ok assignment at the the same line where it's defined

 drivers/mmc/mmc_spi.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Peng, ping?

#2 lore raw

PATCH v3 1/1 mmc: mmc_spi: Print verbose debug output when crc16 check fails

Quoted 15 lines

Subject: Re: [PATCH v3] mmc: mmc_spi: Print verbose debug output when crc16 check fails

Quoted 11 lines · Bin Meng

Add some verbose debug output when crc16 check fails.

---

Changes in v3:
- use expected/got instead of expect/get

Quoted 8 lines
Quoted 6 lines

Changes in v2:
- do the crc_ok assignment at the the same line where it's defined

 drivers/mmc/mmc_spi.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Peng, ping?

Sorry for delay, I'll take it and PR in next week.

Regards,
Peng.

author
#3 lore raw

PATCH v3 1/1 mmc: mmc_spi: Print verbose debug output when crc16 check fails

Quoted 19 lines · Peng Fan
Quoted 19 lines

Subject: Re: [PATCH v3] mmc: mmc_spi: Print verbose debug output when crc16 check fails

Quoted 14 lines · Bin Meng

Add some verbose debug output when crc16 check fails.

---

Changes in v3:
- use expected/got instead of expect/get

Changes in v2:
- do the crc_ok assignment at the the same line where it's defined

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
 drivers/mmc/mmc_spi.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Peng, ping?

Sorry for delay, I'll take it and PR in next week.

Ping?