Skip to contentSkip to conversation

drivers: nvmem: Fix voltage settings for QTI qfprom-efuse

PATCH In review Ravi Kumar Bokka 4 participants 4 messages Feb 5, 2021 – Mar 25, 2021 NVMEM framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: nvmem: Fix voltage settings for QTI qfprom-efuse

QFPROM controller hardware requires 1.8V min for fuse blowing. So, this change sets the voltage to 1.8V, required to blow the fuse for qfprom-efuse controller.

To disable fuse blowing, we set the voltage to 0V since this may be a shared rail and may be able to run at a lower rate when we're not blowing fuses.

Fixes 93b4e49f8c86 ("nvmem: qfprom: Add fuse blowing support")
---
 drivers/nvmem/qfprom.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
drivers/nvmem/qfprom.c +21 -0
index 6cace24..100d69d 100644
@@ -127,6 +127,16 @@ static void qfprom_disable_fuse_blowing(const struct qfprom_priv *priv,
 {
 	int ret;
 
+	/*
+	 * This may be a shared rail and may be able to run at a lower rate
+	 * when we're not blowing fuses.  At the moment, the regulator framework
+	 * applies voltage constraints even on disabled rails, so remove our
+	 * constraints and allow the rail to be adjusted by other users.
+	 */
+	ret = regulator_set_voltage(priv->vcc, 0, INT_MAX);
+	if (ret)
+		dev_warn(priv->dev, "Failed to set 0 voltage (ignoring)\n");
+
 	ret = regulator_disable(priv->vcc);
 	if (ret)
 		dev_warn(priv->dev, "Failed to disable regulator (ignoring)\n");
@@ -172,6 +182,17 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv,
 		goto err_clk_prepared;
 	}
 
+	/*
+	 * Hardware requires 1.8V min for fuse blowing; this may be
+	 * a rail shared do don't specify a max--regulator constraints
+	 * will handle.
+	 */
+	ret = regulator_set_voltage(priv->vcc, 1800000, INT_MAX);
+	if (ret) {
+		dev_err(priv->dev, "Failed to set 1.8 voltage\n");
+		goto err_clk_rate_set;
+	}
+
 	ret = regulator_enable(priv->vcc);
 	if (ret) {
 		dev_err(priv->dev, "Failed to enable regulator\n");
Signature · 1 line
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by the Linux Foundation.
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 22 lines · Ravi Kumar Bokka

QFPROM controller hardware requires 1.8V min for fuse blowing. So, this change sets the voltage to 1.8V, required to blow the fuse for qfprom-efuse controller.

To disable fuse blowing, we set the voltage to 0V since this may be a shared rail and may be able to run at a lower rate when we're not blowing fuses.

Fixes 93b4e49f8c86 ("nvmem: qfprom: Add fuse blowing support")
---
 drivers/nvmem/qfprom.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
drivers/nvmem/qfprom.c +0 -0
index 6cace24..100d69d 100644

drivers/nvmem/qfprom.c static void qfprom_disable_fuse_blowing(const struct qfprom_priv *priv, · line 134

Quoted 8 lines
drivers/nvmem/qfprom.c +5 -0
@@ -127,6 +127,16 @@ static void qfprom_disable_fuse_blowing(const struct qfprom_priv *priv,
 {
        int ret;
 
+       /*
+        * This may be a shared rail and may be able to run at a lower rate
+        * when we're not blowing fuses.  At the moment, the regulator framework
+        * applies voltage constraints even on disabled rails, so remove our
+        * constraints and allow the rail to be adjusted by other users.

Some year maybe I'll try to fix the regulator framework to not count voltage constraints for disbled rails, or perhaps have it be optional. ;-) In theory it should be much easier after the patches we already landed not to count current requests for disabled rails...

Quoted 13 lines
drivers/nvmem/qfprom.c +6 -0
+        */
+       ret = regulator_set_voltage(priv->vcc, 0, INT_MAX);
+       if (ret)
+               dev_warn(priv->dev, "Failed to set 0 voltage (ignoring)\n");
+
        ret = regulator_disable(priv->vcc);
        if (ret)
                dev_warn(priv->dev, "Failed to disable regulator (ignoring)\n");
@@ -172,6 +182,17 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv,
                goto err_clk_prepared;
        }
 
+       /*

drivers/nvmem/qfprom.c static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv, · line 195

Quoted 10 lines
drivers/nvmem/qfprom.c +10 -0
+        * Hardware requires 1.8V min for fuse blowing; this may be
+        * a rail shared do don't specify a max--regulator constraints
+        * will handle.
+        */
+       ret = regulator_set_voltage(priv->vcc, 1800000, INT_MAX);
+       if (ret) {
+               dev_err(priv->dev, "Failed to set 1.8 voltage\n");
+               goto err_clk_rate_set;
+       }
+

Looks right to me. Assuming that this works.

#2 lore raw
Quoted 66 lines · Doug Anderson

Hi,

Quoted 22 lines · Ravi Kumar Bokka

QFPROM controller hardware requires 1.8V min for fuse blowing. So, this change sets the voltage to 1.8V, required to blow the fuse for qfprom-efuse controller.

To disable fuse blowing, we set the voltage to 0V since this may be a shared rail and may be able to run at a lower rate when we're not blowing fuses.

Fixes 93b4e49f8c86 ("nvmem: qfprom: Add fuse blowing support")
---
  drivers/nvmem/qfprom.c | 21 +++++++++++++++++++++
  1 file changed, 21 insertions(+)
drivers/nvmem/qfprom.c +0 -0
index 6cace24..100d69d 100644

drivers/nvmem/qfprom.c static void qfprom_disable_fuse_blowing(const struct qfprom_priv *priv, · line 134

Quoted 8 lines
drivers/nvmem/qfprom.c +5 -0
@@ -127,6 +127,16 @@ static void qfprom_disable_fuse_blowing(const struct qfprom_priv *priv,
  {
         int ret;
 
+       /*
+        * This may be a shared rail and may be able to run at a lower rate
+        * when we're not blowing fuses.  At the moment, the regulator framework
+        * applies voltage constraints even on disabled rails, so remove our
+        * constraints and allow the rail to be adjusted by other users.

Some year maybe I'll try to fix the regulator framework to not count voltage constraints for disbled rails, or perhaps have it be optional. ;-) In theory it should be much easier after the patches we already landed not to count current requests for disabled rails...

Quoted 13 lines
drivers/nvmem/qfprom.c +6 -0
+        */
+       ret = regulator_set_voltage(priv->vcc, 0, INT_MAX);
+       if (ret)
+               dev_warn(priv->dev, "Failed to set 0 voltage (ignoring)\n");
+
         ret = regulator_disable(priv->vcc);
         if (ret)
                 dev_warn(priv->dev, "Failed to disable regulator (ignoring)\n");
@@ -172,6 +182,17 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv,
                 goto err_clk_prepared;
         }
 
+       /*

drivers/nvmem/qfprom.c static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv, · line 195

Quoted 10 lines
drivers/nvmem/qfprom.c +10 -0
+        * Hardware requires 1.8V min for fuse blowing; this may be
+        * a rail shared do don't specify a max--regulator constraints
+        * will handle.
+        */
+       ret = regulator_set_voltage(priv->vcc, 1800000, INT_MAX);
+       if (ret) {
+               dev_err(priv->dev, "Failed to set 1.8 voltage\n");
+               goto err_clk_rate_set;
+       }
+

Looks right to me. Assuming that this works.

Quoted 1 line

Srini, any plans to queue this up for merge?

Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation