Skip to contentSkip to conversation

Add Gateworks Venice board support

PATCH Superseded Tim Harvey 2 participants 10 messages Feb 6, 2021 – Mar 2, 2021

Subsystems (4)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Tim Harvey

author
#0 lore raw

v2 cover Add Gateworks Venice board support

The Gateworks Venice product family consists of several boards based on the i.MX 8M Mini SoC.

A challenge I've had with this is that the board model information is stored in an I2C based EEPROM that must be read to know what PMIC is on the board in order to adjust certain power rails before DRAM init is called. I found this to be a challenge in the SPL as the SPL does not free memory thus the conceprt of calling dm_uninit() followed by dm_init_and_scan() to change dt's live in the SPL runs out of memory. Therefore I can't rely on DT/DM within the SPL for things that may differ board to board.

Best Regards,

Tim
---
v2: drop pmic patch that was already merged
add imx_tmu patch
update common/image patch as requested

Frieder Schrempf (1):
Respect that some compression algos can be enabled separately for SPL

Tim Harvey (3):
thermal: imx_tmu: enable monitoring and default alert/critical
arm: dts: imx8mm: add Gateworks i.MX8 Mini Dev kits
board: gateworks: imx8mm: Add Gateworks Venice board support

 arch/arm/dts/Makefile                            |    4 +
 arch/arm/dts/imx8mm-venice-gw700x-u-boot.dtsi    |  105 +
 arch/arm/dts/imx8mm-venice-gw700x.dtsi           |  495 +++++
 arch/arm/dts/imx8mm-venice-gw71xx-0x-u-boot.dtsi |    5 +
 arch/arm/dts/imx8mm-venice-gw71xx-0x.dts         |   19 +
 arch/arm/dts/imx8mm-venice-gw71xx.dtsi           |  186 ++
 arch/arm/dts/imx8mm-venice-gw72xx-0x-u-boot.dtsi |    5 +
 arch/arm/dts/imx8mm-venice-gw72xx-0x.dts         |   20 +
 arch/arm/dts/imx8mm-venice-gw72xx.dtsi           |  311 +++
 arch/arm/dts/imx8mm-venice-gw73xx-0x-u-boot.dtsi |    5 +
 arch/arm/dts/imx8mm-venice-gw73xx-0x.dts         |   19 +
 arch/arm/dts/imx8mm-venice-gw73xx.dtsi           |  362 ++++
 arch/arm/dts/imx8mm-venice-u-boot.dtsi           |  103 +
 arch/arm/dts/imx8mm-venice.dts                   |  152 ++
 arch/arm/mach-imx/imx8m/Kconfig                  |    9 +-
 board/gateworks/venice/Kconfig                   |   13 +
 board/gateworks/venice/MAINTAINERS               |    7 +
 board/gateworks/venice/Makefile                  |   12 +
 board/gateworks/venice/README                    |   34 +
 board/gateworks/venice/gsc.c                     |  687 ++++++
 board/gateworks/venice/gsc.h                     |   54 +
 board/gateworks/venice/imx8mm_venice.c           |  133 ++
 board/gateworks/venice/lpddr4_timing.c           | 2505 ++++++++++++++++++++++
 board/gateworks/venice/lpddr4_timing.h           |   12 +
 board/gateworks/venice/spl.c                     |  187 ++
 common/image.c                                   |   24 +-
 configs/imx8mm_venice_defconfig                  |  113 +
 drivers/thermal/imx_tmu.c                        |    6 +
 include/configs/imx8mm_venice.h                  |  125 ++
 29 files changed, 5705 insertions(+), 7 deletions(-)
 create mode 100644 arch/arm/dts/imx8mm-venice-gw700x-u-boot.dtsi
 create mode 100644 arch/arm/dts/imx8mm-venice-gw700x.dtsi
 create mode 100644 arch/arm/dts/imx8mm-venice-gw71xx-0x-u-boot.dtsi
 create mode 100644 arch/arm/dts/imx8mm-venice-gw71xx-0x.dts
 create mode 100644 arch/arm/dts/imx8mm-venice-gw71xx.dtsi
 create mode 100644 arch/arm/dts/imx8mm-venice-gw72xx-0x-u-boot.dtsi
 create mode 100644 arch/arm/dts/imx8mm-venice-gw72xx-0x.dts
 create mode 100644 arch/arm/dts/imx8mm-venice-gw72xx.dtsi
 create mode 100644 arch/arm/dts/imx8mm-venice-gw73xx-0x-u-boot.dtsi
 create mode 100644 arch/arm/dts/imx8mm-venice-gw73xx-0x.dts
 create mode 100644 arch/arm/dts/imx8mm-venice-gw73xx.dtsi
 create mode 100644 arch/arm/dts/imx8mm-venice-u-boot.dtsi
 create mode 100644 arch/arm/dts/imx8mm-venice.dts
 create mode 100644 board/gateworks/venice/Kconfig
 create mode 100644 board/gateworks/venice/MAINTAINERS
 create mode 100644 board/gateworks/venice/Makefile
 create mode 100644 board/gateworks/venice/README
 create mode 100644 board/gateworks/venice/gsc.c
 create mode 100644 board/gateworks/venice/gsc.h
 create mode 100644 board/gateworks/venice/imx8mm_venice.c
 create mode 100644 board/gateworks/venice/lpddr4_timing.c
 create mode 100644 board/gateworks/venice/lpddr4_timing.h
 create mode 100644 board/gateworks/venice/spl.c
 create mode 100644 configs/imx8mm_venice_defconfig
 create mode 100644 include/configs/imx8mm_venice.h
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH v2 1/4 thermal: imx_tmu: enable monitoring and default alert/critical

Set default critical/alert temperature and enabling monoitoring.

Without calling imx_tmu_enable_msite() monitoring will not be enabled and read_temperature will return 0. Additionally without setting alert temperature will cause imx_tmu_get_temp() to spin indefiniately thinking the system needs to cool.

This resolves the board spinning endlessly when enabling IMX_TMU in the SPL.

---
v2: added Fabio's review

---
 drivers/thermal/imx_tmu.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/thermal/imx_tmu.c +6 -0
index 1bd0340..1dada06 100644
@@ -343,6 +343,7 @@ static int imx_tmu_bind(struct udevice *dev)
 	ofnode node, offset;
 	const char *name;
 	const void *prop;
+	int minc, maxc;
 
 	debug("%s dev name %s\n", __func__, dev->name);
 
@@ -351,6 +352,10 @@ static int imx_tmu_bind(struct udevice *dev)
 		return 0;
 
 	pdata->zone_node = 1;
+	/* default alert/crit temps based on temp grade */
+	get_cpu_temp_grade(&minc, &maxc);
+	pdata->critical = maxc * 1000;
+	pdata->alert = (maxc - 10) * 1000;
 
 	node = ofnode_path("/thermal-zones");
 	ofnode_for_each_subnode(offset, node) {
@@ -442,6 +447,7 @@ static int imx_tmu_probe(struct udevice *dev)
 	if (pdata->zone_node) {
 		imx_tmu_init(dev);
 		imx_tmu_calibration(dev);
+		imx_tmu_enable_msite(dev);
 	} else {
 		imx_tmu_enable_msite(dev);
 	}
Signature · 1 line
2.7.4
#2 lore raw

PATCH v2 1/4 thermal: imx_tmu: enable monitoring and default alert/critical

Quoted 9 lines

Set default critical/alert temperature and enabling monoitoring. Without calling imx_tmu_enable_msite() monitoring will not be enabled and read_temperature will return 0. Additionally without setting alert temperature will cause imx_tmu_get_temp() to spin indefiniately thinking the system needs to cool.
This resolves the board spinning endlessly when enabling IMX_TMU in the SPL.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
author
#3 lore raw

PATCH v2 2/4 Respect that some compression algos can be enabled separately for SPL

In reply to Tim Harvey

From: Frieder Schrempf <[email protected]>

Some compression algorithms currently can be enabled for SPL and U-Boot proper separately. Therefore take into account USE_HOSTCC is well as CONFIG_IS_ENABLED() in these cases to prevent compiling these functions in case of a host tool build.

---
v2: avoid using USE_HOSTCC with another CONFIG to avoid issue found building m68k

---
 common/image.c | 24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)
common/image.c +18 -6
index 6923dac..dc9b191 100644
@@ -461,13 +461,16 @@ int image_decomp(int comp, ulong load, ulong image_start, int type,
 		else
 			ret = -ENOSPC;
 		break;
-#ifdef CONFIG_GZIP
+#ifndef USE_HOSTCC
+#if CONFIG_IS_ENABLED(GZIP)
 	case IH_COMP_GZIP: {
 		ret = gunzip(load_buf, unc_len, image_buf, &image_len);
 		break;
 	}
 #endif /* CONFIG_GZIP */
-#ifdef CONFIG_BZIP2
+#endif
+#ifndef USE_HOSTCC
+#if CONFIG_IS_ENABLED(BZIP2)
 	case IH_COMP_BZIP2: {
 		uint size = unc_len;
 
@@ -483,7 +486,9 @@ int image_decomp(int comp, ulong load, ulong image_start, int type,
 		break;
 	}
 #endif /* CONFIG_BZIP2 */
-#ifdef CONFIG_LZMA
+#endif
+#ifndef USE_HOSTCC
+#if CONFIG_IS_ENABLED(LZMA)
 	case IH_COMP_LZMA: {
 		SizeT lzma_len = unc_len;
 
@@ -493,7 +498,9 @@ int image_decomp(int comp, ulong load, ulong image_start, int type,
 		break;
 	}
 #endif /* CONFIG_LZMA */
-#ifdef CONFIG_LZO
+#endif
+#ifndef USE_HOSTCC
+#if CONFIG_IS_ENABLED(LZO)
 	case IH_COMP_LZO: {
 		size_t size = unc_len;
 
@@ -502,7 +509,9 @@ int image_decomp(int comp, ulong load, ulong image_start, int type,
 		break;
 	}
 #endif /* CONFIG_LZO */
-#ifdef CONFIG_LZ4
+#endif
+#ifndef USE_HOSTCC
+#if CONFIG_IS_ENABLED(LZ4)
 	case IH_COMP_LZ4: {
 		size_t size = unc_len;
 
@@ -511,7 +520,9 @@ int image_decomp(int comp, ulong load, ulong image_start, int type,
 		break;
 	}
 #endif /* CONFIG_LZ4 */
-#ifdef CONFIG_ZSTD
+#endif
+#ifndef USE_HOSTCC
+#if CONFIG_IS_ENABLED(ZSTD)
 	case IH_COMP_ZSTD: {
 		size_t size = unc_len;
 		ZSTD_DStream *dstream;
@@ -561,6 +572,7 @@ int image_decomp(int comp, ulong load, ulong image_start, int type,
 		break;
 	}
 #endif /* CONFIG_ZSTD */
+#endif
 	default:
 		printf("Unimplemented compression type %d\n", comp);
 		return -ENOSYS;
Signature · 1 line
2.7.4
#4 lore raw

PATCH v2 2/4 Respect that some compression algos can be enabled separately for SPL

Quoted 7 lines

From: Frieder Schrempf <[email protected]>
Some compression algorithms currently can be enabled for SPL and U-Boot proper separately. Therefore take into account USE_HOSTCC is well as CONFIG_IS_ENABLED() in these cases to prevent compiling these functions in case of a host tool build.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
author
#5 lore raw

PATCH v2 3/4 arm: dts: imx8mm: add Gateworks i.MX8 Mini Dev kits

In reply to Tim Harvey

Add Gateworks i.MX 8M Mini Development kits from Mainline Linux

---
v2: no changes

---
 arch/arm/dts/Makefile                    |   4 +
 arch/arm/dts/imx8mm-venice-gw700x.dtsi   | 495 +++++++++++++++++++++++++++++++
 arch/arm/dts/imx8mm-venice-gw71xx-0x.dts |  19 ++
 arch/arm/dts/imx8mm-venice-gw71xx.dtsi   | 186 ++++++++++++
 arch/arm/dts/imx8mm-venice-gw72xx-0x.dts |  20 ++
 arch/arm/dts/imx8mm-venice-gw72xx.dtsi   | 311 +++++++++++++++++++
 arch/arm/dts/imx8mm-venice-gw73xx-0x.dts |  19 ++
 arch/arm/dts/imx8mm-venice-gw73xx.dtsi   | 362 ++++++++++++++++++++++
 8 files changed, 1416 insertions(+)
 create mode 100644 arch/arm/dts/imx8mm-venice-gw700x.dtsi
 create mode 100644 arch/arm/dts/imx8mm-venice-gw71xx-0x.dts
 create mode 100644 arch/arm/dts/imx8mm-venice-gw71xx.dtsi
 create mode 100644 arch/arm/dts/imx8mm-venice-gw72xx-0x.dts
 create mode 100644 arch/arm/dts/imx8mm-venice-gw72xx.dtsi
 create mode 100644 arch/arm/dts/imx8mm-venice-gw73xx-0x.dts
 create mode 100644 arch/arm/dts/imx8mm-venice-gw73xx.dtsi
arch/arm/dts/Makefile +4 -0
index a36b8c7..3c155b9 100644
@@ -779,6 +779,10 @@ dtb-$(CONFIG_ARCH_IMX8) += \
 
 dtb-$(CONFIG_ARCH_IMX8M) += \
 	imx8mm-evk.dtb \
+	imx8mm-venice.dtb \
+	imx8mm-venice-gw71xx-0x.dtb \
+	imx8mm-venice-gw72xx-0x.dtb \
+	imx8mm-venice-gw73xx-0x.dtb \
 	imx8mm-verdin.dtb \
 	phycore-imx8mm.dtb \
 	imx8mn-ddr4-evk.dtb \
arch/arm/dts/imx8mm-venice-gw700x.dtsi new file +495 -0

495 lines not on this page · raw message

arch/arm/dts/imx8mm-venice-gw71xx-0x.dts new file +19 -0
new file mode 100644
index 0000000..3f88c4a
@@ -0,0 +1,19 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2020 Gateworks Corporation
+ */
+
+/dts-v1/;
+
+#include "imx8mm.dtsi"
+#include "imx8mm-venice-gw700x.dtsi"
+#include "imx8mm-venice-gw71xx.dtsi"
+
+/ {
+	model = "Gateworks Venice GW71xx-0x i.MX8MM Development Kit";
+	compatible = "gw,imx8mm-gw71xx-0x", "fsl,imx8mm";
+
+	chosen {
+		stdout-path = &uart2;
+	};
+};
arch/arm/dts/imx8mm-venice-gw71xx.dtsi new file +186 -0

186 lines not on this page · raw message

arch/arm/dts/imx8mm-venice-gw72xx-0x.dts new file +20 -0
new file mode 100644
index 0000000..b1e7540
@@ -0,0 +1,20 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2020 Gateworks Corporation
+ */
+
+/dts-v1/;
+
+#include "imx8mm.dtsi"
+#include "imx8mm-venice-gw700x.dtsi"
+#include "imx8mm-venice-gw72xx.dtsi"
+
+/ {
+	model = "Gateworks Venice GW72xx-0x i.MX8MM Development Kit";
+	compatible = "gw,imx8mm-gw72xx-0x", "fsl,imx8mm";
+
+	chosen {
+		stdout-path = &uart2;
+	};
+};
+
arch/arm/dts/imx8mm-venice-gw72xx.dtsi new file +311 -0

311 lines not on this page · raw message

arch/arm/dts/imx8mm-venice-gw73xx-0x.dts new file +19 -0
new file mode 100644
index 0000000..6905437
@@ -0,0 +1,19 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2020 Gateworks Corporation
+ */
+
+/dts-v1/;
+
+#include "imx8mm.dtsi"
+#include "imx8mm-venice-gw700x.dtsi"
+#include "imx8mm-venice-gw73xx.dtsi"
+
+/ {
+	model = "Gateworks Venice GW73xx-0x i.MX8MM Development Kit";
+	compatible = "gw,imx8mm-gw73xx-0x", "fsl,imx8mm";
+
+	chosen {
+		stdout-path = &uart2;
+	};
+};
arch/arm/dts/imx8mm-venice-gw73xx.dtsi new file +362 -0

362 lines not on this page · raw message

Signature · 1 line
2.7.4
author
#6 lore raw

PATCH v2 4/4 board: gateworks: imx8mm: Add Gateworks Venice board support

In reply to Tim Harvey

Add initial support for Gateworks Venice product family based on the i.MX 8M Mini SoC

---
v2: no changes

---
 arch/arm/dts/imx8mm-venice-gw700x-u-boot.dtsi    |  105 +
 arch/arm/dts/imx8mm-venice-gw71xx-0x-u-boot.dtsi |    5 +
 arch/arm/dts/imx8mm-venice-gw72xx-0x-u-boot.dtsi |    5 +
 arch/arm/dts/imx8mm-venice-gw73xx-0x-u-boot.dtsi |    5 +
 arch/arm/dts/imx8mm-venice-u-boot.dtsi           |  103 +
 arch/arm/dts/imx8mm-venice.dts                   |  152 ++
 arch/arm/mach-imx/imx8m/Kconfig                  |    9 +-
 board/gateworks/venice/Kconfig                   |   13 +
 board/gateworks/venice/MAINTAINERS               |    7 +
 board/gateworks/venice/Makefile                  |   12 +
 board/gateworks/venice/README                    |   34 +
 board/gateworks/venice/gsc.c                     |  687 ++++++
 board/gateworks/venice/gsc.h                     |   54 +
 board/gateworks/venice/imx8mm_venice.c           |  133 ++
 board/gateworks/venice/lpddr4_timing.c           | 2505 ++++++++++++++++++++++
 board/gateworks/venice/lpddr4_timing.h           |   12 +
 board/gateworks/venice/spl.c                     |  187 ++
 configs/imx8mm_venice_defconfig                  |  113 +
 include/configs/imx8mm_venice.h                  |  125 ++
 19 files changed, 4265 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/imx8mm-venice-gw700x-u-boot.dtsi
 create mode 100644 arch/arm/dts/imx8mm-venice-gw71xx-0x-u-boot.dtsi
 create mode 100644 arch/arm/dts/imx8mm-venice-gw72xx-0x-u-boot.dtsi
 create mode 100644 arch/arm/dts/imx8mm-venice-gw73xx-0x-u-boot.dtsi
 create mode 100644 arch/arm/dts/imx8mm-venice-u-boot.dtsi
 create mode 100644 arch/arm/dts/imx8mm-venice.dts
 create mode 100644 board/gateworks/venice/Kconfig
 create mode 100644 board/gateworks/venice/MAINTAINERS
 create mode 100644 board/gateworks/venice/Makefile
 create mode 100644 board/gateworks/venice/README
 create mode 100644 board/gateworks/venice/gsc.c
 create mode 100644 board/gateworks/venice/gsc.h
 create mode 100644 board/gateworks/venice/imx8mm_venice.c
 create mode 100644 board/gateworks/venice/lpddr4_timing.c
 create mode 100644 board/gateworks/venice/lpddr4_timing.h
 create mode 100644 board/gateworks/venice/spl.c
 create mode 100644 configs/imx8mm_venice_defconfig
 create mode 100644 include/configs/imx8mm_venice.h
arch/arm/dts/imx8mm-venice-gw700x-u-boot.dtsi new file +105 -0
new file mode 100644
index 0000000..a4487e2
@@ -0,0 +1,105 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2021 Gateworks Corporation
+ */
+
+&{/soc at 0} {
+	u-boot,dm-pre-reloc;
+	u-boot,dm-spl;
+};
+
+&clk {
+	u-boot,dm-spl;
+	u-boot,dm-pre-reloc;
+	/delete-property/ assigned-clocks;
+	/delete-property/ assigned-clock-parents;
+	/delete-property/ assigned-clock-rates;
+};
+
+&osc_24m {
+	u-boot,dm-spl;
+	u-boot,dm-pre-reloc;
+};
+
+&aips1 {
+	u-boot,dm-spl;
+	u-boot,dm-pre-reloc;
+};
+
+&aips2 {
+	u-boot,dm-spl;
+};
+
+&aips3 {
+	u-boot,dm-spl;
+};
+
+&iomuxc {
+	u-boot,dm-spl;
+};
+
+&gpio1 {
+	u-boot,dm-spl;
+};
+
+&gpio2 {
+	u-boot,dm-spl;
+};
+
+&gpio3 {
+	u-boot,dm-spl;
+};
+
+&gpio4 {
+	u-boot,dm-spl;
+};
+
+&gpio5 {
+	u-boot,dm-spl;
+};
+
+&uart2 {
+	u-boot,dm-spl;
+};
+
+&pinctrl_uart2 {
+	u-boot,dm-spl;
+};
+
+&usdhc3 {
+	u-boot,dm-spl;
+};
+
+&pinctrl_usdhc3 {
+	u-boot,dm-spl;
+};
+
+&i2c1 {
+	u-boot,dm-spl;
+};
+
+&pinctrl_i2c1 {
+	u-boot,dm-spl;
+};
+
+&i2c2 {
+	u-boot,dm-spl;
+};
+
+&pinctrl_i2c2 {
+	u-boot,dm-spl;
+};
+
+&fec1 {
+	phy-reset-gpios = <&gpio3 0 GPIO_ACTIVE_LOW>;
+	phy-reset-duration = <1>;
+	phy-reset-post-delay = <1>;
+};
+
+&{/soc at 0/bus at 30800000/i2c at 30a20000/pmic at 69} {
+	u-boot,dm-spl;
+};
+
+&{/soc at 0/bus at 30800000/i2c at 30a20000/pmic at 69/regulators} {
+	u-boot,dm-spl;
+};
arch/arm/dts/imx8mm-venice-gw71xx-0x-u-boot.dtsi new file +5 -0
new file mode 100644
index 0000000..f5d52c2
@@ -0,0 +1,5 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2021 Gateworks Corporation
+ */
+#include "imx8mm-venice-gw700x-u-boot.dtsi"
arch/arm/dts/imx8mm-venice-gw72xx-0x-u-boot.dtsi new file +5 -0
new file mode 100644
index 0000000..f5d52c2
@@ -0,0 +1,5 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2021 Gateworks Corporation
+ */
+#include "imx8mm-venice-gw700x-u-boot.dtsi"
arch/arm/dts/imx8mm-venice-gw73xx-0x-u-boot.dtsi new file +5 -0
new file mode 100644
index 0000000..f5d52c2
@@ -0,0 +1,5 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2021 Gateworks Corporation
+ */
+#include "imx8mm-venice-gw700x-u-boot.dtsi"
arch/arm/dts/imx8mm-venice-u-boot.dtsi new file +103 -0

103 lines not on this page · raw message

arch/arm/dts/imx8mm-venice.dts new file +152 -0

152 lines not on this page · raw message

arch/arm/mach-imx/imx8m/Kconfig +8 -1
index c455f7b..7117650 100644
@@ -43,7 +43,13 @@ config TARGET_IMX8MM_EVK
 	select SUPPORT_SPL
 	select IMX8M_LPDDR4
 
-config TARGET_IMX8MN_DDR4_EVK
+config TARGET_IMX8MM_VENICE
+	bool "Support Gateworks Venice iMX8M Mini module"
+	select IMX8MM
+	select SUPPORT_SPL
+	select IMX8M_LPDDR4
+
+config TARGET_IMX8MN_EVK
 	bool "imx8mn DDR4 EVK board"
 	select IMX8MN
 	select SUPPORT_SPL
@@ -95,6 +101,7 @@ source "board/freescale/imx8mq_evk/Kconfig"
 source "board/freescale/imx8mm_evk/Kconfig"
 source "board/freescale/imx8mn_evk/Kconfig"
 source "board/freescale/imx8mp_evk/Kconfig"
+source "board/gateworks/venice/Kconfig"
 source "board/google/imx8mq_phanbell/Kconfig"
 source "board/technexion/pico-imx8mq/Kconfig"
 source "board/toradex/verdin-imx8mm/Kconfig"
board/gateworks/venice/Kconfig new file +13 -0
new file mode 100644
index 0000000..e11798f
@@ -0,0 +1,13 @@
+if TARGET_IMX8MM_VENICE
+
+config SYS_BOARD
+	default "venice"
+
+config SYS_VENDOR
+	default "gateworks"
+
+config SYS_CONFIG_NAME
+	default "imx8mm_venice"
+
+endif
+
board/gateworks/venice/MAINTAINERS new file +7 -0
new file mode 100644
index 0000000..07b9e2a
@@ -0,0 +1,7 @@
+i.MX8MM Venice
+M:	Tim Harvey <[email protected]>
+S:	Maintained
+F:	arch/arm/dts/imx8mm-venice*
+F:	board/gateworks/venice/
+F:	include/configs/venice.h
+F:	configs/imx8mm_venice_defconfig
board/gateworks/venice/Makefile new file +12 -0
new file mode 100644
index 0000000..08f5c62
@@ -0,0 +1,12 @@
+#
+# Copyright 2021 Gateworks Corporation
+#
+# SPDX-License-Identifier: GPL-2.0+
+#
+
+obj-y += imx8mm_venice.o gsc.o
+
+ifdef CONFIG_SPL_BUILD
+obj-y += spl.o
+obj-$(CONFIG_IMX8M_LPDDR4) += lpddr4_timing.o
+endif
board/gateworks/venice/README new file +34 -0
new file mode 100644
index 0000000..6a0ab1e
@@ -0,0 +1,34 @@
+U-Boot for the Gateworks i.MX8M Mini Venice Development Kit boards
+
+Quick Start
+===========
+- Build the ARM Trusted firmware binary
+- Get ddr firmware
+- Build U-Boot
+- Flash to eMMC
+- Boot
+
+Get and Build the ARM Trusted firmware
+======================================
+$ git clone https://source.codeaurora.org/external/imx/imx-atf
+$ git checkout imx_5.4.47_2.2.0
+$ make PLAT=imx8mm CROSS_COMPILE=aarch64-linux-gnu- bl31
+$ cp build/imx8mm/release/bl31.bin .
+
+Get the DDR Firmware
+====================
+$ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.9.bin
+$ chmod +x firmware-imx-8.9.bin
+$ ./firmware-imx-8.9.bin
+$ cp firmware-imx-8.9/firmware/ddr/synopsys/lpddr4*.bin .
+
+Build U-Boot
+============
+$ make imx8mm_venice_defconfig
+$ make flash.bin CROSS_COMPILE=aarch64-linux-gnu- ATF_LOAD_ADDR=0x920000
+
+Update eMMC
+===========
+=> tftpboot $loadaddr flash.bin
+=> setexpr blkcnt $filesize + 0x1ff && setexpr blkcnt $blkcnt / 0x200
+=> mmc dev 2 && mmc write $loadaddr 0x42 $blkcnt
board/gateworks/venice/gsc.c new file +687 -0

687 lines not on this page · raw message

board/gateworks/venice/gsc.h new file +54 -0

54 lines not on this page · raw message

board/gateworks/venice/imx8mm_venice.c new file +133 -0

133 lines not on this page · raw message

board/gateworks/venice/lpddr4_timing.c new file +2505 -0

1,664 lines not on this page · raw message

board/gateworks/venice/lpddr4_timing.h new file +12 -0
new file mode 100644
index 0000000..94445f8

Lines of this file are not shown. View the raw message.

board/gateworks/venice/spl.c new file +187 -0

187 lines not on this page · raw message

configs/imx8mm_venice_defconfig new file +113 -0

113 lines not on this page · raw message

include/configs/imx8mm_venice.h new file +125 -0

125 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.7.4

Part of the diff is not shown here. View the raw message.

#7 lore raw

PATCH v2 4/4 board: gateworks: imx8mm: Add Gateworks Venice board support

Hi Tim,

Quoted 5 lines · Tim Harvey

Add initial support for Gateworks Venice product family based on the i.MX 8M Mini SoC

---

[snip]

arch/arm/mach-imx/imx8m/Kconfig config TARGET_IMX8MM_EVK · line 46

Quoted 9 lines
arch/arm/mach-imx/imx8m/Kconfig +0 -1
index c455f7b..7117650 100644
@@ -43,7 +43,13 @@ config TARGET_IMX8MM_EVK
  	select SUPPORT_SPL
  	select IMX8M_LPDDR4
 
-config TARGET_IMX8MN_DDR4_EVK

This board is silently dropped...

arch/arm/mach-imx/imx8m/Kconfig config TARGET_IMX8MM_EVK · line 51

Quoted 6 lines
arch/arm/mach-imx/imx8m/Kconfig +6 -0
+config TARGET_IMX8MM_VENICE
+	bool "Support Gateworks Venice iMX8M Mini module"
+	select IMX8MM
+	select SUPPORT_SPL
+	select IMX8M_LPDDR4
+

This is your board, ok

arch/arm/mach-imx/imx8m/Kconfig config TARGET_IMX8MM_EVK · line 52

Quoted 1 line
arch/arm/mach-imx/imx8m/Kconfig +1 -0
+config TARGET_IMX8MN_EVK

and this is the old board with wrong name. Somethin went wrong....

Best regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
author
#8 lore raw

PATCH v2 4/4 board: gateworks: imx8mm: Add Gateworks Venice board support

Quoted 33 lines · Stefano Babic

Hi Tim,

Quoted 5 lines · Tim Harvey

Add initial support for Gateworks Venice product family based on the i.MX 8M Mini SoC

---

[snip]

arch/arm/mach-imx/imx8m/Kconfig config TARGET_IMX8MM_EVK · line 46

Quoted 9 lines
arch/arm/mach-imx/imx8m/Kconfig +0 -1
index c455f7b..7117650 100644
@@ -43,7 +43,13 @@ config TARGET_IMX8MM_EVK
      select SUPPORT_SPL
      select IMX8M_LPDDR4
 
-config TARGET_IMX8MN_DDR4_EVK

This board is silently dropped...

arch/arm/mach-imx/imx8m/Kconfig config TARGET_IMX8MM_EVK · line 51

Quoted 6 lines
arch/arm/mach-imx/imx8m/Kconfig +6 -0
+config TARGET_IMX8MM_VENICE
+     bool "Support Gateworks Venice iMX8M Mini module"
+     select IMX8MM
+     select SUPPORT_SPL
+     select IMX8M_LPDDR4
+

This is your board, ok

Quoted 4 lines

arch/arm/mach-imx/imx8m/Kconfig config TARGET_IMX8MM_EVK · line 52

Quoted 1 line
arch/arm/mach-imx/imx8m/Kconfig +1 -0
+config TARGET_IMX8MN_EVK

and this is the old board with wrong name. Somethin went wrong....

Stefano,

Oops... looks like I lost that in a rebase.

Does everything else look good or should I wait for further review before sending a v3?

Thanks,

Tim

#9 lore raw

PATCH v2 4/4 board: gateworks: imx8mm: Add Gateworks Venice board support

Quoted 39 lines · Tim Harvey
Quoted 33 lines · Stefano Babic

Hi Tim,

Quoted 5 lines · Tim Harvey

Add initial support for Gateworks Venice product family based on the i.MX 8M Mini SoC

---

[snip]

arch/arm/mach-imx/imx8m/Kconfig config TARGET_IMX8MM_EVK · line 46

Quoted 9 lines
arch/arm/mach-imx/imx8m/Kconfig +0 -1
index c455f7b..7117650 100644
@@ -43,7 +43,13 @@ config TARGET_IMX8MM_EVK
       select SUPPORT_SPL
       select IMX8M_LPDDR4
 
-config TARGET_IMX8MN_DDR4_EVK

This board is silently dropped...

arch/arm/mach-imx/imx8m/Kconfig config TARGET_IMX8MM_EVK · line 51

Quoted 6 lines
arch/arm/mach-imx/imx8m/Kconfig +6 -0
+config TARGET_IMX8MM_VENICE
+     bool "Support Gateworks Venice iMX8M Mini module"
+     select IMX8MM
+     select SUPPORT_SPL
+     select IMX8M_LPDDR4
+

This is your board, ok

Quoted 4 lines

arch/arm/mach-imx/imx8m/Kconfig config TARGET_IMX8MM_EVK · line 52

Quoted 1 line
arch/arm/mach-imx/imx8m/Kconfig +1 -0
+config TARGET_IMX8MN_EVK

and this is the old board with wrong name. Somethin went wrong....

Quoted 6 lines

Stefano,

Oops... looks like I lost that in a rebase.

Does everything else look good or should I wait for further review before sending a v3?

IMHO was ok, and I have already applied 1/4 and 2/4. Just resend the last two patches.

Thanks,
Stefano

Quoted 5 lines

Thanks,

Tim

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================