gpiolib: cdev: convert stream-like files from
PATCH 1/1 gpiolib: cdev: convert stream-like files from
Eliminate the following coccicheck warning:
./drivers/gpio/gpiolib-cdev.c:2307:7-23: WARNING: gpio_fileops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
--- drivers/gpio/gpiolib-cdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpiolib-cdev.c +1 -1
@@ -2304,7 +2304,7 @@ static int gpio_chrdev_open(struct inode *inode, struct file *file)get_device (&gdev->dev); file->private_data = cdev; - ret =nonseekable_open (inode, file); + ret =stream_open (inode, file);if (ret) goto out_unregister_notifier;
Signature · 1 line
1.8.3.1
Quoted 25 lines · Yang Li
Eliminate the following coccicheck warning:
./drivers/gpio/gpiolib-cdev.c:2307:7-23: WARNING:gpio_fileops: .read() has stream semantic; safe to changenonseekable_open->stream_open.Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>--- drivers/gpio/gpiolib-cdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpio/gpiolib-cdev.c +1
-2@@ -2304,7 +2304,7 @@ static int gpio_chrdev_open(struct inode *inode, struct file *file)get_device (&gdev->dev); file->private_data = cdev; - ret =nonseekable_open (inode, file); + ret =stream_open (inode, file);if (ret) goto out_unregister_notifier; --
Quoted 2 lines
1.8.3.1
I think you have a false positive here - we don't even take the offset argument into account so I don't see how the line_watch_read callback could be interpreted as seekable.
Bart
Quoted 6 lines · Yang Li
Eliminate the following coccicheck warning:
./drivers/gpio/gpiolib-cdev.c:2307:7-23: WARNING:gpio_fileops: .read() has stream semantic; safe to changenonseekable_open->stream_open.Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>
This doesn't make any sense to me.
It is pretty clear from context that this file should *not* be seeked and it seems just dangerous to randomly allow that. Better safe than sorry.
I don't know if the function nonseekable_open() has an unintuitive name if it means anything else than that. I burnt myself on the FS before.
Yours,
Linus Walleij