drivers: most: add ALSA sound driver
Subsystems (3)
Christian Gromm
maintainerPATCH v3 1/1 drivers: most: add ALSA sound driver
This patch moves the ALSA sound driver out of the staging area and adds it to the stable part of the MOST driver. Modifications to the Makefiles and Kconfigs are done accordingly to not break the build.
---
v2:
submitted patch that fixes issue found during code audit to staging version first to be able to resend single patch that adds the driver. The patch series included:
- use swabXX functions of kernel
v3:
- use non-safe list iteration
- add sanity check for function argument
drivers/most/Kconfig | 10 + drivers/most/Makefile | 1 + drivers/most/most_snd.c | 745 ++++++++++++++++++++++++++++++++++++ drivers/staging/most/Kconfig | 2 - drivers/staging/most/Makefile | 1 - drivers/staging/most/sound/Kconfig | 14 - drivers/staging/most/sound/Makefile | 4 - drivers/staging/most/sound/sound.c | 745 ------------------------------------ 8 files changed, 756 insertions(+), 766 deletions(-) create mode 100644 drivers/most/most_snd.c delete mode 100644 drivers/staging/most/sound/Kconfig delete mode 100644 drivers/staging/most/sound/Makefile delete mode 100644 drivers/staging/most/sound/sound.c
drivers/most/Kconfig +10 -0
@@ -32,4 +32,14 @@ config MOST_CDEV To compile this driver as a module, choose M here: the module will be called most_cdev. + +config MOST_SND + tristate "Sound" + depends on SND + select SND_PCM + help + Say Y here if you want to commumicate via ALSA/sound devices. + + To compile this driver as a module, choose M here: the + module will be called most_sound. endif
drivers/most/Makefile +1 -0
@@ -5,3 +5,4 @@ most_core-y := core.o \ obj-$(CONFIG_MOST_USB_HDM) += most_usb.o obj-$(CONFIG_MOST_CDEV) += most_cdev.o +obj-$(CONFIG_MOST_SND) += most_snd.o
drivers/most/most_snd.c new file +745 -0
745 lines not on this page · raw message
drivers/staging/most/Kconfig +0 -2
@@ -20,8 +20,6 @@ if MOST_COMPONENTS source "drivers/staging/most/net/Kconfig" -source "drivers/staging/most/sound/Kconfig" - source "drivers/staging/most/video/Kconfig" source "drivers/staging/most/dim2/Kconfig"
drivers/staging/most/Makefile +0 -1
@@ -1,7 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_MOST_NET) += net/ -obj-$(CONFIG_MOST_SOUND) += sound/ obj-$(CONFIG_MOST_VIDEO) += video/ obj-$(CONFIG_MOST_DIM2) += dim2/ obj-$(CONFIG_MOST_I2C) += i2c/
drivers/staging/most/sound/Kconfig deleted +0 -14
@@ -1,14 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0 -# -# MOST ALSA configuration -# - -config MOST_SOUND - tristate "Sound" - depends on SND - select SND_PCM - help - Say Y here if you want to commumicate via ALSA/sound devices. - - To compile this driver as a module, choose M here: the - module will be called most_sound.
drivers/staging/most/sound/Makefile deleted +0 -4
@@ -1,4 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_MOST_SOUND) += most_sound.o - -most_sound-objs := sound.o
drivers/staging/most/sound/sound.c deleted +0 -745
745 lines not on this page · raw message
Signature · 1 line
2.7.4
Greg KH
maintainerQuoted 13 lines · Christian Gromm
This patch moves the ALSA sound driver out of the staging area and adds it to the stable part of the MOST driver. Modifications to the Makefiles and Kconfigs are done accordingly to not break the build.
Signed-off-by Christian Gromm <[email protected]>---
v2:Reported-by Greg Kroah-Hartman <[email protected]>submitted patch that fixes issue found during code audit to staging version first to be able to resend single patch that adds the driver. The patch series included:
Quoted 7 lines
- use swabXX functions of kernel
v3:
Reported-by Dan Carpenter <[email protected]>- use non-safe list iteration
- add sanity check for function argument
Given a lack of complaints about this, I've now queued this up in my staging tree for the next -rc1 merge window, thanks!
greg k-h