gpiolib: acpi: Add missing IRQF_ONESHOT
PATCH 1/1 gpiolib: acpi: Add missing IRQF_ONESHOT
fixed the following coccicheck:
./drivers/gpio/gpiolib-acpi.c:176:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
--- drivers/gpio/gpiolib-acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpiolib-acpi.c +1 -1
@@ -174,7 +174,7 @@ static void acpi_gpiochip_request_irq(struct acpi_gpio_chip *acpi_gpio,int ret, value; ret =request_threaded_irq (event->irq,NULL , event->handler, - event->irqflags,"ACPI:Event" , event); + event->irqflags |IRQF_ONESHOT ,"ACPI:Event" , event);if (ret) { dev_err(acpi_gpio->chip->parent, "Failed to setup interrupt handler for %d\n",
Signature · 1 line
1.8.3.1
Quoted 6 lines · Yang Li
fixed the following coccicheck:
./drivers/gpio/gpiolib-acpi.c:176:7-27: ERROR: Threaded IRQ with no primary handler requested withoutIRQF_ONESHOTMake sure threaded IRQs without a primary handler are always request with
IRQF_ONESHOT
Quoted 22 lines
Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>--- drivers/gpio/gpiolib-acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpio/gpiolib-acpi.c +1
-1@@ -174,7 +174,7 @@ static void acpi_gpiochip_request_irq(struct acpi_gpio_chip *acpi_gpio,int ret, value; ret =request_threaded_irq (event->irq,NULL , event->handler, - event->irqflags,"ACPI:Event" , event); + event->irqflags |IRQF_ONESHOT ,"ACPI:Event" , event);if (ret) { dev_err(acpi_gpio->chip->parent, "Failed to setup interrupt handler for %d\n",Signature · 1 line
1.8.3.1
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 9 lines · Andy Shevchenko
Quoted 6 lines · Yang Li
fixed the following coccicheck:
./drivers/gpio/gpiolib-acpi.c:176:7-27: ERROR: Threaded IRQ with no primary handler requested withoutIRQF_ONESHOTMake sure threaded IRQs without a primary handler are always request with
IRQF_ONESHOTAcked-by Andy Shevchenko <[email protected]>
Bart, I guess I will collect this in my branch and send you a PR. I have more fixes to that file anyway.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 10 lines · Andy Shevchenko
Quoted 8 lines · Andy Shevchenko
Quoted 6 lines · Yang Li
fixed the following coccicheck:
./drivers/gpio/gpiolib-acpi.c:176:7-27: ERROR: Threaded IRQ with no primary handler requested withoutIRQF_ONESHOTMake sure threaded IRQs without a primary handler are always request with
IRQF_ONESHOT
Quoted 10 lines
Quoted 1 line
Acked-by Andy Shevchenko <[email protected]>Bart, I guess I will collect this in my branch and send you a PR. I have more fixes to that file anyway.
--
With Best Regards,
Andy Shevchenko
Fine with me!
Quoted 11 lines · Bartosz Golaszewski
Quoted 9 lines · Andy Shevchenko
Quoted 8 lines · Andy Shevchenko
Quoted 6 lines · Yang Li
fixed the following coccicheck:
./drivers/gpio/gpiolib-acpi.c:176:7-27: ERROR: Threaded IRQ with no primary handler requested withoutIRQF_ONESHOTMake sure threaded IRQs without a primary handler are always request with
IRQF_ONESHOT
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Acked-by Andy Shevchenko <[email protected]>Bart, I guess I will collect this in my branch and send you a PR. I have more fixes to that file anyway.
Fine with me!
Good! So, when you have time, please review [1] and I'll send PR for fixes.
[1]: https://lore.kernel.org/linux-gpio/[email protected]/T/#u
Signature · 2 lines
With Best Regards, Andy Shevchenko