Add PM7325/PM8350C/PMR735A regulator support

Convert regulator bindings from .txt to .yaml format.

Convert regulator bindings from .txt to .yaml format.

Signed-off-by satya priya <[email protected]>

---
 .../bindings/regulator/qcom,rpmh-regulator.txt     | 180 ---------------------
 .../bindings/regulator/qcom,rpmh-regulator.yaml    | 147 +++++++++++++++++
 2 files changed, 147 insertions(+), 180 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml

Quoted 12 lines · satya priya

Convert regulator bindings from .txt to .yaml format.

Signed-off-by satya priya <[email protected]>

---
 .../bindings/regulator/qcom,rpmh-regulator.txt     | 180 
---------------------
 .../bindings/regulator/qcom,rpmh-regulator.yaml    | 147 
+++++++++++++++++
 2 files changed, 147 insertions(+), 180 deletions(-)
 delete mode 100644 
Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt
 create mode 100644 

Quoted 2 lines

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml:13:5:
[warning] wrong indentation: expected 2 but found 4 (indentation) ./Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml:48:5:
[warning] wrong indentation: expected 2 but found 4 (indentation) ./Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml:49:9:
[warning] wrong indentation: expected 6 but found 8 (indentation) ./Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml:50:13:
[warning] wrong indentation: expected 10 but found 12 (indentation) ./Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml:64:9:
[warning] wrong indentation: expected 6 but found 8 (indentation) ./Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml:69:9:
[warning] wrong indentation: expected 6 but found 8 (indentation) ./Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml:83:6:
[warning] wrong indentation: expected 6 but found 5 (indentation) ./Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml:89:6:
[warning] wrong indentation: expected 6 but found 5 (indentation) ./Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml:95:2:
[warning] wrong indentation: expected 2 but found 1 (indentation)

dtschema/dtc warnings/errors:

See https://patchwork.ozlabs.org/patch/1443748

This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit.

Convert regulator bindings from .txt to .yaml format.

Signed-off-by satya priya <[email protected]>

---
 .../bindings/regulator/qcom,rpmh-regulator.txt     | 180 ---------------------
 .../bindings/regulator/qcom,rpmh-regulator.yaml    | 147 +++++++++++++++++
 2 files changed, 147 insertions(+), 180 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt deleted +0 -180

deleted file mode 100644
index ce1e043..0000000
@@ -1,180 +0,0 @@
-Qualcomm Technologies, Inc. RPMh Regulators
-
-rpmh-regulator devices support PMIC regulator management via the Voltage
-Regulator Manager (VRM) and Oscillator Buffer (XOB) RPMh accelerators.  The APPS
-processor communicates with these hardware blocks via a Resource State
-Coordinator (RSC) using command packets.  The VRM allows changing three
-parameters for a given regulator: enable state, output voltage, and operating
-mode.  The XOB allows changing only a single parameter for a given regulator:
-its enable state.  Despite its name, the XOB is capable of controlling the
-enable state of any PMIC peripheral.  It is used for clock buffers, low-voltage
-switches, and LDO/SMPS regulators which have a fixed voltage and mode.
-
-=======================
-Required Node Structure
-=======================
-
-RPMh regulators must be described in two levels of device nodes.  The first
-level describes the PMIC containing the regulators and must reside within an
-RPMh device node.  The second level describes each regulator within the PMIC
-which is to be used on the board.  Each of these regulators maps to a single
-RPMh resource.
-
-The names used for regulator nodes must match those supported by a given PMIC.
-Supported regulator node names:
-       PM8005:         smps1 - smps4
-       PM8009:         smps1 - smps2, ldo1 - ldo7
-       PM8150:         smps1 - smps10, ldo1 - ldo18
-       PM8150L:        smps1 - smps8, ldo1 - ldo11, bob, flash, rgb
-       PM8350:         smps1 - smps12, ldo1 - ldo10,
-       PM8350C:        smps1 - smps10, ldo1 - ldo13, bob
-       PM8998:         smps1 - smps13, ldo1 - ldo28, lvs1 - lvs2
-       PMI8998:        bob
-       PM6150:         smps1 - smps5, ldo1 - ldo19
-       PM6150L:        smps1 - smps8, ldo1 - ldo11, bob
-       PMX55:          smps1 - smps7, ldo1 - ldo16
-
-========================
-First Level Nodes - PMIC
-========================
-
-- compatible
-       Usage:      required
-       Value type: <string>
-       Definition: Must be one of below:
-                   "qcom,pm8005-rpmh-regulators"
-                   "qcom,pm8009-rpmh-regulators"
-                   "qcom,pm8009-1-rpmh-regulators"
-                   "qcom,pm8150-rpmh-regulators"
-                   "qcom,pm8150l-rpmh-regulators"
-                   "qcom,pm8350-rpmh-regulators"
-                   "qcom,pm8350c-rpmh-regulators"
-                   "qcom,pm8998-rpmh-regulators"
-                   "qcom,pmc8180-rpmh-regulators"
-                   "qcom,pmc8180c-rpmh-regulators"
-                   "qcom,pmi8998-rpmh-regulators"
-                   "qcom,pm6150-rpmh-regulators"
-                   "qcom,pm6150l-rpmh-regulators"
-                   "qcom,pmx55-rpmh-regulators"
-
-- qcom,pmic-id
-       Usage:      required
-       Value type: <string>
-       Definition: RPMh resource name suffix used for the regulators found on
-                   this PMIC.  Typical values: "a", "b", "c", "d", "e", "f".
-
-- vdd-s1-supply
-- vdd-s2-supply
-- vdd-s3-supply
-- vdd-s4-supply
-       Usage:      optional (PM8998 and PM8005 only)
-       Value type: <phandle>
-       Definition: phandle of the parent supply regulator of one or more of the
-                   regulators for this PMIC.
-
-- vdd-s5-supply
-- vdd-s6-supply
-- vdd-s7-supply
-- vdd-s8-supply
-- vdd-s9-supply
-- vdd-s10-supply
-- vdd-s11-supply
-- vdd-s12-supply
-- vdd-s13-supply
-- vdd-l1-l27-supply
-- vdd-l2-l8-l17-supply
-- vdd-l3-l11-supply
-- vdd-l4-l5-supply
-- vdd-l6-supply
-- vdd-l7-l12-l14-l15-supply
-- vdd-l9-supply
-- vdd-l10-l23-l25-supply
-- vdd-l13-l19-l21-supply
-- vdd-l16-l28-supply
-- vdd-l18-l22-supply
-- vdd-l20-l24-supply
-- vdd-l26-supply
-- vin-lvs-1-2-supply
-       Usage:      optional (PM8998 only)
-       Value type: <phandle>
-       Definition: phandle of the parent supply regulator of one or more of the
-                   regulators for this PMIC.
-
-- vdd-bob-supply
-       Usage:      optional (PMI8998 only)
-       Value type: <phandle>
-       Definition: BOB regulator parent supply phandle
-
-===============================
-Second Level Nodes - Regulators
-===============================
-
-- qcom,always-wait-for-ack
-       Usage:      optional
-       Value type: <empty>
-       Definition: Boolean flag which indicates that the application processor
-                   must wait for an ACK or a NACK from RPMh for every request
-                   sent for this regulator including those which are for a
-                   strictly lower power state.
-
-Other properties defined in Documentation/devicetree/bindings/regulator/regulator.txt
-may also be used.  regulator-initial-mode and regulator-allowed-modes may be
-specified for VRM regulators using mode values from
-include/dt-bindings/regulator/qcom,rpmh-regulator.h.  regulator-allow-bypass
-may be specified for BOB type regulators managed via VRM.
-regulator-allow-set-load may be specified for LDO type regulators managed via
-VRM.
-
-========
-Examples
-========
-
-#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
-
-&apps_rsc {
-       pm8998-rpmh-regulators {
-               compatible = "qcom,pm8998-rpmh-regulators";
-               qcom,pmic-id = "a";
-
-               vdd-l7-l12-l14-l15-supply = <&pm8998_s5>;
-
-               smps2 {
-                       regulator-min-microvolt = <1100000>;
-                       regulator-max-microvolt = <1100000>;
-               };
-
-               pm8998_s5: smps5 {
-                       regulator-min-microvolt = <1904000>;
-                       regulator-max-microvolt = <2040000>;
-               };
-
-               ldo7 {
-                       regulator-min-microvolt = <1800000>;
-                       regulator-max-microvolt = <1800000>;
-                       regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
-                       regulator-allowed-modes =
-                               <RPMH_REGULATOR_MODE_LPM
-                                RPMH_REGULATOR_MODE_HPM>;
-                       regulator-allow-set-load;
-               };
-
-               lvs1 {
-                       regulator-min-microvolt = <1800000>;
-                       regulator-max-microvolt = <1800000>;
-               };
-       };
-
-       pmi8998-rpmh-regulators {
-               compatible = "qcom,pmi8998-rpmh-regulators";
-               qcom,pmic-id = "b";
-
-               bob {
-                       regulator-min-microvolt = <3312000>;
-                       regulator-max-microvolt = <3600000>;
-                       regulator-allowed-modes =
-                               <RPMH_REGULATOR_MODE_AUTO
-                                RPMH_REGULATOR_MODE_HPM>;
-                       regulator-initial-mode = <RPMH_REGULATOR_MODE_AUTO>;
-               };
-       };
-};

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +2 -0

new file mode 100644
index 0000000..c14baf8
@@ -0,0 +1,147 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +16 -0

+    rpmh-regulator devices support PMIC regulator management via the Voltage
+    Regulator Manager (VRM) and Oscillator Buffer (XOB) RPMh accelerators.  The APPS
+    processor communicates with these hardware blocks via a Resource State
+    Coordinator (RSC) using command packets.  The VRM allows changing three
+    parameters for a given regulator, enable state, output voltage, and operating
+    mode.  The XOB allows changing only a single parameter for a given regulator,
+    its enable state.  Despite its name, the XOB is capable of controlling the
+    enable state of any PMIC peripheral.  It is used for clock buffers, low-voltage
+    switches, and LDO/SMPS regulators which have a fixed voltage and mode.
+
+    =======================
+    Required Node Structure
+    =======================
+
+    RPMh regulators must be described in two levels of device nodes.  The first
+    level describes the PMIC containing the regulators and must reside within an

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +17 -0

+      For PM8350, smps1 - smps12, ldo1 - ldo10
+      For PM8350C, smps1 - smps10, ldo1 - ldo13, bob
+      For PM8998, smps1 - smps13, ldo1 - ldo28, lvs1 - lvs2
+      For PMI8998, bob
+      For PM6150, smps1 - smps5, ldo1 - ldo19
+      For PM6150L, smps1 - smps8, ldo1 - ldo11, bob
+      For PMX55, smps1 - smps7, ldo1 - ldo16
+
+properties:
+    compatible:
+        enum:
+            - qcom,pm8005-rpmh-regulators
+            - qcom,pm8009-rpmh-regulators
+            - qcom,pm8009-1-rpmh-regulators
+            - qcom,pm8150-rpmh-regulators
+            - qcom,pm8150l-rpmh-regulators
+            - qcom,pm8350-rpmh-regulators

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +17 -0

+    type: object
+    allOf:
+     - $ref: "regulator.yaml#"
+    description: BOB regulator parent supply phandle
+
+additionalProperties: false
+
+required:
+ - compatible
+ - qcom,pmic-id
+
+examples:
+  - |
+    #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+
+    pm8998-rpmh-regulators {
+        compatible = "qcom,pm8998-rpmh-regulators";

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +34 -1

+            regulator-min-microvolt = <1904000>;
+            regulator-max-microvolt = <2040000>;
+        };
+
+        ldo7 {
+            regulator-min-microvolt = <1800000>;
+            regulator-max-microvolt = <1800000>;
+            regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+            regulator-allowed-modes =
+                <RPMH_REGULATOR_MODE_LPM
+                 RPMH_REGULATOR_MODE_HPM>;
+            regulator-allow-set-load;
+        };
+
+        lvs1 {
+            regulator-min-microvolt = <1800000>;
+            regulator-max-microvolt = <1800000>;
+        };
+    };
+
+    pmi8998-rpmh-regulators {
+        compatible = "qcom,pmi8998-rpmh-regulators";
+        qcom,pmic-id = "b";
+
+        bob {
+            regulator-min-microvolt = <3312000>;
+            regulator-max-microvolt = <3600000>;
+            regulator-allowed-modes =
+                <RPMH_REGULATOR_MODE_AUTO
+                 RPMH_REGULATOR_MODE_HPM>;
+            regulator-initial-mode = <RPMH_REGULATOR_MODE_AUTO>;
+        };
+    };
+...
--

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

Quoted 7 lines

+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2
+---
+$id:
http://devicetree.org/schemas/regulator/qcom,rpmh-regulator.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml line 12

Quoted 6 lines

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +6 -0

+title: Qualcomm Technologies, Inc. RPMh Regulators
+
+maintainers:
+  - David Collins <[email protected]>
+
+description:

I assume you want the formatting here maintained, so you need a '|' at the end.

Quoted 34 lines

+ rpmh-regulator devices support PMIC regulator management via the
Voltage
+ Regulator Manager (VRM) and Oscillator Buffer (XOB) RPMh
accelerators. The APPS
+ processor communicates with these hardware blocks via a Resource
State
+ Coordinator (RSC) using command packets. The VRM allows changing
three
+ parameters for a given regulator, enable state, output voltage,
and operating
+ mode. The XOB allows changing only a single parameter for a
given regulator,
+ its enable state. Despite its name, the XOB is capable of
controlling the
+ enable state of any PMIC peripheral. It is used for clock
buffers, low-voltage
+ switches, and LDO/SMPS regulators which have a fixed voltage and
mode.

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +6 -0

+
+    =======================
+    Required Node Structure
+    =======================
+
+    RPMh regulators must be described in two levels of device nodes.  

The first
+ level describes the PMIC containing the regulators and must
reside within an
+ RPMh device node. The second level describes each regulator
within the PMIC
+ which is to be used on the board. Each of these regulators maps
to a single

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +3 -0

+    RPMh resource.
+
+    The names used for regulator nodes must match those supported by 

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml line 38

Quoted 6 lines

a given PMIC.

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +5 -0

+    Supported regulator node names are
+      For PM8005, smps1 - smps4
+      For PM8009, smps1 - smps2, ldo1 - ldo7
+      For PM8150, smps1 - smps10, ldo1 - ldo18
+      For PM8150L, smps1 - smps8, ldo1 - ldo11, bob, flash, rgb

flash and rgb aren't documented.

Quoted 23 lines

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +23 -0

+      For PM8350, smps1 - smps12, ldo1 - ldo10
+      For PM8350C, smps1 - smps10, ldo1 - ldo13, bob
+      For PM8998, smps1 - smps13, ldo1 - ldo28, lvs1 - lvs2
+      For PMI8998, bob
+      For PM6150, smps1 - smps5, ldo1 - ldo19
+      For PM6150L, smps1 - smps8, ldo1 - ldo11, bob
+      For PMX55, smps1 - smps7, ldo1 - ldo16
+
+properties:
+    compatible:
+        enum:
+            - qcom,pm8005-rpmh-regulators
+            - qcom,pm8009-rpmh-regulators
+            - qcom,pm8009-1-rpmh-regulators
+            - qcom,pm8150-rpmh-regulators
+            - qcom,pm8150l-rpmh-regulators
+            - qcom,pm8350-rpmh-regulators
+            - qcom,pm8350c-rpmh-regulators
+            - qcom,pm8998-rpmh-regulators
+            - qcom,pmi8998-rpmh-regulators
+            - qcom,pm6150-rpmh-regulators
+            - qcom,pm6150l-rpmh-regulators
+            - qcom,pmx55-rpmh-regulators

Quoted 6 lines

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +3 -0

+
+    qcom,pmic-id:
+        description: RPMh resource name suffix used for the 

regulators found on
+ this PMIC. Typical values are "a", "b", "c",
"d", "e", "f".

Sounds like constraints. Make the values a schema.

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml line 73

Quoted 11 lines

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +4 -0

+        $ref: /schemas/types.yaml#/definitions/string
+
+    qcom,always-wait-for-ack:
+        description: Boolean flag which indicates that the 

application processor
+ must wait for an ACK or a NACK from RPMh for
every request
+ sent for this regulator including those which
are for a

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +2 -0

+                     strictly lower power state.
+        $ref: /schemas/types.yaml#/definitions/string

Boolean or string?

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml line 76

Quoted 3 lines

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +3 -0

+
+patternProperties:
+  ".*-supply$":

You can drop '.*'. That's already the case without '^'.

The supply names need to be defined.

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml line 80

Quoted 5 lines

+ description: phandle of the parent supply regulator of one or
more of the

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +3 -0

+                 regulators for this PMIC.
+
+  "^((smps|ldo|lvs)[0-9]*)$":

s/*/+/ as 1 digit is always required, right?

Review

Quoted 2 lines

(quoted diff) +2 -0

+    type: object
+    allOf:

Don't need allOf.

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml line 84

Quoted 2 lines

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +2 -0

+     - $ref: "regulator.yaml#"
+    description: List of regulator parent supply phandles

This is a node, not a list of phandles.

Review

Quoted 2 lines

(quoted diff) +2 -0

+
+  "bob$":

'foobob' is okay as that would be allowed? If a fixed string, put under 'properties'.

Quoted 21 lines

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +21 -0

+    type: object
+    allOf:
+     - $ref: "regulator.yaml#"
+    description: BOB regulator parent supply phandle
+
+additionalProperties: false
+
+required:
+ - compatible
+ - qcom,pmic-id
+
+examples:
+  - |
+    #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+
+    pm8998-rpmh-regulators {
+        compatible = "qcom,pm8998-rpmh-regulators";
+        qcom,pmic-id = "a";
+
+        vdd-l7-l12-l14-l15-supply = <&pm8998_s5>;
+

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml line 113

Quoted 6 lines

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +6 -0

+        smps2 {
+            regulator-min-microvolt = <1100000>;
+            regulator-max-microvolt = <1100000>;
+        };
+
+        pm8998_s5: smps5 {

Drop unused labels.

Quoted 30 lines

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +30 -0

+            regulator-min-microvolt = <1904000>;
+            regulator-max-microvolt = <2040000>;
+        };
+
+        ldo7 {
+            regulator-min-microvolt = <1800000>;
+            regulator-max-microvolt = <1800000>;
+            regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+            regulator-allowed-modes =
+                <RPMH_REGULATOR_MODE_LPM
+                 RPMH_REGULATOR_MODE_HPM>;
+            regulator-allow-set-load;
+        };
+
+        lvs1 {
+            regulator-min-microvolt = <1800000>;
+            regulator-max-microvolt = <1800000>;
+        };
+    };
+
+    pmi8998-rpmh-regulators {
+        compatible = "qcom,pmi8998-rpmh-regulators";
+        qcom,pmic-id = "b";
+
+        bob {
+            regulator-min-microvolt = <3312000>;
+            regulator-max-microvolt = <3600000>;
+            regulator-allowed-modes =
+                <RPMH_REGULATOR_MODE_AUTO
+                 RPMH_REGULATOR_MODE_HPM>;

Quoted 8 lines

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml new file +4 -1

+            regulator-initial-mode = <RPMH_REGULATOR_MODE_AUTO>;
+        };
+    };
+...
--

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

Add PM7325/PMR735A compatibles for Qualcomm SC7280 platform.

Signed-off-by satya priya <[email protected]>

---
 Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Correct the REGULATOR_LINEAR_RANGE and n_voltges for pmic5_hfsmps515 buck.

Signed-off-by satya priya <[email protected]>

---
  drivers/regulator/qcom-rpmh-regulator.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

drivers/regulator/qcom-rpmh-regulator.c +0 -0

index 79a554f..36542c3 100644

drivers/regulator/qcom-rpmh-regulator.c +0 -0

  	.pmic_mode_map = pmic_mode_map_pmic5_smps,
  	.of_map_mode = rpmh_regulator_pmic4_smps_of_map_mode,
  };

Quoted 13 lines · satya priya

Correct the REGULATOR_LINEAR_RANGE and n_voltges for pmic5_hfsmps515 buck.

Signed-off-by satya priya <[email protected]>

---
  drivers/regulator/qcom-rpmh-regulator.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

drivers/regulator/qcom-rpmh-regulator.c +0 -0

index 79a554f..36542c3 100644

drivers/regulator/qcom-rpmh-regulator.c static const struct rpmh_vreg_hw_data · line 731

Quoted 8 lines

drivers/regulator/qcom-rpmh-regulator.c +2 -2

@@ -726,8 +726,8 @@ static const struct rpmh_vreg_hw_data 
 pmic5_ftsmps510 = {
  static const struct rpmh_vreg_hw_data pmic5_hfsmps515 = {
  	.regulator_type = VRM,
  	.ops = &rpmh_regulator_vrm_ops,
-	.voltage_range = REGULATOR_LINEAR_RANGE(2800000, 0, 4, 16000),
-	.n_voltages = 5,
+	.voltage_range = REGULATOR_LINEAR_RANGE(320000, 0, 235, 16000),
+	.n_voltages = 236,

I've checked the docs for pm8009, the chip which also uses hfsmps515 regulators. The pdf clearly states that the 'Output voltage operating range' is from 2.8 V to 2.85 V.

So we'd probably need to define different versions of HFS515 regulator data (like I had to create for pm8009-1).

Quoted 4 lines

drivers/regulator/qcom-rpmh-regulator.c +0 -0

  	.pmic_mode_map = pmic_mode_map_pmic5_smps,
  	.of_map_mode = rpmh_regulator_pmic4_smps_of_map_mode,

  };

Hi,

Quoted 28 lines · Dmitry Baryshkov

Quoted 14 lines · satya priya

Correct the REGULATOR_LINEAR_RANGE and n_voltges for pmic5_hfsmps515 buck.

Signed-off-by satya priya <[email protected]>

---
  drivers/regulator/qcom-rpmh-regulator.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

drivers/regulator/qcom-rpmh-regulator.c +0 -0

index 79a554f..36542c3 100644

drivers/regulator/qcom-rpmh-regulator.c static const struct rpmh_vreg_hw_data · line 731

Quoted 8 lines

drivers/regulator/qcom-rpmh-regulator.c +2 -2

@@ -726,8 +726,8 @@ static const struct rpmh_vreg_hw_data
 pmic5_ftsmps510 = {
  static const struct rpmh_vreg_hw_data pmic5_hfsmps515 = {
     .regulator_type = VRM,
     .ops = &rpmh_regulator_vrm_ops,
-    .voltage_range = REGULATOR_LINEAR_RANGE(2800000, 0, 4, 16000),
-    .n_voltages = 5,
+    .voltage_range = REGULATOR_LINEAR_RANGE(320000, 0, 235, 16000),
+    .n_voltages = 236,

I've checked the docs for pm8009, the chip which also uses hfsmps515 regulators. The pdf clearly states that the 'Output voltage operating range' is from 2.8 V to 2.85 V.

Quoted 4 lines

So we'd probably need to define different versions of HFS515 regulator data (like I had to create for pm8009-1).

The min-max voltages for S1C (PM8350c) regulator are 2190000-2210000uV for sc7280(kodiak), so we had to modify this buck to support this regulator.

AFAIK, this struct defines the HW constraints of a regulator, but the platform specific min-max values can be controlled from DT files. So, can't we modify it like above instead of adding a new definition? the new min_uV value (32000) is anyway not exceeding the old value (2800000) right? please correct me if wrong.

Quoted 41 lines · On Fri, 26 Feb 2021 at 09:59, <[email protected]> wrote:

Hi,

Quoted 28 lines · Dmitry Baryshkov

Quoted 14 lines · satya priya

Correct the REGULATOR_LINEAR_RANGE and n_voltges for pmic5_hfsmps515 buck.

Signed-off-by satya priya <[email protected]>

---
  drivers/regulator/qcom-rpmh-regulator.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

drivers/regulator/qcom-rpmh-regulator.c +0 -0

index 79a554f..36542c3 100644

drivers/regulator/qcom-rpmh-regulator.c static const struct rpmh_vreg_hw_data · line 731

Quoted 8 lines

drivers/regulator/qcom-rpmh-regulator.c +2 -2

@@ -726,8 +726,8 @@ static const struct rpmh_vreg_hw_data
 pmic5_ftsmps510 = {
  static const struct rpmh_vreg_hw_data pmic5_hfsmps515 = {
     .regulator_type = VRM,
     .ops = &rpmh_regulator_vrm_ops,
-    .voltage_range = REGULATOR_LINEAR_RANGE(2800000, 0, 4, 16000),
-    .n_voltages = 5,
+    .voltage_range = REGULATOR_LINEAR_RANGE(320000, 0, 235, 16000),
+    .n_voltages = 236,

I've checked the docs for pm8009, the chip which also uses hfsmps515 regulators. The pdf clearly states that the 'Output voltage operating range' is from 2.8 V to 2.85 V.

Quoted 4 lines

So we'd probably need to define different versions of HFS515 regulator data (like I had to create for pm8009-1).

The min-max voltages for S1C (PM8350c) regulator are 2190000-2210000uV for sc7280(kodiak), so we had to modify this buck to support this regulator.

Quoted 5 lines

AFAIK, this struct defines the HW constraints of a regulator, but the platform specific min-max values can be controlled from DT files. So, can't we modify it like above instead of adding a new definition? the new min_uV value (32000) is anyway not exceeding the old value (2800000) right? please correct me if wrong.

As far as I understand for other regulators we put 'output voltage limitations' from the docs into the regulator definition and further constrain it by the platform device tree. Please correct me if I'm wrong.

For pm8009 the data from the datasheet matches the regulators defined in the source file. Unfortunately I don't have kodiak specs at hand.

Quoted 49 lines · Dmitry Baryshkov

Quoted 41 lines · On Fri, 26 Feb 2021 at 09:59, <[email protected]> wrote:

Hi,

Quoted 28 lines · Dmitry Baryshkov

Quoted 14 lines · satya priya

Correct the REGULATOR_LINEAR_RANGE and n_voltges for pmic5_hfsmps515 buck.

Signed-off-by satya priya <[email protected]>

---
  drivers/regulator/qcom-rpmh-regulator.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

drivers/regulator/qcom-rpmh-regulator.c +0 -0

index 79a554f..36542c3 100644

drivers/regulator/qcom-rpmh-regulator.c static const struct rpmh_vreg_hw_data · line 731

Quoted 8 lines

drivers/regulator/qcom-rpmh-regulator.c +2 -2

@@ -726,8 +726,8 @@ static const struct rpmh_vreg_hw_data
 pmic5_ftsmps510 = {
  static const struct rpmh_vreg_hw_data pmic5_hfsmps515 = {
     .regulator_type = VRM,
     .ops = &rpmh_regulator_vrm_ops,
-    .voltage_range = REGULATOR_LINEAR_RANGE(2800000, 0, 4, 16000),
-    .n_voltages = 5,
+    .voltage_range = REGULATOR_LINEAR_RANGE(320000, 0, 235, 16000),
+    .n_voltages = 236,

I've checked the docs for pm8009, the chip which also uses hfsmps515 regulators. The pdf clearly states that the 'Output voltage operating range' is from 2.8 V to 2.85 V.

Quoted 4 lines

So we'd probably need to define different versions of HFS515 regulator data (like I had to create for pm8009-1).

The min-max voltages for S1C (PM8350c) regulator are 2190000-2210000uV for sc7280(kodiak), so we had to modify this buck to support this regulator.

Quoted 6 lines

AFAIK, this struct defines the HW constraints of a regulator, but the platform specific min-max values can be controlled from DT files. So, can't we modify it like above instead of adding a new definition? the new min_uV value (32000) is anyway not exceeding the old value (2800000)
right? please correct me if wrong.

Quoted 4 lines

As far as I understand for other regulators we put 'output voltage limitations' from the docs into the regulator definition and further constrain it by the platform device tree. Please correct me if I'm wrong.

I see that for most of the regulators, these specifications are specific to regulator buck (like HFS515) but not chipset specific, we set the chipset specific(like pm8009/pm8350c) requirements from DT files.

For example:
pmic5_nldo regulator spec mentions LLIMIT= 0.32V and ULIMIT =1.304V with step 8mV

.voltage_range = REGULATOR_LINEAR_RANGE(320000, 0, 123, 8000), max output voltage supported by this regulator is 123*8000 + 320000 = 1304000mV which is same as mentioned in the regulator spec.

Quoted 2 lines

For pm8009 the data from the datasheet matches the regulators defined in the source file. Unfortunately I don't have kodiak specs at hand.

From the HFS515 spec I got below info
"HFS510 and lower max output voltage is limited to 2.04V max, and Yoda(pm8009) requirement was 2.4V for IOT PA and 2.85V for camera application. Hence, HFS515 added a new register and corresponding HW changes to support the higher voltage. Table 5‑24 shows the new FB_RANGE bit. When configured to 0 the buck works as earlier where Vout max = 2.04V in 8mV steps, but when configured to 1 the buck range doubles and can now support a Vout max = 4.08V in 16mV steps."

As per above, the max output voltage supported by HFS515 buck is 4.08V (which is kodiak pm8350c pmic's requirement).
So, we have modified the buck data to support pm8350c(palani) along with pm8009(yoda).

Hello,

Quoted 80 lines · On Mon, 1 Mar 2021 at 13:37, <[email protected]> wrote:

Quoted 49 lines · Dmitry Baryshkov

Quoted 41 lines · On Fri, 26 Feb 2021 at 09:59, <[email protected]> wrote:

Hi,

Quoted 28 lines · Dmitry Baryshkov

Quoted 14 lines · satya priya

Correct the REGULATOR_LINEAR_RANGE and n_voltges for pmic5_hfsmps515 buck.

Signed-off-by satya priya <[email protected]>

---
  drivers/regulator/qcom-rpmh-regulator.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

drivers/regulator/qcom-rpmh-regulator.c +0 -0

index 79a554f..36542c3 100644

drivers/regulator/qcom-rpmh-regulator.c static const struct rpmh_vreg_hw_data · line 731

Quoted 8 lines

drivers/regulator/qcom-rpmh-regulator.c +2 -2

@@ -726,8 +726,8 @@ static const struct rpmh_vreg_hw_data
 pmic5_ftsmps510 = {
  static const struct rpmh_vreg_hw_data pmic5_hfsmps515 = {
     .regulator_type = VRM,
     .ops = &rpmh_regulator_vrm_ops,
-    .voltage_range = REGULATOR_LINEAR_RANGE(2800000, 0, 4, 16000),
-    .n_voltages = 5,
+    .voltage_range = REGULATOR_LINEAR_RANGE(320000, 0, 235, 16000),
+    .n_voltages = 236,

I've checked the docs for pm8009, the chip which also uses hfsmps515 regulators. The pdf clearly states that the 'Output voltage operating range' is from 2.8 V to 2.85 V.

Quoted 4 lines

So we'd probably need to define different versions of HFS515 regulator data (like I had to create for pm8009-1).

The min-max voltages for S1C (PM8350c) regulator are 2190000-2210000uV for sc7280(kodiak), so we had to modify this buck to support this regulator.

Quoted 6 lines

AFAIK, this struct defines the HW constraints of a regulator, but the platform specific min-max values can be controlled from DT files. So, can't we modify it like above instead of adding a new definition? the new min_uV value (32000) is anyway not exceeding the old value (2800000)
right? please correct me if wrong.

Quoted 4 lines

As far as I understand for other regulators we put 'output voltage limitations' from the docs into the regulator definition and further constrain it by the platform device tree. Please correct me if I'm wrong.

I see that for most of the regulators, these specifications are specific to regulator buck (like HFS515) but not chipset specific, we set the chipset specific(like pm8009/pm8350c) requirements from DT files.

For example:
pmic5_nldo regulator spec mentions LLIMIT= 0.32V and ULIMIT =1.304V with step 8mV

.voltage_range = REGULATOR_LINEAR_RANGE(320000, 0, 123, 8000), max output voltage supported by this regulator is 123*8000 + 320000 = 1304000mV which is same as mentioned in the regulator spec.

Quoted 2 lines

For pm8009 the data from the datasheet matches the regulators defined in the source file. Unfortunately I don't have kodiak specs at hand.

From the HFS515 spec I got below info
"HFS510 and lower max output voltage is limited to 2.04V max, and Yoda(pm8009) requirement was 2.4V for IOT PA and 2.85V for camera application. Hence, HFS515 added a new register and corresponding HW changes to support the higher voltage. Table 5‑24 shows the new FB_RANGE bit. When configured to 0 the buck works as earlier where Vout max = 2.04V in 8mV steps, but when configured to 1 the buck range doubles and can now support a Vout max = 4.08V in 16mV steps."

Quoted 4 lines

As per above, the max output voltage supported by HFS515 buck is 4.08V (which is kodiak pm8350c pmic's requirement).
So, we have modified the buck data to support pm8350c(palani) along with pm8009(yoda).

I'd still prefer to have two different regulator types (as we did for pm8009 P=0 and P=1 variants). However it's probably up to the maintainers to decide.

Quoted 3 lines · Dmitry Baryshkov

I'd still prefer to have two different regulator types (as we did for pm8009 P=0 and P=1 variants). However it's probably up to the maintainers to decide.

As Mark already picked this, I think we can leave it this way.

Use correct buck, that is, pmic5_hfsmps515 for S1C regulator of PM8350C PMIC.

Quoted 2 lines · satya priya

Use correct buck, that is, pmic5_hfsmps515 for S1C regulator of PM8350C PMIC.

Fixes like this and patch 3 should be at the start of the series, this ensures that they have no dependencies and can easily be sent to Linus as fixes.

Hi,

arch/arm64/boot/dts/qcom/sc7280-idp.dts line 125

Quoted 7 lines

arch/arm64/boot/dts/qcom/sc7280-idp.dts +7 -0

+	};
+
+	pm8350c-regulators {
+	compatible = "qcom,pm8350c-rpmh-regulators";
+	qcom,pmic-id = "c";
+		vreg_s1c_2p2: smps1 {
+			regulator-min-microvolt = <2190000>;

The indentation on "compatible" and "qcom,pmic-id" is off.

Konrad

This series is dependent on below series which adds DT files for SC7280 SoC
https://lore.kernel.org/patchwork/project/lkml/list/?series=484757

satya priya (7):
dt-bindings: regulator: Convert regulator bindings to YAML
dt-bindings: regulator: Add compatibles for PM7325/PMR735A
regulator: qcom-rpmh: Correct the pmic5_hfsmps515 buck
regulator: qcom-rpmh: Add pmic5_ftsmps520 buck
regulator: qcom-rpmh: Add PM7325/PMR735A regulator support
regulator: qcom-rpmh: Use correct buck for S1C regulator
arm64: dts: qcom: sc7280: Add RPMh regulators for sc7280-idp

[...]