RDMA/hw/hfi1/tid_rdma: remove unnecessary conversion to bool
Subsystems (2)
PATCH 1/1 RDMA/hw/hfi1/tid_rdma: remove unnecessary conversion to bool
Fix the following coccicheck warnings:
./drivers/infiniband/hw/hfi1/tid_rdma.c:1118:36-41: WARNING: conversion to bool not needed here.
Reported-by Abaci Robot <[email protected]>
Signed-off-by Jiapeng Chong <[email protected]>
--- drivers/infiniband/hw/hfi1/tid_rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/hfi1/tid_rdma.c +1 -1
@@ -1115,7 +1115,7 @@ static u32 kern_find_pages(struct tid_rdma_flow *flow, } flow->length = flow->req->seg_len - length; - *last = req->isge == ss->num_sge ? false : true; + *last = req->isge == !ss->num_sge;return i; }
Signature · 1 line
1.8.3.1
Quoted 16 lines · Jiapeng Chong
Fix the following coccicheck warnings:
./drivers/infiniband/hw/hfi1/tid_rdma.c:1118:36-41: WARNING: conversion to bool not needed here.
Reported-by Abaci Robot <[email protected]>Signed-off-by Jiapeng Chong <[email protected]>--- drivers/infiniband/hw/hfi1/tid_rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/infiniband/hw/hfi1/tid_rdma.c +0
-0
drivers/infiniband/hw/hfi1/tid_rdma.c static u32 kern_find_pages(struct tid_rdma_flow *flow, · line 1118
Quoted 5 lines
drivers/infiniband/hw/hfi1/tid_rdma.c +1
-1@@ -1115,7 +1115,7 @@ static u32 kern_find_pages(struct tid_rdma_flow *flow, } flow->length = flow->req->seg_len - length; - *last = req->isge == ss->num_sge ? false : true; + *last = req->isge == !ss->num_sge;
Are you sure this is what you want? The new code seems to compare an index to a bool (refactoring)
*last = req->isge == (ss->num_sge != 0);
Don't you actually want
*last = req->isge != ss->num_sge;
??
Even then, it seems really hard to read.
Quoted 4 lines
drivers/infiniband/hw/hfi1/tid_rdma.c +0
-0return i; }