Skip to contentSkip to conversation

crypto/nx: add missing call to of_node_put()

PATCH In review Yang Li 2 participants 2 messages Feb 26, 2021 – Mar 4, 2021

Subsystems (2)
PowerPC Crypto API
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH v2 1/1 crypto/nx: add missing call to of_node_put()

In one of the error paths of the for_each_child_of_node() loop, add missing call to of_node_put().

Fix the following coccicheck warning:
./drivers/crypto/nx/nx-common-powernv.c:927:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 936.

Reported-by Abaci Robot <[email protected]>
Signed-off-by Yang Li <[email protected]>

---

Changes in v2:
-add braces for if

 drivers/crypto/nx/nx-common-powernv.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/crypto/nx/nx-common-powernv.c +3 -1
index 13c65de..446f611 100644
@@ -932,8 +932,10 @@ static int __init nx_powernv_probe_vas(struct device_node *pn)
 			ret = find_nx_device_tree(dn, chip_id, vasid,
 				NX_CT_GZIP, "ibm,p9-nx-gzip", &ct_gzip);
 
-		if (ret)
+		if (ret) {
+			of_node_put(dn);
 			return ret;
+		}
 	}
 
 	if (!ct_842 || !ct_gzip) {
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw
Quoted 10 lines · Yang Li

In one of the error paths of the for_each_child_of_node() loop, add missing call to of_node_put().

Fix the following coccicheck warning:
./drivers/crypto/nx/nx-common-powernv.c:927:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 936.

Reported-by Abaci Robot <[email protected]>
Signed-off-by Yang Li <[email protected]>
Quoted 7 lines

---

Changes in v2:
-add braces for if

 drivers/crypto/nx/nx-common-powernv.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt