Skip to contentSkip to conversation

spi: spi-qcom-qspi: Use irq trigger flags from firmware

PATCH Applied Stephen Boyd 4 participants 4 messages Jan 12, 2021 – Mar 1, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 spi: spi-qcom-qspi: Use irq trigger flags from firmware

We don't need to force this to be trigger high here, as the firmware properly configures the irq flags already. Drop it to save a line.

Cc Douglas Anderson <[email protected]>
Cc Rajendra Nayak <[email protected]>
Cc Mukesh Kumar Savaliya <[email protected]>
Cc Akash Asthana <[email protected]>

---

Changes from v1:
* Rebased onto v5.11-rc1

 drivers/spi/spi-qcom-qspi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/spi/spi-qcom-qspi.c +1 -2
index 8863be370884..1dbcc410cd35 100644
@@ -511,8 +511,7 @@ static int qcom_qspi_probe(struct platform_device *pdev)
 	ret = platform_get_irq(pdev, 0);
 	if (ret < 0)
 		return ret;
-	ret = devm_request_irq(dev, ret, qcom_qspi_irq,
-			IRQF_TRIGGER_HIGH, dev_name(dev), ctrl);
+	ret = devm_request_irq(dev, ret, qcom_qspi_irq, 0, dev_name(dev), ctrl);
 	if (ret) {
 		dev_err(dev, "Failed to request irq %d\n", ret);
 		return ret;

base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e

Signature · 1 line
https://chromeos.dev
Reviewed-by on v2 1/1
#1 lore raw

Hi,

Quoted 9 lines · Stephen Boyd

We don't need to force this to be trigger high here, as the firmware properly configures the irq flags already. Drop it to save a line.

Cc Douglas Anderson <[email protected]>
Cc Rajendra Nayak <[email protected]>
Cc Mukesh Kumar Savaliya <[email protected]>
Cc Akash Asthana <[email protected]>
Quoted 7 lines

---

Changes from v1:
* Rebased onto v5.11-rc1

 drivers/spi/spi-qcom-qspi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
maintainer
#2 lore raw
In reply to Stephen Boyd
Quoted 2 lines · Stephen Boyd

We don't need to force this to be trigger high here, as the firmware properly configures the irq flags already. Drop it to save a line.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: spi-qcom-qspi: Use irq trigger flags from firmware

      commit: eaecba8767835783bdd2f4e72406668cda7d8d54

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

#3 lore raw
In reply to Stephen Boyd
This patch was applied to qcom/linux.git (refs/heads/for-next):

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

Quoted 10 lines · On Mon, 11 Jan 2021 16:13:01 -0800 you wrote:

We don't need to force this to be trigger high here, as the firmware properly configures the irq flags already. Drop it to save a line.

Cc Douglas Anderson <[email protected]>
Cc Rajendra Nayak <[email protected]>
Cc Mukesh Kumar Savaliya <[email protected]>
Cc Akash Asthana <[email protected]>

[...]

Here is the summary with links:
- [v2] spi: spi-qcom-qspi: Use irq trigger flags from firmware

    https://git.kernel.org/qcom/c/eaecba876783

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html