f2fs: allow to change discard policy based on cached discard cmds
PATCH 1/1 f2fs: allow to change discard policy based on cached discard cmds
With the default DPOLICY_BG discard thread is ioaware, which prevents the discard thread from issuing the discard commands. On low RAM setups, it is observed that these discard commands in the cache are consuming high memory. This patch aims to relax the memory pressure on the system due to f2fs pending discard cmds by changing the policy to DPOLICY_FORCE based on the nm_i->ram_thresh configured.
--- fs/f2fs/node.c | 7 ++++++- fs/f2fs/node.h | 1 + fs/f2fs/segment.c | 3 ++- 3 files changed, 9 insertions(+), 2 deletions(-)
fs/f2fs/node.c +6 -1
@@ -44,6 +44,7 @@ int f2fs_check_nid_range(struct f2fs_sb_info *sbi, nid_t nid)bool f2fs_available_free_memory (struct f2fs_sb_info *sbi,int type) {struct f2fs_nm_info *nm_i =NM_I (sbi); +struct discard_cmd_control *dcc =SM_I (sbi)->dcc_info;struct sysinfo val;unsigned long avail_ram;unsigned long mem_size =0 ;
@@ -90,7 +91,11 @@ bool f2fs_available_free_memory(struct f2fs_sb_info *sbi, int type)/* it allows 20% / total_ram for inmemory pages */ mem_size =get_pages (sbi,F2FS_INMEM_PAGES ); res = mem_size < (val.totalram /5 ); - }else { + }else if (type ==DISCARD_CACHE ) { + mem_size = (atomic_read (&dcc->discard_cmd_cnt) * +sizeof (struct discard_cmd )) >>PAGE_SHIFT ; + res = mem_size < ((avail_ram * nm_i->ram_thresh /100 )); + }else if (type ==NAT_ENTRIES ) {if (!sbi->sb->s_bdi->wb.dirty_exceeded)return true; }
fs/f2fs/node.h +1 -0
@@ -147,6 +147,7 @@ enum mem_type {INO_ENTRIES ,/* indicates inode entries */ EXTENT_CACHE ,/* indicates extent cache */ INMEM_PAGES ,/* indicates inmemory pages */ +DISCARD_CACHE ,/* indicates memory of cached discard cmds */ BASE_CHECK, /* check kernel status */ };
fs/f2fs/segment.c +2 -1
@@ -1773,7 +1773,8 @@ static int issue_discard_thread(void *data)continue ; } -if (sbi->gc_mode ==GC_URGENT_HIGH ) +if (sbi->gc_mode ==GC_URGENT_HIGH || + !f2fs_available_free_memory (sbi,DISCARD_CACHE ))__init_discard_policy (sbi, &dpolicy,DPOLICY_FORCE ,1 );sb_start_intwrite (sbi->sb);
Signature · 9 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Quoted 6 lines · Sahitya Tummala
With the default
DPOLICY_BGdiscard thread is ioaware, which prevents the discard thread from issuing the discard commands. On low RAM setups, it is observed that these discard commands in the cache are consuming high memory. This patch aims to relax the memory pressure on the system due to f2fs pending discard cmds by changing the policy toDPOLICY_FORCEbased on thenm_i->ram_threshconfigured.
Agreed.
Quoted 2 lines
Signed-off-by Sahitya Tummala <[email protected]>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel