Skip to contentSkip to conversation

patch "usb: typec: Remove vdo[3] part of tps6598x_rx_identity_reg struct" added to usb-linus

PATCH [email protected] 1 participant 1 message Mar 17, 2021

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

usb: typec: Remove vdo[3] part of tps6598x_rx_identity_reg struct

to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.

If you have any questions about this process, please let me know.

From 3cac9104bea41099cf622091f0c0538bcb19050d Mon Sep 17 00:00:00 2001
From: Elias Rudberg <[email protected]>
Date: Thu, 11 Mar 2021 13:47:10 +0100
Subject: usb: typec: Remove vdo[3] part of tps6598x_rx_identity_reg struct
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Remove the unused "u32 vdo[3]" part in the tps6598x_rx_identity_reg struct. This helps avoid "failed to register partner" errors which happen when tps6598x_read_partner_identity() fails because the amount of data read is 12 bytes smaller than the struct size. Note that vdo[3] is already in usb_pd_identity and hence shouldn't be added to tps6598x_rx_identity_reg as well.

Fixes f6c56ca91b92 ("usb: typec: Add the Product Type VDOs to struct usb_pd_identity")
Cc stable <[email protected]>
---
 drivers/usb/typec/tps6598x.c | 1 -
 1 file changed, 1 deletion(-)
drivers/usb/typec/tps6598x.c +0 -1
index 6e6ef6317523..29bd1c5a283c 100644
@@ -64,7 +64,6 @@ enum {
 struct tps6598x_rx_identity_reg {
 	u8 status;
 	struct usb_pd_identity identity;
-	u32 vdo[3];
 } __packed;
 
 /* Standard Task return codes */
Signature · 1 line
2.30.2