drm/msm/disp/dpu1: fix display underruns during modeset.
PATCH 1/1 drm/msm/disp/dpu1: fix display underruns during modeset.
During crtc disable, display perf structures are reset to 0 which includes state varibles which are immutable. On crtc enable, we use the same structures and they don't refelect the actual values
1) Fix is to avoid updating the state structures during disable.
2) Reset the perf structures during atomic check when there is no modeset enable.
--- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c +0 -1
@@ -382,7 +382,6 @@ int dpu_core_perf_crtc_update(struct drm_crtc *crtc, }else {DPU_DEBUG ("crtc=%d disable\n" , crtc->base.id);memset (old,0 ,sizeof (*old)); -memset (new,0 ,sizeof (*new)); update_bus = true; update_clk = true; }
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +1 -0
@@ -912,6 +912,7 @@ static int dpu_crtc_atomic_check(struct drm_crtc *crtc,if (!state->enable || !state->active) {DPU_DEBUG ("crtc%d -> enable %d, active %d, skip atomic_check\n" , crtc->base.id, state->enable, state->active); +memset (&cstate->new_perf,0 ,sizeof (cstate->new_perf)); goto end; }
Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi,
Quoted 10 lines · Kalyan Thota
During crtc disable, display perf structures are reset to 0 which includes state varibles which are immutable. On crtc enable, we use the same structures and they don't refelect the actual values
1) Fix is to avoid updating the state structures during disable.
2) Reset the perf structures during atomic check when there is no modeset enable.
Quoted 5 lines
Signed-off-by Kalyan Thota <[email protected]>--- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-)
I think Stephen was the one who originally noticed this and reported it, so:
Seems to work for me. I got into the state where it was doing a modeset at reboot (could see the underflow color for a period of time when this happened). I added your patch and it looks better.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel