sched/topology: Make some symbols static
Subsystems (2)
PATCH 1/1 sched/topology: Make some symbols static
The sparse tool complains as follows:
kernel/sched/topology.c:211:1: warning:
symbol 'sched_energy_mutex' was not declared. Should it be static?kernel/sched/topology.c:212:6: warning:
symbol 'sched_energy_update' was not declared. Should it be static?
This symbol is not used outside of topology.c, so this commit marks it static.
--- kernel/sched/topology.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/sched/topology.c +2 -2
@@ -208,8 +208,8 @@ sd_parent_degenerate(struct sched_domain *sd, struct sched_domain *parent)#if defined(CONFIG_ENERGY_MODEL ) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL )DEFINE_STATIC_KEY_FALSE (sched_energy_present);unsigned int sysctl_sched_energy_aware =1 ; -DEFINE_MUTEX (sched_energy_mutex); -bool sched_energy_update; +static DEFINE_MUTEX (sched_energy_mutex); +static bool sched_energy_update;void rebuild_sched_domains_energy (void ) {
Quoted 22 lines · Peng Wu
The sparse tool complains as follows:
kernel/sched/topology.c:211:1: warning:
symbol 'sched_energy_mutex' was not declared. Should it be static?kernel/sched/topology.c:212:6: warning:
symbol 'sched_energy_update' was not declared. Should it be static?This symbol is not used outside of
topology.c, so this commit marks it static.Reported-by Hulk Robot <[email protected]>Signed-off-by Peng Wu <[email protected]>--- kernel/sched/topology.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)kernel/sched/topology.c +0
-0
kernel/sched/topology.c sd_parent_degenerate(struct sched_domain *sd, struct sched_domain *parent) · line 215
Quoted 10 lines
kernel/sched/topology.c +2
-2@@ -208,8 +208,8 @@ sd_parent_degenerate(struct sched_domain *sd, struct sched_domain *parent)#if defined(CONFIG_ENERGY_MODEL ) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL )DEFINE_STATIC_KEY_FALSE (sched_energy_present);unsigned int sysctl_sched_energy_aware =1 ; -DEFINE_MUTEX (sched_energy_mutex); -bool sched_energy_update; +static DEFINE_MUTEX (sched_energy_mutex); +static bool sched_energy_update;void rebuild_sched_domains_energy (void ) {
FWIW, that has been reported some time ago:
https://lore.kernel.org/lkml/[email protected]/
https://lore.kernel.org/lkml/[email protected]/
But otherwise, this looks OK to me.
Thanks,
Quentin