RDMA/hns: Remove unnecessary flush operation for workqueue
Subsystems (2)
PATCH 1/1 RDMA/hns: Remove unnecessary flush operation for workqueue
From: Yixian Liu <[email protected]>
As flush operation is implemented inside destroy workqueue, there is no need to do flush operation before destroying workqueue.
Fixes bfcc681bd09d ("IB/hns: Fix the bug when free mr")
Fixes 0425e3e6e0c7 ("RDMA/hns: Support flush cqe for hip08 in kernel space")
Signed-off-by Yixian Liu <[email protected]>
Signed-off-by Weihang Li <[email protected]>
--- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 -- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 1 - 2 files changed, 3 deletions(-)
drivers/infiniband/hw/hns/hns_roce_hw_v1.c +0 -2
@@ -1382,7 +1382,6 @@ static int hns_roce_free_mr_init(struct hns_roce_dev *hr_dev) ret =hns_roce_v1_rsv_lp_qp (hr_dev);if (ret) {dev_err (dev,"Reserved loop qp failed(%d)!\n" , ret); -flush_workqueue (free_mr->free_mr_wq);destroy_workqueue (free_mr->free_mr_wq); }
@@ -1394,7 +1393,6 @@ static void hns_roce_free_mr_free(struct hns_roce_dev *hr_dev)struct hns_roce_v1_priv *priv = hr_dev->priv;struct hns_roce_free_mr *free_mr = &priv->free_mr; -flush_workqueue (free_mr->free_mr_wq);destroy_workqueue (free_mr->free_mr_wq);hns_roce_v1_release_lp_qp (hr_dev);
drivers/infiniband/hw/hns/hns_roce_hw_v2.c +0 -1
@@ -6404,7 +6404,6 @@ static void hns_roce_v2_cleanup_eq_table(struct hns_roce_dev *hr_dev)hns_roce_v2_int_mask_enable (hr_dev, eq_num,EQ_DISABLE );__hns_roce_free_irq (hr_dev); -flush_workqueue (hr_dev->irq_workq);destroy_workqueue (hr_dev->irq_workq);for (i =0 ; i < eq_num; i++) {
Signature · 1 line
2.8.1
Quoted 5 lines · Weihang Li
From: Yixian Liu <[email protected]>
As flush operation is implemented inside destroy workqueue, there is no need to do flush operation before destroying workqueue.
Quoted 8 lines
Fixes bfcc681bd09d ("IB/hns: Fix the bug when free mr")Fixes 0425e3e6e0c7 ("RDMA/hns: Support flush cqe for hip08 in kernel space")Signed-off-by Yixian Liu <[email protected]>Signed-off-by Weihang Li <[email protected]>--- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 -- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 1 - 2 files changed, 3 deletions(-)
Applied to for-next, thanks
Jason