ASoC: tegra: mark runtime-pm functions as __maybe_unused
Subsystems (3)
PATCH 1/1 ASoC: tegra: mark runtime-pm functions as __maybe_unused
From: Arnd Bergmann <[email protected]>
A reorganization of the driver source led to two of them causing a compile time warning in some configurations:
tegra/tegra20_spdif.c:36:12: error: 'tegra20_spdif_runtime_resume' defined but not used [-Werror=unused-function]
36 | static int tegra20_spdif_runtime_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
tegra/tegra20_spdif.c:27:12: error: 'tegra20_spdif_runtime_suspend' defined but not used [-Werror=unused-function]
27 | static int tegra20_spdif_runtime_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tegra/tegra30_ahub.c:64:12: error: 'tegra30_ahub_runtime_resume' defined but not used [-Werror=unused-function]
64 | static int tegra30_ahub_runtime_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
tegra/tegra30_ahub.c:43:12: error: 'tegra30_ahub_runtime_suspend' defined but not used [-Werror=unused-function]
43 | static int tegra30_ahub_runtime_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~Mark these functions as __maybe_unused to avoid this kind of warning.
--- sound/soc/tegra/tegra20_i2s.c | 4 ++-- sound/soc/tegra/tegra20_spdif.c | 4 ++-- sound/soc/tegra/tegra30_ahub.c | 4 ++-- sound/soc/tegra/tegra30_i2s.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-)
sound/soc/tegra/tegra20_i2s.c +2 -2
@@ -34,7 +34,7 @@#define DRV_NAME "tegra20-i2s" -static int tegra20_i2s_runtime_suspend (struct device *dev) +static __maybe_unused int tegra20_i2s_runtime_suspend (struct device *dev) {struct tegra20_i2s *i2s =dev_get_drvdata (dev);
@@ -45,7 +45,7 @@ static int tegra20_i2s_runtime_suspend(struct device *dev)return 0 ; } -static int tegra20_i2s_runtime_resume (struct device *dev) +static __maybe_unused int tegra20_i2s_runtime_resume (struct device *dev) {struct tegra20_i2s *i2s =dev_get_drvdata (dev);int ret;
sound/soc/tegra/tegra20_spdif.c +2 -2
@@ -24,7 +24,7 @@#define DRV_NAME "tegra20-spdif" -static int tegra20_spdif_runtime_suspend (struct device *dev) +static __maybe_unused int tegra20_spdif_runtime_suspend (struct device *dev) {struct tegra20_spdif *spdif =dev_get_drvdata (dev);
@@ -33,7 +33,7 @@ static int tegra20_spdif_runtime_suspend(struct device *dev)return 0 ; } -static int tegra20_spdif_runtime_resume (struct device *dev) +static __maybe_unused int tegra20_spdif_runtime_resume (struct device *dev) {struct tegra20_spdif *spdif =dev_get_drvdata (dev);int ret;
sound/soc/tegra/tegra30_ahub.c +2 -2
@@ -40,7 +40,7 @@ static inline void tegra30_audio_write(u32 reg, u32 val)regmap_write (ahub->regmap_ahub, reg, val); } -static int tegra30_ahub_runtime_suspend (struct device *dev) +static __maybe_unused int tegra30_ahub_runtime_suspend (struct device *dev) {regcache_cache_only (ahub->regmap_apbif, true);regcache_cache_only (ahub->regmap_ahub, true);
@@ -61,7 +61,7 @@ static int tegra30_ahub_runtime_suspend(struct device *dev)* stopping streams should dynamically adjust the clock as required. However, * this is not yet implemented. */ -static int tegra30_ahub_runtime_resume (struct device *dev) +static __maybe_unused int tegra30_ahub_runtime_resume (struct device *dev) {int ret;
sound/soc/tegra/tegra30_i2s.c +2 -2
@@ -36,7 +36,7 @@#define DRV_NAME "tegra30-i2s" -static int tegra30_i2s_runtime_suspend (struct device *dev) +static __maybe_unused int tegra30_i2s_runtime_suspend (struct device *dev) {struct tegra30_i2s *i2s =dev_get_drvdata (dev);
@@ -47,7 +47,7 @@ static int tegra30_i2s_runtime_suspend(struct device *dev)return 0 ; } -static int tegra30_i2s_runtime_resume (struct device *dev) +static __maybe_unused int tegra30_i2s_runtime_resume (struct device *dev) {struct tegra30_i2s *i2s =dev_get_drvdata (dev);int ret;
Signature · 1 line
2.29.2
Mark Brown
maintainerQuoted 16 lines · Arnd Bergmann
A reorganization of the driver source led to two of them causing a compile time warning in some configurations:
tegra/tegra20_spdif.c:36:12: error: 'tegra20_spdif_runtime_resume' defined but not used [-Werror=unused-function]
36 | static inttegra20_spdif_runtime_resume(struct device *dev)| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ tegra/tegra20_spdif.c:27:12: error: 'tegra20_spdif_runtime_suspend' defined but not used [-Werror=unused-function] 27 | static int tegra20_spdif_runtime_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tegra/tegra30_ahub.c:64:12: error: 'tegra30_ahub_runtime_resume' defined but not used [-Werror=unused-function] 64 | static int tegra30_ahub_runtime_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ tegra/tegra30_ahub.c:43:12: error: 'tegra30_ahub_runtime_suspend' defined but not used [-Werror=unused-function] 43 | static int tegra30_ahub_runtime_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
Quoted 1 line
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: tegra: mark runtime-pm functions as __maybe_unused
commit: ccd4cc3ed0692aef8a3b4566391c37eb168d8d32
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark