mtd: return -ENOMEM when kmalloc failed
PATCH 1/1 mtd: return -ENOMEM when kmalloc failed
The driver is using -1 instead of the -ENOMEM defined macro to specify that a buffer allocation failed. Using the correct error code is more intuitive
Smatch tool warning:drivers/mtd/inftlmount.c:333 check_free_sectors() warn: returning -1 instead of -ENOMEM is sloppydrivers/mtd/nftlmount.c:272 check_free_sectors() warn: returning -1 instead of -ENOMEM is sloppy
No functional change, just more standardized.
--- drivers/mtd/inftlmount.c | 2 +- drivers/mtd/nftlmount.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/mtd/inftlmount.c +1 -1
@@ -330,7 +330,7 @@ static int check_free_sectors(struct INFTLrecord *inftl, unsigned int address, buf =kmalloc (SECTORSIZE + mtd->oobsize,GFP_KERNEL );if (!buf) -return -1 ; +return -ENOMEM ; ret =-1 ;for (i =0 ; i < len; i +=SECTORSIZE ) {
drivers/mtd/nftlmount.c +1 -1
@@ -269,7 +269,7 @@ static int check_free_sectors(struct NFTLrecord *nftl, unsigned int address, int buf =kmalloc (SECTORSIZE + mtd->oobsize,GFP_KERNEL );if (!buf) -return -1 ; +return -ENOMEM ; ret =-1 ;for (i =0 ; i < len; i +=SECTORSIZE ) {
Signature · 1 line
1.8.3.1
Quoted 10 lines · Yang Li
The driver is using -1 instead of the
-ENOMEMdefined macro to specify that a buffer allocation failed. Using the correct error code is more intuitiveSmatch tool warning:
drivers/mtd/inftlmount.c:333check_free_sectors()warn: returning -1 instead of-ENOMEMis sloppydrivers/mtd/nftlmount.c:272check_free_sectors()warn: returning -1 instead of-ENOMEMis sloppy
Quoted 4 lines
No functional change, just more standardized.
Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/