kvm/x86: Fix 'lpages' kvm stat for TDM MMU
PATCH v2 1/1 kvm/x86: Fix 'lpages' kvm stat for TDM MMU
Large pages not being created properly may result in increased memory access time. The 'lpages' kvm stat used to keep track of the current number of large pages in the system, but with TDP MMU enabled the stat is not showing the correct number.
This patch extends the lpages counter to cover the TDP case.
--- arch/x86/kvm/mmu/tdp_mmu.c | 7 +++++++ 1 file changed, 7 insertions(+)
arch/x86/kvm/mmu/tdp_mmu.c +7 -0
@@ -240,6 +240,13 @@ static void __handle_changed_spte(struct kvm *kvm, int as_id, gfn_t gfn,if (old_spte == new_spte)return ; +if (is_large_pte (old_spte) !=is_large_pte (new_spte)) { +if (is_large_pte (old_spte)) +atomic64_sub (1 , (atomic64_t *)&kvm->stat.lpages); +else +atomic64_add (1 , (atomic64_t *)&kvm->stat.lpages); + } +/* * The only times a SPTE should be changed from a non-present to * non-present state is when an MMIO entry is installed/modified/
Signature · 11 lines
2.17.1 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879
Quoted 10 lines · Md Shahadat Hossain
Large pages not being created properly may result in increased memory access time. The 'lpages' kvm stat used to keep track of the current number of large pages in the system, but with TDP MMU enabled the stat is not showing the correct number.
This patch extends the lpages counter to cover the TDP case.
Signed-off-by Md Shahadat Hossain Shahin <[email protected]>Cc Bartosz Szczepanek <[email protected]>
Thanks for fixing this!
Quoted 37 lines
--- arch/x86/kvm/mmu/tdp_mmu.c | 7 +++++++ 1 file changed, 7 insertions(+)arch/x86/kvm/mmu/tdp_mmu.c +7
-1@@ -240,6 +240,13 @@ static void __handle_changed_spte(struct kvm *kvm, int as_id, gfn_t gfn,if (old_spte == new_spte)return ; +if (is_large_pte (old_spte) !=is_large_pte (new_spte)) { +if (is_large_pte (old_spte)) +atomic64_sub (1 , (atomic64_t *)&kvm->stat.lpages); +else +atomic64_add (1 , (atomic64_t *)&kvm->stat.lpages); + } +/* * The only times a SPTE should be changed from a non-present to * non-present state is when an MMIO entry is installed/modified/ -- 2.17.1
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879