Skip to contentSkip to conversation

trace: replace WB_REASON_FOREIGN_FLUSH with a string

PATCH In review brookxu 2 participants 3 messages May 2, 2021 – May 14, 2021

Subsystems (2)
lore
Share & tools
lore

brookxu

author
#0 lore raw

PATCH v2 1/1 trace: replace WB_REASON_FOREIGN_FLUSH with a string

From: Chunguang Xu <[email protected]>

Now WB_REASON_FOREIGN_FLUSH is displayed as a number, maybe a string is better.

v2: replace some space with tab.

---
 include/trace/events/writeback.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/trace/events/writeback.h +2 -1
index 1efa463..7c78c04 100644
@@ -36,7 +36,8 @@
 	EM( WB_REASON_PERIODIC,			"periodic")		\
 	EM( WB_REASON_LAPTOP_TIMER,		"laptop_timer")		\
 	EM( WB_REASON_FS_FREE_SPACE,		"fs_free_space")	\
-	EMe(WB_REASON_FORKER_THREAD,		"forker_thread")
+	EM( WB_REASON_FORKER_THREAD,		"forker_thread")	\
+	EMe(WB_REASON_FOREIGN_FLUSH,		"foreign_flush")
 
 WB_WORK_REASON
 
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw

This should go through the folks that maintain the write back trace events.

-- Steve

Quoted 26 lines · On Sun, 2 May 2021 08:12:27 +0800 brookxu <[email protected]> wrote:

From: Chunguang Xu <[email protected]>

Now WB_REASON_FOREIGN_FLUSH is displayed as a number, maybe a string is better.

v2: replace some space with tab.

---
 include/trace/events/writeback.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/trace/events/writeback.h +2 -1
index 1efa463..7c78c04 100644
@@ -36,7 +36,8 @@
 	EM( WB_REASON_PERIODIC,			"periodic")		\
 	EM( WB_REASON_LAPTOP_TIMER,		"laptop_timer")		\
 	EM( WB_REASON_FS_FREE_SPACE,		"fs_free_space")	\
-	EMe(WB_REASON_FORKER_THREAD,		"forker_thread")
+	EM( WB_REASON_FORKER_THREAD,		"forker_thread")	\
+	EMe(WB_REASON_FOREIGN_FLUSH,		"foreign_flush")
 
 WB_WORK_REASON
 
maintainer
#2 lore raw
In reply to brookxu

Andrew,

Would you like to take this?

-- Steve

Quoted 26 lines · On Sun, 2 May 2021 08:12:27 +0800 brookxu <[email protected]> wrote:

From: Chunguang Xu <[email protected]>

Now WB_REASON_FOREIGN_FLUSH is displayed as a number, maybe a string is better.

v2: replace some space with tab.

---
 include/trace/events/writeback.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/trace/events/writeback.h +2 -1
index 1efa463..7c78c04 100644
@@ -36,7 +36,8 @@
 	EM( WB_REASON_PERIODIC,			"periodic")		\
 	EM( WB_REASON_LAPTOP_TIMER,		"laptop_timer")		\
 	EM( WB_REASON_FS_FREE_SPACE,		"fs_free_space")	\
-	EMe(WB_REASON_FORKER_THREAD,		"forker_thread")
+	EM( WB_REASON_FORKER_THREAD,		"forker_thread")	\
+	EMe(WB_REASON_FOREIGN_FLUSH,		"foreign_flush")
 
 WB_WORK_REASON