ib_srpt: Remove redundant assignment to ret
Subsystems (3)
PATCH 1/1 ib_srpt: Remove redundant assignment to ret
Variable 'ret' is set to -ENOMEM but this value is never read as it is overwritten with a new value later on, hence it is a redundant assignment and can be removed
In 'commit b79fafac70fc ("target: make queue_tm_rsp() return void")' srpt_queue_response() has been changed to return void, so after "goto out", there is no need to return ret.
Clean up the following clang-analyzer warning:
drivers/infiniband/ulp/srpt/ib_srpt.c:2860:3: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores]
--- drivers/infiniband/ulp/srpt/ib_srpt.c | 1 - 1 file changed, 1 deletion(-)
drivers/infiniband/ulp/srpt/ib_srpt.c +0 -1
@@ -2858,7 +2858,6 @@ static void srpt_queue_response(struct se_cmd *cmd) &ch->sq_wr_avail) < 0)) {pr_warn ("%s: IB send queue full (needed %d)\n" , __func__, ioctx->n_rdma); - ret = -ENOMEM ; goto out; }
Signature · 1 line
1.8.3.1
Quoted 10 lines · Yang Li
Variable 'ret' is set to
-ENOMEMbut this value is never read as it is overwritten with a new value later on, hence it is a redundant assignment and can be removedIn 'commit
b79fafac70fc("target: makequeue_tm_rsp()return void")'srpt_queue_response()has been changed to return void, so after "goto out", there is no need to return ret.Clean up the following clang-analyzer warning:
Quoted 9 lines
drivers/infiniband/ulp/srpt/ib_srpt.c:2860:3: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores]Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>--- drivers/infiniband/ulp/srpt/ib_srpt.c | 1 - 1 file changed, 1 deletion(-)
Thanks,
Quoted 21 lines · Leon Romanovsky
Quoted 10 lines · Yang Li
Variable 'ret' is set to
-ENOMEMbut this value is never read as it is overwritten with a new value later on, hence it is a redundant assignment and can be removedIn 'commit
b79fafac70fc("target: makequeue_tm_rsp()return void")'srpt_queue_response()has been changed to return void, so after "goto out", there is no need to return ret.Clean up the following clang-analyzer warning:
Quoted 9 lines
drivers/infiniband/ulp/srpt/ib_srpt.c:2860:3: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores]Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>--- drivers/infiniband/ulp/srpt/ib_srpt.c | 1 - 1 file changed, 1 deletion(-)
Quoted 4 lines
Fixes b99f8e4d7bcd ("IB/srpt: convert to the generic RDMA READ/WRITE API")Thanks,
Reviewed-by Leon Romanovsky <[email protected]>
Reverting commit b99f8e4d7bcd and handling queue_*_rsp() errors in the LIO core probably would be a better approach. Anyway:
Quoted 13 lines · Yang Li
Variable 'ret' is set to
-ENOMEMbut this value is never read as it is overwritten with a new value later on, hence it is a redundant assignment and can be removedIn 'commit
b79fafac70fc("target: makequeue_tm_rsp()return void")'srpt_queue_response()has been changed to return void, so after "goto out", there is no need to return ret.Clean up the following clang-analyzer warning:
drivers/infiniband/ulp/srpt/ib_srpt.c:2860:3: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores]
Quoted 7 lines
Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>Reviewed-by Leon Romanovsky <[email protected]>Reviewed-by Bart Van Assche <[email protected]>--- drivers/infiniband/ulp/srpt/ib_srpt.c | 1 - 1 file changed, 1 deletion(-)
Applied to for-next
Thanks,
Jason