Skip to contentSkip to conversation

crypto: cavium/nitrox - Remove redundant initialization of 'sg'

PATCH In review Yang Li 2 participants 2 messages May 7, 2021 – May 14, 2021 Crypto API

lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 crypto: cavium/nitrox - Remove redundant initialization of 'sg'

Pointer 'sg' is being initialized however this value is never read as 'sg' is assigned a same value in for_each_sg(). Remove the redundant assignment.

Cleans up clang warning:

drivers/crypto/cavium/nitrox/nitrox_reqmgr.c:161:22: warning: Value stored to 'sg' during its initialization is never read [clang-analyzer-deadcode.DeadStores]

Reported-by Abaci Robot <[email protected]>
Signed-off-by Yang Li <[email protected]>
---
 drivers/crypto/cavium/nitrox/nitrox_reqmgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/cavium/nitrox/nitrox_reqmgr.c +1 -1
index df95ba2..bc35d4c 100644
@@ -159,7 +159,7 @@ static int dma_map_inbufs(struct nitrox_softreq *sr,
 			  struct se_crypto_request *req)
 {
 	struct device *dev = DEV(sr->ndev);
-	struct scatterlist *sg = req->src;
+	struct scatterlist *sg;
 	int i, nents, ret = 0;
 
 	nents = dma_map_sg(dev, req->src, sg_nents(req->src),
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw
Quoted 10 lines · Yang Li

Pointer 'sg' is being initialized however this value is never read as 'sg' is assigned a same value in for_each_sg(). Remove the redundant assignment.

Cleans up clang warning:

drivers/crypto/cavium/nitrox/nitrox_reqmgr.c:161:22: warning: Value stored to 'sg' during its initialization is never read [clang-analyzer-deadcode.DeadStores]

Quoted 5 lines
Reported-by Abaci Robot <[email protected]>
Signed-off-by Yang Li <[email protected]>
---
 drivers/crypto/cavium/nitrox/nitrox_reqmgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt