tracing: Remove redundant assignment to event_var
PATCH v2 1/1 tracing: Remove redundant assignment to event_var
Variable event_var is set to 'ERR_PTR(-EINVAL)', but this value is never read as it is overwritten or not used later on, hence it is a redundant assignment and can be removed.
Clean up the following clang-analyzer warning:
kernel/trace/trace_events_hist.c:2437:21: warning: Value stored to 'event_var' during its initialization is never read [clang-analyzer-deadcode.DeadStores].
Reported-by Abaci Robot <[email protected]>
Signed-off-by Jiapeng Chong <[email protected]>
---
Changes in v2:
-Move the declaration of event_var below key_field, as their names
are both the same size in length and are of the same type. This keeps the "upside-down x-mas tree" look of the declarations. For the follow advice: https://lore.kernel.org/patchwork/patch/1422518/
kernel/trace/trace_events_hist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/trace_events_hist.c +1 -1
@@ -2434,12 +2434,12 @@ static struct trace_event_file *event_file(struct trace_array *tr, char *subsys_name, char *event_name, char *field_name) { struct trace_array *tr = target_hist_data->event_file->tr; -struct hist_field *event_var =ERR_PTR (-EINVAL );struct hist_trigger_data *hist_data;unsigned int i, n, first = true;struct field_var_hist *var_hist;struct trace_event_file *file;struct hist_field *key_field; +struct hist_field *event_var;char *saved_filter;char *cmd;int ret;
Signature · 1 line
1.8.3.1