FAILED: patch "[PATCH] phy: cadence: Sierra: Fix PHY power_on sequence" failed to apply to 5.4-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 5.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 5b4f5757f83be34d1428a1ffbb68d4a1966e9aae Mon Sep 17 00:00:00 2001
From: Kishon Vijay Abraham I <[email protected]>
Date: Fri, 19 Mar 2021 18:11:16 +0530
Subject: [PATCH] phy: cadence: Sierra: Fix PHY power_on sequence
Commit 44d30d622821d ("phy: cadence: Add driver for Sierra PHY") de-asserts PHY_RESET even before the configurations are loaded in phy_init(). However PHY_RESET should be de-asserted only after all the configurations has been initialized, instead of de-asserting in probe. Fix it here.
drivers/phy/cadence/phy-cadence-sierra.c +6 -1
@@ -319,6 +319,12 @@ static int cdns_sierra_phy_on(struct phy *gphy)u32 val;int ret; + ret =reset_control_deassert (sp->phy_rst); +if (ret) { +dev_err (dev,"Failed to take the PHY out of reset\n" ); +return ret; + } +/* Take the PHY lane group out of reset */ ret =reset_control_deassert (ins->lnk_rst);if (ret) {
@@ -616,7 +622,6 @@ static int cdns_sierra_phy_probe(struct platform_device *pdev)pm_runtime_enable (dev); phy_provider =devm_of_phy_provider_register (dev, of_phy_simple_xlate); -reset_control_deassert (sp->phy_rst);return PTR_ERR_OR_ZERO (phy_provider); put_child: