Skip to contentSkip to conversation

dt-bindings: mfd: add Broadcom CRU

PATCH Superseded Rafał Miłecki 4 participants 14 messages Apr 15, 2021 – May 21, 2021

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: mfd: add Broadcom CRU

From: Rafał Miłecki <[email protected]>

CRU is a block used in e.g. Northstar devices. It can be seen in the bcm5301x.dtsi and this binding documents its proper usage.

---
This is reworked version of the
[PATCH robh next] dt-bindings: bus: add Broadcom CRU
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/

---
 .../devicetree/bindings/mfd/brcm,cru.yaml     | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/brcm,cru.yaml
Documentation/devicetree/bindings/mfd/brcm,cru.yaml new file +46 -0
new file mode 100644
index 000000000000..f5bce6453c33
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/brcm,cru.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom CRU
+
+maintainers:
+  - Rafał Miłecki <[email protected]>
+
+description: |
+  Broadcom CRU ("Clock and Reset Unit" or "Central Resource Unit") is a hardware
+  block grouping smaller blocks. On Broadcom Northstar platform it contains e.g.
+  clocks, pinctrl, USB PHY and thermal.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - brcm,ns-cru
+      - const: simple-mfd
+
+  reg:
+    description: CRU registers
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 1
+
+additionalProperties: true
+
+required:
+  - reg
+
+examples:
+  - |
+    cru-bus@1800c100 {
+      compatible = "brcm,ns-cru", "simple-mfd";
+      reg = <0x1800c100 0x1d0>;
+      ranges;
+      #address-cells = <1>;
+      #size-cells = <1>;
+    };
Signature · 1 line
2.26.2
maintainer
#1 lore raw
Quoted 26 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

CRU is a block used in e.g. Northstar devices. It can be seen in the bcm5301x.dtsi and this binding documents its proper usage.

---
This is reworked version of the
[PATCH robh next] dt-bindings: bus: add Broadcom CRU
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/

---
 .../devicetree/bindings/mfd/brcm,cru.yaml     | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/brcm,cru.yaml
Documentation/devicetree/bindings/mfd/brcm,cru.yaml new file +5 -0
new file mode 100644
index 000000000000..f5bce6453c33
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/brcm,cru.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#

Documentation/devicetree/bindings/mfd/brcm,cru.yaml line 15

Quoted 10 lines
Documentation/devicetree/bindings/mfd/brcm,cru.yaml new file +10 -0
+
+title: Broadcom CRU
+
+maintainers:
+  - Rafał Miłecki <[email protected]>
+
+description: |
+  Broadcom CRU ("Clock and Reset Unit" or "Central Resource Unit") is a hardware
+  block grouping smaller blocks. On Broadcom Northstar platform it contains e.g.
+  clocks, pinctrl, USB PHY and thermal.

As I said before, this needs to be a complete binding.

Documentation/devicetree/bindings/mfd/brcm,cru.yaml line 22

Quoted 7 lines
Documentation/devicetree/bindings/mfd/brcm,cru.yaml new file +7 -0
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - brcm,ns-cru
+      - const: simple-mfd

As of now, it is not a 'simple-mfd' because there are no defined children.

Documentation/devicetree/bindings/mfd/brcm,cru.yaml line 33

Quoted 11 lines
Documentation/devicetree/bindings/mfd/brcm,cru.yaml new file +11 -0
+
+  reg:
+    description: CRU registers
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 1
+
+additionalProperties: true

This needs to be 'false' (and then any child nodes defined).

Quoted 16 lines
Documentation/devicetree/bindings/mfd/brcm,cru.yaml new file +13 -0
+
+required:
+  - reg
+
+examples:
+  - |
+    cru-bus@1800c100 {
+      compatible = "brcm,ns-cru", "simple-mfd";
+      reg = <0x1800c100 0x1d0>;
+      ranges;
+      #address-cells = <1>;
+      #size-cells = <1>;
+    };
Signature · 1 line
2.26.2
#2 lore raw

PATCH v2 1/1 dt-bindings: mfd: add Broadcom CRU

In reply to Rafał Miłecki

From: Rafał Miłecki <[email protected]>

CRU is a block used in e.g. Northstar devices. It can be seen in the bcm5301x.dtsi and this binding documents its proper usage.

---
V2: Use complete binding & change additionalProperties to false

NOTICE: this patch is based on top of the linux-next as it requires:
ac5f8197d15c ("dt-bindings: pinctrl: convert Broadcom Northstar to the json-schema") 08e9fdfbb224 ("dt-bindings: thermal: brcm,ns-thermal: Convert to the json-schema") AND merged [email protected]:Broadcom/stblinux.git devicetree/next as it requires:
8f711f68cffd ("dt-bindings: clock: brcm, iproc-clocks: convert to the json-schema")

This is reworked version of the
[PATCH robh next] dt-bindings: bus: add Broadcom CRU
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/

---
 .../devicetree/bindings/mfd/brcm,cru.yaml     | 89 +++++++++++++++++++
 1 file changed, 89 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/brcm,cru.yaml
Documentation/devicetree/bindings/mfd/brcm,cru.yaml new file +89 -0
new file mode 100644
index 000000000000..d92424cc8226
@@ -0,0 +1,89 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/brcm,cru.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom CRU
+
+maintainers:
+  - Rafał Miłecki <[email protected]>
+
+description: |
+  Broadcom CRU ("Clock and Reset Unit" or "Central Resource Unit") is a hardware
+  block grouping smaller blocks. On Broadcom Northstar platform it contains e.g.
+  clocks, pinctrl, USB PHY and thermal.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - brcm,ns-cru
+      - const: simple-mfd
+
+  reg:
+    description: CRU registers
+
+  ranges: true
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 1
+
+  pinctrl:
+    $ref: ../pinctrl/brcm,ns-pinmux.yaml
+
+patternProperties:
+  '^lcpll0@[a-f0-9]+$':
+    $ref: ../clock/brcm,iproc-clocks.yaml
+
+  '^genpll@[a-f0-9]+$':
+    $ref: ../clock/brcm,iproc-clocks.yaml
+
+  '^thermal@[a-f0-9]+$':
+    $ref: ../thermal/brcm,ns-thermal.yaml
+
+additionalProperties: false
+
+required:
+  - reg
+
+examples:
+  - |
+    cru-bus@1800c100 {
+        compatible = "brcm,ns-cru", "simple-mfd";
+        reg = <0x1800c100 0x1d0>;
+        ranges;
+        #address-cells = <1>;
+        #size-cells = <1>;
+
+        lcpll0@100 {
+            #clock-cells = <1>;
+            compatible = "brcm,nsp-lcpll0";
+            reg = <0x100 0x14>;
+            clocks = <&osc>;
+            clock-output-names = "lcpll0", "pcie_phy", "sdio", "ddr_phy";
+        };
+
+        genpll@140 {
+            #clock-cells = <1>;
+            compatible = "brcm,nsp-genpll";
+            reg = <0x140 0x24>;
+            clocks = <&osc>;
+            clock-output-names = "genpll", "phy", "ethernetclk", "usbclk",
+                                 "iprocfast", "sata1", "sata2";
+        };
+
+        pinctrl {
+            compatible = "brcm,bcm4708-pinmux";
+            offset = <0x1c0>;
+        };
+
+        thermal@2c0 {
+            compatible = "brcm,ns-thermal";
+            reg = <0x2c0 0x10>;
+            #thermal-sensor-cells = <0>;
+        };
+    };
Signature · 1 line
2.26.2
maintainer
#3 lore raw
Quoted 15 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

CRU is a block used in e.g. Northstar devices. It can be seen in the bcm5301x.dtsi and this binding documents its proper usage.

---
V2: Use complete binding & change additionalProperties to false

NOTICE: this patch is based on top of the linux-next as it requires:
ac5f8197d15c ("dt-bindings: pinctrl: convert Broadcom Northstar to the json-schema") 08e9fdfbb224 ("dt-bindings: thermal: brcm,ns-thermal: Convert to the json-schema") AND merged [email protected]:Broadcom/stblinux.git devicetree/next as it requires:
8f711f68cffd ("dt-bindings: clock: brcm, iproc-clocks: convert to the json-schema")

Quoted 8 lines

This is reworked version of the
[PATCH robh next] dt-bindings: bus: add Broadcom CRU
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/

---
 .../devicetree/bindings/mfd/brcm,cru.yaml     | 89 +++++++++++++++++++
 1 file changed, 89 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/brcm,cru.yaml

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/pinctrl/brcm,ns-pinmux.yaml'
xargs: dt-doc-validate: exited with status 255; aborting
make[1]: *** Deleting file 'Documentation/devicetree/bindings/mfd/brcm,cru.example.dt.yaml'
Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/pinctrl/brcm,ns-pinmux.yaml' make[1]: *** [scripts/Makefile.lib:380: Documentation/devicetree/bindings/mfd/brcm,cru.example.dt.yaml] Error 255
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1416: dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1480763

This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit.

maintainer Reviewed-by on v2 1/1
#4 lore raw
In reply to Rafał Miłecki
Quoted 62 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

CRU is a block used in e.g. Northstar devices. It can be seen in the bcm5301x.dtsi and this binding documents its proper usage.

---
V2: Use complete binding & change additionalProperties to false

NOTICE: this patch is based on top of the linux-next as it requires:
ac5f8197d15c ("dt-bindings: pinctrl: convert Broadcom Northstar to the json-schema") 08e9fdfbb224 ("dt-bindings: thermal: brcm,ns-thermal: Convert to the json-schema") AND merged [email protected]:Broadcom/stblinux.git devicetree/next as it requires:
8f711f68cffd ("dt-bindings: clock: brcm, iproc-clocks: convert to the json-schema")

This is reworked version of the
[PATCH robh next] dt-bindings: bus: add Broadcom CRU
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/

---
 .../devicetree/bindings/mfd/brcm,cru.yaml     | 89 +++++++++++++++++++
 1 file changed, 89 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/brcm,cru.yaml
Documentation/devicetree/bindings/mfd/brcm,cru.yaml new file +33 -0
new file mode 100644
index 000000000000..d92424cc8226
@@ -0,0 +1,89 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/brcm,cru.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom CRU
+
+maintainers:
+  - Rafał Miłecki <[email protected]>
+
+description: |
+  Broadcom CRU ("Clock and Reset Unit" or "Central Resource Unit") is a hardware
+  block grouping smaller blocks. On Broadcom Northstar platform it contains e.g.
+  clocks, pinctrl, USB PHY and thermal.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - brcm,ns-cru
+      - const: simple-mfd
+
+  reg:
+    description: CRU registers
+
+  ranges: true
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 1

Documentation/devicetree/bindings/mfd/brcm,cru.yaml line 43

Quoted 10 lines
Documentation/devicetree/bindings/mfd/brcm,cru.yaml new file +10 -0
+
+  pinctrl:
+    $ref: ../pinctrl/brcm,ns-pinmux.yaml
+
+patternProperties:
+  '^lcpll0@[a-f0-9]+$':
+    $ref: ../clock/brcm,iproc-clocks.yaml
+
+  '^genpll@[a-f0-9]+$':
+    $ref: ../clock/brcm,iproc-clocks.yaml

clock-controller@... for both.

With that changed,

Quoted 49 lines
Documentation/devicetree/bindings/mfd/brcm,cru.yaml new file +46 -0
+
+  '^thermal@[a-f0-9]+$':
+    $ref: ../thermal/brcm,ns-thermal.yaml
+
+additionalProperties: false
+
+required:
+  - reg
+
+examples:
+  - |
+    cru-bus@1800c100 {
+        compatible = "brcm,ns-cru", "simple-mfd";
+        reg = <0x1800c100 0x1d0>;
+        ranges;
+        #address-cells = <1>;
+        #size-cells = <1>;
+
+        lcpll0@100 {
+            #clock-cells = <1>;
+            compatible = "brcm,nsp-lcpll0";
+            reg = <0x100 0x14>;
+            clocks = <&osc>;
+            clock-output-names = "lcpll0", "pcie_phy", "sdio", "ddr_phy";
+        };
+
+        genpll@140 {
+            #clock-cells = <1>;
+            compatible = "brcm,nsp-genpll";
+            reg = <0x140 0x24>;
+            clocks = <&osc>;
+            clock-output-names = "genpll", "phy", "ethernetclk", "usbclk",
+                                 "iprocfast", "sata1", "sata2";
+        };
+
+        pinctrl {
+            compatible = "brcm,bcm4708-pinmux";
+            offset = <0x1c0>;
+        };
+
+        thermal@2c0 {
+            compatible = "brcm,ns-thermal";
+            reg = <0x2c0 0x10>;
+            #thermal-sensor-cells = <0>;
+        };
+    };
Signature · 1 line
2.26.2
#5 lore raw

PATCH v3 1/1 dt-bindings: mfd: add Broadcom CRU

In reply to Rafał Miłecki

From: Rafał Miłecki <[email protected]>

CRU is a block used in e.g. Northstar devices. It can be seen in the bcm5301x.dtsi and this binding documents its proper usage.

---
Rob: would you take this patch through your dt/next?

V2: Use complete binding & change additionalProperties to false
V3: Use clock-controller@ for clocks

NOTICE: this patch is based on top of the linux-next as it requires:
ac5f8197d15c ("dt-bindings: pinctrl: convert Broadcom Northstar to the json-schema") 08e9fdfbb224 ("dt-bindings: thermal: brcm,ns-thermal: Convert to the json-schema") AND merged [email protected]:Broadcom/stblinux.git devicetree/next as it requires:
8f711f68cffd ("dt-bindings: clock: brcm, iproc-clocks: convert to the json-schema")

This is reworked version of the
[PATCH robh next] dt-bindings: bus: add Broadcom CRU
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/

---
 .../devicetree/bindings/mfd/brcm,cru.yaml     | 86 +++++++++++++++++++
 1 file changed, 86 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/brcm,cru.yaml
Documentation/devicetree/bindings/mfd/brcm,cru.yaml new file +86 -0
new file mode 100644
index 000000000000..fc1317ab3226
@@ -0,0 +1,86 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/brcm,cru.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom CRU
+
+maintainers:
+  - Rafał Miłecki <[email protected]>
+
+description: |
+  Broadcom CRU ("Clock and Reset Unit" or "Central Resource Unit") is a hardware
+  block grouping smaller blocks. On Broadcom Northstar platform it contains e.g.
+  clocks, pinctrl, USB PHY and thermal.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - brcm,ns-cru
+      - const: simple-mfd
+
+  reg:
+    description: CRU registers
+
+  ranges: true
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 1
+
+  pinctrl:
+    $ref: ../pinctrl/brcm,ns-pinmux.yaml
+
+patternProperties:
+  '^clock-controller@[a-f0-9]+$':
+    $ref: ../clock/brcm,iproc-clocks.yaml
+
+  '^thermal@[a-f0-9]+$':
+    $ref: ../thermal/brcm,ns-thermal.yaml
+
+additionalProperties: false
+
+required:
+  - reg
+
+examples:
+  - |
+    cru-bus@1800c100 {
+        compatible = "brcm,ns-cru", "simple-mfd";
+        reg = <0x1800c100 0x1d0>;
+        ranges;
+        #address-cells = <1>;
+        #size-cells = <1>;
+
+        clock-controller@100 {
+            #clock-cells = <1>;
+            compatible = "brcm,nsp-lcpll0";
+            reg = <0x100 0x14>;
+            clocks = <&osc>;
+            clock-output-names = "lcpll0", "pcie_phy", "sdio", "ddr_phy";
+        };
+
+        clock-controller@140 {
+            #clock-cells = <1>;
+            compatible = "brcm,nsp-genpll";
+            reg = <0x140 0x24>;
+            clocks = <&osc>;
+            clock-output-names = "genpll", "phy", "ethernetclk", "usbclk",
+                                 "iprocfast", "sata1", "sata2";
+        };
+
+        pinctrl {
+            compatible = "brcm,bcm4708-pinmux";
+            offset = <0x1c0>;
+        };
+
+        thermal@2c0 {
+            compatible = "brcm,ns-thermal";
+            reg = <0x2c0 0x10>;
+            #thermal-sensor-cells = <0>;
+        };
+    };
Signature · 1 line
2.26.2
#6 lore raw
Quoted 10 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

CRU is a block used in e.g. Northstar devices. It can be seen in the bcm5301x.dtsi and this binding documents its proper usage.

---
Rob: would you take this patch through your dt/next?

I can't, I don't have the dependencies. It looks like 08e9fdfbb224 is already upstream. For ac5f8197d15c, I could get a stable branch from Linus, but I can't take some random github branch. Even if I got a stable branch for that, that's a lot of extra work for me for 1 patch compared to waiting til next cycle.

My suggestion is get a stable branch/tag from Linus, merge that into the Broadcom branch and then apply this patch. Though really, Linus needed to know the dependency when applying the patch if he doesn't rebase his tree. (I realize the dependency probably happened because of the review).

Quoted 113 lines

V2: Use complete binding & change additionalProperties to false
V3: Use clock-controller@ for clocks

NOTICE: this patch is based on top of the linux-next as it requires:
ac5f8197d15c ("dt-bindings: pinctrl: convert Broadcom Northstar to the json-schema") 08e9fdfbb224 ("dt-bindings: thermal: brcm,ns-thermal: Convert to the json-schema") AND merged [email protected]:Broadcom/stblinux.git devicetree/next as it requires:
8f711f68cffd ("dt-bindings: clock: brcm, iproc-clocks: convert to the json-schema")

This is reworked version of the
[PATCH robh next] dt-bindings: bus: add Broadcom CRU
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/

---
 .../devicetree/bindings/mfd/brcm,cru.yaml     | 86 +++++++++++++++++++
 1 file changed, 86 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/brcm,cru.yaml
Documentation/devicetree/bindings/mfd/brcm,cru.yaml new file +86 -1
new file mode 100644
index 000000000000..fc1317ab3226
@@ -0,0 +1,86 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/brcm,cru.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom CRU
+
+maintainers:
+  - Rafał Miłecki <[email protected]>
+
+description: |
+  Broadcom CRU ("Clock and Reset Unit" or "Central Resource Unit") is a hardware
+  block grouping smaller blocks. On Broadcom Northstar platform it contains e.g.
+  clocks, pinctrl, USB PHY and thermal.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - brcm,ns-cru
+      - const: simple-mfd
+
+  reg:
+    description: CRU registers
+
+  ranges: true
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 1
+
+  pinctrl:
+    $ref: ../pinctrl/brcm,ns-pinmux.yaml
+
+patternProperties:
+  '^clock-controller@[a-f0-9]+$':
+    $ref: ../clock/brcm,iproc-clocks.yaml
+
+  '^thermal@[a-f0-9]+$':
+    $ref: ../thermal/brcm,ns-thermal.yaml
+
+additionalProperties: false
+
+required:
+  - reg
+
+examples:
+  - |
+    cru-bus@1800c100 {
+        compatible = "brcm,ns-cru", "simple-mfd";
+        reg = <0x1800c100 0x1d0>;
+        ranges;
+        #address-cells = <1>;
+        #size-cells = <1>;
+
+        clock-controller@100 {
+            #clock-cells = <1>;
+            compatible = "brcm,nsp-lcpll0";
+            reg = <0x100 0x14>;
+            clocks = <&osc>;
+            clock-output-names = "lcpll0", "pcie_phy", "sdio", "ddr_phy";
+        };
+
+        clock-controller@140 {
+            #clock-cells = <1>;
+            compatible = "brcm,nsp-genpll";
+            reg = <0x140 0x24>;
+            clocks = <&osc>;
+            clock-output-names = "genpll", "phy", "ethernetclk", "usbclk",
+                                 "iprocfast", "sata1", "sata2";
+        };
+
+        pinctrl {
+            compatible = "brcm,bcm4708-pinmux";
+            offset = <0x1c0>;
+        };
+
+        thermal@2c0 {
+            compatible = "brcm,ns-thermal";
+            reg = <0x2c0 0x10>;
+            #thermal-sensor-cells = <0>;
+        };
+    };
--

2.26.2

#7 lore raw
Quoted 18 lines · Rob Herring
Quoted 10 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

CRU is a block used in e.g. Northstar devices. It can be seen in the bcm5301x.dtsi and this binding documents its proper usage.

---
Rob: would you take this patch through your dt/next?

I can't, I don't have the dependencies. It looks like 08e9fdfbb224 is already upstream. For ac5f8197d15c, I could get a stable branch from Linus, but I can't take some random github branch. Even if I got a stable branch for that, that's a lot of extra work for me for 1 patch compared to waiting til next cycle.

Quoted 23 lines

My suggestion is get a stable branch/tag from Linus, merge that into the Broadcom branch and then apply this patch. Though really, Linus needed to know the dependency when applying the patch if he doesn't rebase his tree. (I realize the dependency probably happened because of the review).

Quoted 17 lines

V2: Use complete binding & change additionalProperties to false
V3: Use clock-controller@ for clocks

NOTICE: this patch is based on top of the linux-next as it requires:
ac5f8197d15c ("dt-bindings: pinctrl: convert Broadcom Northstar to the json-schema") 08e9fdfbb224 ("dt-bindings: thermal: brcm,ns-thermal: Convert to the json-schema") AND merged [email protected]:Broadcom/stblinux.git devicetree/next as it requires:
8f711f68cffd ("dt-bindings: clock: brcm, iproc-clocks: convert to the json-schema")

This is reworked version of the
[PATCH robh next] dt-bindings: bus: add Broadcom CRU
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/

---
 .../devicetree/bindings/mfd/brcm,cru.yaml     | 86 +++++++++++++++++++
 1 file changed, 86 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/brcm,cru.yaml

What's the dependency here? It's a new file that doesn't reference anything.

Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
#8 lore raw
Quoted 44 lines · Lee Jones
Quoted 18 lines · Rob Herring
Quoted 10 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

CRU is a block used in e.g. Northstar devices. It can be seen in the bcm5301x.dtsi and this binding documents its proper usage.

---
Rob: would you take this patch through your dt/next?

I can't, I don't have the dependencies. It looks like 08e9fdfbb224 is already upstream. For ac5f8197d15c, I could get a stable branch from Linus, but I can't take some random github branch. Even if I got a stable branch for that, that's a lot of extra work for me for 1 patch compared to waiting til next cycle.

Quoted 23 lines

My suggestion is get a stable branch/tag from Linus, merge that into the Broadcom branch and then apply this patch. Though really, Linus needed to know the dependency when applying the patch if he doesn't rebase his tree. (I realize the dependency probably happened because of the review).

Quoted 17 lines

V2: Use complete binding & change additionalProperties to false
V3: Use clock-controller@ for clocks

NOTICE: this patch is based on top of the linux-next as it requires:
ac5f8197d15c ("dt-bindings: pinctrl: convert Broadcom Northstar to the json-schema") 08e9fdfbb224 ("dt-bindings: thermal: brcm,ns-thermal: Convert to the json-schema") AND merged [email protected]:Broadcom/stblinux.git devicetree/next as it requires:
8f711f68cffd ("dt-bindings: clock: brcm, iproc-clocks: convert to the json-schema")

This is reworked version of the
[PATCH robh next] dt-bindings: bus: add Broadcom CRU
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/

---
  .../devicetree/bindings/mfd/brcm,cru.yaml     | 86 +++++++++++++++++++
  1 file changed, 86 insertions(+)

create mode 100644 Documentation/devicetree/bindings/mfd/brcm,cru.yaml

Quoted 1 line

What's the dependency here? It's a new file that doesn't reference anything.

Without dependencies it will cause warnings for those running "dt_binding_check".

I didn't find it critical so I thought Rob can take in on a promise of what is queued for the next release. It appears Rob has more strict rules so I'll just have to wait for stuff to land in Linus's tree :)

#9 lore raw
Quoted 45 lines · Rafał Miłecki
Quoted 44 lines · Lee Jones
Quoted 41 lines · Rob Herring
Quoted 10 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

CRU is a block used in e.g. Northstar devices. It can be seen in the bcm5301x.dtsi and this binding documents its proper usage.

---
Rob: would you take this patch through your dt/next?

I can't, I don't have the dependencies. It looks like 08e9fdfbb224 is already upstream. For ac5f8197d15c, I could get a stable branch from Linus, but I can't take some random github branch. Even if I got a stable branch for that, that's a lot of extra work for me for 1 patch compared to waiting til next cycle.

My suggestion is get a stable branch/tag from Linus, merge that into the Broadcom branch and then apply this patch. Though really, Linus needed to know the dependency when applying the patch if he doesn't rebase his tree. (I realize the dependency probably happened because of the review).

Quoted 17 lines

V2: Use complete binding & change additionalProperties to false
V3: Use clock-controller@ for clocks

NOTICE: this patch is based on top of the linux-next as it requires:
ac5f8197d15c ("dt-bindings: pinctrl: convert Broadcom Northstar to the json-schema") 08e9fdfbb224 ("dt-bindings: thermal: brcm,ns-thermal: Convert to the json-schema") AND merged [email protected]:Broadcom/stblinux.git devicetree/next as it requires:
8f711f68cffd ("dt-bindings: clock: brcm, iproc-clocks: convert to the json-schema")

This is reworked version of the
[PATCH robh next] dt-bindings: bus: add Broadcom CRU
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/

---
  .../devicetree/bindings/mfd/brcm,cru.yaml     | 86 +++++++++++++++++++
  1 file changed, 86 insertions(+)

create mode 100644 Documentation/devicetree/bindings/mfd/brcm,cru.yaml

Quoted 3 lines
Quoted 1 line

What's the dependency here? It's a new file that doesn't reference anything.

Without dependencies it will cause warnings for those running "dt_binding_check".

No one runs that, it's full of warnings. ;)

Quoted 3 lines

I didn't find it critical so I thought Rob can take in on a promise of what is queued for the next release. It appears Rob has more strict rules so I'll just have to wait for stuff to land in Linus's tree :)

Rob isn't the one taking the patch. :D

I'll apply it in a few days, unless Rob shouts real-loud!

Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
#10 lore raw
Quoted 48 lines · Lee Jones
Quoted 45 lines · Rafał Miłecki
Quoted 44 lines · Lee Jones
Quoted 41 lines · Rob Herring
Quoted 10 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

CRU is a block used in e.g. Northstar devices. It can be seen in the bcm5301x.dtsi and this binding documents its proper usage.

---
Rob: would you take this patch through your dt/next?

I can't, I don't have the dependencies. It looks like 08e9fdfbb224 is already upstream. For ac5f8197d15c, I could get a stable branch from Linus, but I can't take some random github branch. Even if I got a stable branch for that, that's a lot of extra work for me for 1 patch compared to waiting til next cycle.

My suggestion is get a stable branch/tag from Linus, merge that into the Broadcom branch and then apply this patch. Though really, Linus needed to know the dependency when applying the patch if he doesn't rebase his tree. (I realize the dependency probably happened because of the review).

Quoted 17 lines

V2: Use complete binding & change additionalProperties to false
V3: Use clock-controller@ for clocks

NOTICE: this patch is based on top of the linux-next as it requires:
ac5f8197d15c ("dt-bindings: pinctrl: convert Broadcom Northstar to the json-schema") 08e9fdfbb224 ("dt-bindings: thermal: brcm,ns-thermal: Convert to the json-schema") AND merged [email protected]:Broadcom/stblinux.git devicetree/next as it requires:
8f711f68cffd ("dt-bindings: clock: brcm, iproc-clocks: convert to the json-schema")

This is reworked version of the
[PATCH robh next] dt-bindings: bus: add Broadcom CRU
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/

---
  .../devicetree/bindings/mfd/brcm,cru.yaml     | 86 +++++++++++++++++++
  1 file changed, 86 insertions(+)

create mode 100644 Documentation/devicetree/bindings/mfd/brcm,cru.yaml

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

What's the dependency here? It's a new file that doesn't reference anything.

Without dependencies it will cause warnings for those running "dt_binding_check".

No one runs that, it's full of warnings. ;)

That's dtbs_check on dts files which is full of warnings. dt_binding_check for the schema does not have warnings (well, there's a couple typically because either the bindings aren't reviewed or the dependencies are ignored).

Quoted 3 lines
Quoted 3 lines

I didn't find it critical so I thought Rob can take in on a promise of what is queued for the next release. It appears Rob has more strict rules so I'll just have to wait for stuff to land in Linus's tree :)

I care less if other trees break as long as linux-next doesn't.

Quoted 3 lines

Rob isn't the one taking the patch. :D

I'll apply it in a few days, unless Rob shouts real-loud!

I've said it before, MFD and their child bindings need to be applied in 1 tree. If you can't make that happen, then don't apply binding patches.

Rob

#11 lore raw
Quoted 66 lines · Rob Herring
Quoted 48 lines · Lee Jones
Quoted 45 lines · Rafał Miłecki
Quoted 44 lines · Lee Jones
Quoted 41 lines · Rob Herring
Quoted 10 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

CRU is a block used in e.g. Northstar devices. It can be seen in the bcm5301x.dtsi and this binding documents its proper usage.

---
Rob: would you take this patch through your dt/next?

I can't, I don't have the dependencies. It looks like 08e9fdfbb224 is already upstream. For ac5f8197d15c, I could get a stable branch from Linus, but I can't take some random github branch. Even if I got a stable branch for that, that's a lot of extra work for me for 1 patch compared to waiting til next cycle.

My suggestion is get a stable branch/tag from Linus, merge that into the Broadcom branch and then apply this patch. Though really, Linus needed to know the dependency when applying the patch if he doesn't rebase his tree. (I realize the dependency probably happened because of the review).

Quoted 17 lines

V2: Use complete binding & change additionalProperties to false
V3: Use clock-controller@ for clocks

NOTICE: this patch is based on top of the linux-next as it requires:
ac5f8197d15c ("dt-bindings: pinctrl: convert Broadcom Northstar to the json-schema") 08e9fdfbb224 ("dt-bindings: thermal: brcm,ns-thermal: Convert to the json-schema") AND merged [email protected]:Broadcom/stblinux.git devicetree/next as it requires:
8f711f68cffd ("dt-bindings: clock: brcm, iproc-clocks: convert to the json-schema")

This is reworked version of the
[PATCH robh next] dt-bindings: bus: add Broadcom CRU
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/

---
  .../devicetree/bindings/mfd/brcm,cru.yaml     | 86 +++++++++++++++++++
  1 file changed, 86 insertions(+)

create mode 100644 Documentation/devicetree/bindings/mfd/brcm,cru.yaml

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

What's the dependency here? It's a new file that doesn't reference anything.

Without dependencies it will cause warnings for those running "dt_binding_check".

No one runs that, it's full of warnings. ;)

That's dtbs_check on dts files which is full of warnings. dt_binding_check for the schema does not have warnings (well, there's a couple typically because either the bindings aren't reviewed or the dependencies are ignored).

Quoted 3 lines
Quoted 3 lines

I didn't find it critical so I thought Rob can take in on a promise of what is queued for the next release. It appears Rob has more strict rules so I'll just have to wait for stuff to land in Linus's tree :)

I care less if other trees break as long as linux-next doesn't.

Quoted 7 lines
Quoted 3 lines

Rob isn't the one taking the patch. :D

I'll apply it in a few days, unless Rob shouts real-loud!

I've said it before, MFD and their child bindings need to be applied in 1 tree. If you can't make that happen, then don't apply binding patches.

I'm not aware of MFD patches applied anywhere else.

AFAIK, they all come through me.

Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
#12 lore raw
Quoted 73 lines · Lee Jones
Quoted 70 lines · Rob Herring
Quoted 48 lines · Lee Jones
Quoted 45 lines · Rafał Miłecki
Quoted 44 lines · Lee Jones
Quoted 41 lines · Rob Herring
Quoted 10 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

CRU is a block used in e.g. Northstar devices. It can be seen in the bcm5301x.dtsi and this binding documents its proper usage.

---
Rob: would you take this patch through your dt/next?

I can't, I don't have the dependencies. It looks like 08e9fdfbb224 is already upstream. For ac5f8197d15c, I could get a stable branch from Linus, but I can't take some random github branch. Even if I got a stable branch for that, that's a lot of extra work for me for 1 patch compared to waiting til next cycle.

My suggestion is get a stable branch/tag from Linus, merge that into the Broadcom branch and then apply this patch. Though really, Linus needed to know the dependency when applying the patch if he doesn't rebase his tree. (I realize the dependency probably happened because of the review).

Quoted 17 lines

V2: Use complete binding & change additionalProperties to false
V3: Use clock-controller@ for clocks

NOTICE: this patch is based on top of the linux-next as it requires:
ac5f8197d15c ("dt-bindings: pinctrl: convert Broadcom Northstar to the json-schema") 08e9fdfbb224 ("dt-bindings: thermal: brcm,ns-thermal: Convert to the json-schema") AND merged [email protected]:Broadcom/stblinux.git devicetree/next as it requires:
8f711f68cffd ("dt-bindings: clock: brcm, iproc-clocks: convert to the json-schema")

This is reworked version of the
[PATCH robh next] dt-bindings: bus: add Broadcom CRU
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/

---
  .../devicetree/bindings/mfd/brcm,cru.yaml     | 86 +++++++++++++++++++
  1 file changed, 86 insertions(+)

create mode 100644 Documentation/devicetree/bindings/mfd/brcm,cru.yaml

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

What's the dependency here? It's a new file that doesn't reference anything.

Without dependencies it will cause warnings for those running "dt_binding_check".

No one runs that, it's full of warnings. ;)

That's dtbs_check on dts files which is full of warnings. dt_binding_check for the schema does not have warnings (well, there's a couple typically because either the bindings aren't reviewed or the dependencies are ignored).

Quoted 3 lines
Quoted 3 lines

I didn't find it critical so I thought Rob can take in on a promise of what is queued for the next release. It appears Rob has more strict rules so I'll just have to wait for stuff to land in Linus's tree :)

I care less if other trees break as long as linux-next doesn't.

Quoted 3 lines

Rob isn't the one taking the patch. :D

I'll apply it in a few days, unless Rob shouts real-loud!

Quoted 7 lines
Quoted 3 lines

I've said it before, MFD and their child bindings need to be applied in 1 tree. If you can't make that happen, then don't apply binding patches.

I'm not aware of MFD patches applied anywhere else.

AFAIK, they all come through me.

Obviously not, or we wouldn't be having this discussion. The key part is 'AND their child bindings'. The child bindings can't go in via each subsystem because they are dependencies of the main MFD binding schema.

Rob

#13 lore raw
Quoted 78 lines · Rob Herring
Quoted 77 lines · Lee Jones
Quoted 73 lines · Rob Herring
Quoted 48 lines · Lee Jones
Quoted 45 lines · Rafał Miłecki
Quoted 44 lines · Lee Jones
Quoted 41 lines · Rob Herring
Quoted 10 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

CRU is a block used in e.g. Northstar devices. It can be seen in the bcm5301x.dtsi and this binding documents its proper usage.

---
Rob: would you take this patch through your dt/next?

I can't, I don't have the dependencies. It looks like 08e9fdfbb224 is already upstream. For ac5f8197d15c, I could get a stable branch from Linus, but I can't take some random github branch. Even if I got a stable branch for that, that's a lot of extra work for me for 1 patch compared to waiting til next cycle.

My suggestion is get a stable branch/tag from Linus, merge that into the Broadcom branch and then apply this patch. Though really, Linus needed to know the dependency when applying the patch if he doesn't rebase his tree. (I realize the dependency probably happened because of the review).

Quoted 17 lines

V2: Use complete binding & change additionalProperties to false
V3: Use clock-controller@ for clocks

NOTICE: this patch is based on top of the linux-next as it requires:
ac5f8197d15c ("dt-bindings: pinctrl: convert Broadcom Northstar to the json-schema") 08e9fdfbb224 ("dt-bindings: thermal: brcm,ns-thermal: Convert to the json-schema") AND merged [email protected]:Broadcom/stblinux.git devicetree/next as it requires:
8f711f68cffd ("dt-bindings: clock: brcm, iproc-clocks: convert to the json-schema")

This is reworked version of the
[PATCH robh next] dt-bindings: bus: add Broadcom CRU
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/

---
  .../devicetree/bindings/mfd/brcm,cru.yaml     | 86 +++++++++++++++++++
  1 file changed, 86 insertions(+)

create mode 100644 Documentation/devicetree/bindings/mfd/brcm,cru.yaml

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

What's the dependency here? It's a new file that doesn't reference anything.

Without dependencies it will cause warnings for those running "dt_binding_check".

No one runs that, it's full of warnings. ;)

That's dtbs_check on dts files which is full of warnings. dt_binding_check for the schema does not have warnings (well, there's a couple typically because either the bindings aren't reviewed or the dependencies are ignored).

Quoted 3 lines
Quoted 3 lines

I didn't find it critical so I thought Rob can take in on a promise of what is queued for the next release. It appears Rob has more strict rules so I'll just have to wait for stuff to land in Linus's tree :)

I care less if other trees break as long as linux-next doesn't.

Quoted 3 lines

Rob isn't the one taking the patch. :D

I'll apply it in a few days, unless Rob shouts real-loud!

I've said it before, MFD and their child bindings need to be applied in 1 tree. If you can't make that happen, then don't apply binding patches.

Quoted 6 lines
Quoted 3 lines

I'm not aware of MFD patches applied anywhere else.

AFAIK, they all come through me.

Obviously not, or we wouldn't be having this discussion. The key part is 'AND their child bindings'.

I see. That makes more sense.

Quoted 3 lines

The child bindings can't go in via each
subsystem because they are dependencies of the main MFD binding schema.

There is now more of a build-time dependency issue over the documentation than there is the C-code.

That sounds so wrong to me.

Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog