bus: mhi: core: remove redundant initialization of variables state and ee
Subsystems (3)
PATCH 1/1 bus: mhi: core: remove redundant initialization of variables state and ee
From: Colin Ian King <[email protected]>
The variables state and ee are being initialized with values that are never read and are being updated later with a new values. The initializations are redundant and can be removed.
Addresses-Coverity: ("Unused value")
--- drivers/bus/mhi/core/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/bus/mhi/core/main.c +2 -2
@@ -428,9 +428,9 @@ irqreturn_t mhi_intvec_threaded_handler(int irq_number, void *priv) {struct mhi_controller *mhi_cntrl = priv;struct device *dev = &mhi_cntrl->mhi_dev->dev; -enum mhi_state state =MHI_STATE_MAX ; +enum mhi_state state;enum mhi_pm_state pm_state =0 ; -enum mhi_ee_type ee =MHI_EE_MAX ; +enum mhi_ee_type ee;write_lock_irq (&mhi_cntrl->pm_lock);if (!MHI_REG_ACCESS_VALID (mhi_cntrl->pm_state)) {
Signature · 1 line
2.30.2
Quoted 9 lines · Colin King
From: Colin Ian King <[email protected]>
The variables state and ee are being initialized with values that are never read and are being updated later with a new values. The initializations are redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by Colin Ian King <[email protected]>
Quoted 23 lines
--- drivers/bus/mhi/core/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/bus/mhi/core/main.c +2
-3@@ -428,9 +428,9 @@ irqreturn_t mhi_intvec_threaded_handler(int irq_number, void *priv) {struct mhi_controller *mhi_cntrl = priv;struct device *dev = &mhi_cntrl->mhi_dev->dev; -enum mhi_state state =MHI_STATE_MAX ; +enum mhi_state state;enum mhi_pm_state pm_state =0 ; -enum mhi_ee_type ee =MHI_EE_MAX ; +enum mhi_ee_type ee;write_lock_irq (&mhi_cntrl->pm_lock);if (!MHI_REG_ACCESS_VALID (mhi_cntrl->pm_state)) { --2.30.2
Quoted 8 lines · Colin King
From: Colin Ian King <[email protected]>
The variables state and ee are being initialized with values that are never read and are being updated later with a new values. The initializations are redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by Colin Ian King <[email protected]>
Thanks,
Mani
Quoted 23 lines
--- drivers/bus/mhi/core/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/bus/mhi/core/main.c +2
-2@@ -428,9 +428,9 @@ irqreturn_t mhi_intvec_threaded_handler(int irq_number, void *priv) {struct mhi_controller *mhi_cntrl = priv;struct device *dev = &mhi_cntrl->mhi_dev->dev; -enum mhi_state state =MHI_STATE_MAX ; +enum mhi_state state;enum mhi_pm_state pm_state =0 ; -enum mhi_ee_type ee =MHI_EE_MAX ; +enum mhi_ee_type ee;write_lock_irq (&mhi_cntrl->pm_lock);if (!MHI_REG_ACCESS_VALID (mhi_cntrl->pm_state)) {Signature · 1 line
2.30.2
Quoted 8 lines · Colin King
From: Colin Ian King <[email protected]>
The variables state and ee are being initialized with values that are never read and are being updated later with a new values. The initializations are redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by Colin Ian King <[email protected]>
Applied to mhi-next!
Thanks,
Mani
Quoted 23 lines
--- drivers/bus/mhi/core/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/bus/mhi/core/main.c +2
-2@@ -428,9 +428,9 @@ irqreturn_t mhi_intvec_threaded_handler(int irq_number, void *priv) {struct mhi_controller *mhi_cntrl = priv;struct device *dev = &mhi_cntrl->mhi_dev->dev; -enum mhi_state state =MHI_STATE_MAX ; +enum mhi_state state;enum mhi_pm_state pm_state =0 ; -enum mhi_ee_type ee =MHI_EE_MAX ; +enum mhi_ee_type ee;write_lock_irq (&mhi_cntrl->pm_lock);if (!MHI_REG_ACCESS_VALID (mhi_cntrl->pm_state)) {Signature · 1 line
2.30.2
This patch was applied to qcom/linux.git (refs/heads/for-next):
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
Quoted 10 lines · On Thu, 11 Mar 2021 11:17:27 +0000 you wrote:
From: Colin Ian King <[email protected]>
The variables state and ee are being initialized with values that are never read and are being updated later with a new values. The initializations are redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by Colin Ian King <[email protected]>[...]
Here is the summary with links:
- [next] bus: mhi: core: remove redundant initialization of variables state and ee
https://git.kernel.org/qcom/c/70f7025c854c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html